ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
PATCH 1/1 ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
arch/arm/include/asm/system.h declares psci_arch_init(), but it is surrounded by #ifdef CONFIG_ARMV8_PSCI.
psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing function declaration.
---
arch/arm/include/asm/system.h | 1 + 1 file changed, 1 insertion(+)
arch/arm/include/asm/system.h +1 -0
@@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);#ifdef CONFIG_ARMV7_PSCI void psci_arch_cpu_entry (void ); +void psci_arch_init (void );u32 psci_version (void );s32 psci_features (u32 function_id,u32 psci_fid);s32 psci_cpu_off (void );
Signature · 1 line
2.25.1
PATCH 1/1 ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
HI Masahiro,
Quoted 18 lines · Masahiro Yamada
arch/arm/include/asm/system.hdeclarespsci_arch_init(), but it is surrounded by #ifdefCONFIG_ARMV8_PSCI.
psci_arch_init()is called forCONFIG_ARMV7_PSCItoo. Add the missing function declaration.Signed-off-by Masahiro Yamada <[email protected]>---
arch/arm/include/asm/system.h | 1 + 1 file changed, 1 insertion(+)arch/arm/include/asm/system.h +0
-0
arch/arm/include/asm/system.h void mmu_page_table_flush(unsigned long start, unsigned long stop); · line 531
Quoted 4 lines
arch/arm/include/asm/system.h +1
-0@@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);#ifdef CONFIG_ARMV7_PSCI void psci_arch_cpu_entry (void ); +void psci_arch_init (void );
Could you add a function comment too?
Quoted 6 lines
arch/arm/include/asm/system.h +0
-1u32 psci_version (void );s32 psci_features (u32 function_id,u32 psci_fid);s32 psci_cpu_off (void ); --2.25.1
Regards,
Simon
PATCH 1/1 ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
Quoted 24 lines · Simon Glass
HI Masahiro,
Quoted 19 lines · Masahiro Yamada
arch/arm/include/asm/system.hdeclarespsci_arch_init(), but it is surrounded by #ifdefCONFIG_ARMV8_PSCI.
psci_arch_init()is called forCONFIG_ARMV7_PSCItoo. Add the missing function declaration.Signed-off-by Masahiro Yamada <[email protected]>---
arch/arm/include/asm/system.h | 1 + 1 file changed, 1 insertion(+)arch/arm/include/asm/system.h +0
-0@@ -528,6 +528,7 @@ void mmu_page_table_flush(unsigned long start, unsigned long stop);
Quoted 5 lines
arch/arm/include/asm/system.h void mmu_page_table_flush(unsigned long start, unsigned long stop); · line 531
Quoted 3 lines
arch/arm/include/asm/system.h +1
-0#ifdef CONFIG_ARMV7_PSCI void psci_arch_cpu_entry (void ); +void psci_arch_init (void );Could you add a function comment too?
Sorry, I can't.
It was a long time ago that I worked on the psci implementation for my board, so I forgot what psci_arch_init() was actually intended.
I was only interested in fixing
-Wmissing-prototypes warning here.
None of the remaining functions are documented, so "please also do this while you are here" is not a reasonable request, I think.
If people are happy with not fixing the warning,
please feel free to ignore this patch.
Quoted 9 lines
Quoted 6 lines
arch/arm/include/asm/system.h +0
-1u32 psci_version (void );s32 psci_features (u32 function_id,u32 psci_fid);s32 psci_cpu_off (void ); --2.25.1
Regards,
Simon
--
Best Regards
Masahiro Yamada
PATCH 1/1 ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI
In reply to Masahiro YamadaQuoted 7 lines · Masahiro Yamada
arch/arm/include/asm/system.hdeclarespsci_arch_init(), but it is surrounded by #ifdefCONFIG_ARMV8_PSCI.
psci_arch_init()is called forCONFIG_ARMV7_PSCItoo. Add the missing function declaration.Signed-off-by Masahiro Yamada <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/2b6c9831/attachment.sig>