Skip to contentSkip to conversation

rtc: pcf2127: watchdog: handle nowayout feature

PATCH Applied Bruno Thomsen 3 participants 3 messages Jun 4, 2020 – Jun 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: pcf2127: watchdog: handle nowayout feature

Driver does not use module parameter for nowayout, so it need to statically initialize status variable of the watchdog_device based on CONFIG_WATCHDOG_NOWAYOUT.

---
 drivers/rtc/rtc-pcf2127.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/rtc-pcf2127.c +1 -0
index 4e50d6768f13..0f7d0a9a2d18 100644
@@ -441,6 +441,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 	pcf2127->wdd.max_timeout = PCF2127_WD_VAL_MAX;
 	pcf2127->wdd.timeout = PCF2127_WD_VAL_DEFAULT;
 	pcf2127->wdd.min_hw_heartbeat_ms = 500;
+	pcf2127->wdd.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
 
 	watchdog_set_drvdata(&pcf2127->wdd, pcf2127);
 
Signature · 1 line
2.26.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Bruno Thomsen

Driver does not use module parameter for nowayout, so it need to statically initialize status variable of the watchdog_device based on CONFIG_WATCHDOG_NOWAYOUT.

Quoted 19 lines
---
 drivers/rtc/rtc-pcf2127.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/rtc-pcf2127.c +1 -0
index 4e50d6768f13..0f7d0a9a2d18 100644
@@ -441,6 +441,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 	pcf2127->wdd.max_timeout = PCF2127_WD_VAL_MAX;
 	pcf2127->wdd.timeout = PCF2127_WD_VAL_DEFAULT;
 	pcf2127->wdd.min_hw_heartbeat_ms = 500;
+	pcf2127->wdd.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
 
 	watchdog_set_drvdata(&pcf2127->wdd, pcf2127);
 
Signature · 1 line
2.26.2
maintainer Applied
#2 lore raw
In reply to Bruno Thomsen
Quoted 3 lines · Bruno Thomsen

Driver does not use module parameter for nowayout, so it need to statically initialize status variable of the watchdog_device based on CONFIG_WATCHDOG_NOWAYOUT.

Applied, thanks!

[1/1] rtc: pcf2127: watchdog: handle nowayout feature

      commit: 4601e24a6fb819d38d1156d0f690cbe6a42c6d76

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>