sata_rcar: handle pm_runtime_get_sync failure cases
Subsystems (3)
PATCH 1/1 sata_rcar: handle pm_runtime_get_sync failure cases
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/ata/sata_rcar.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/ata/sata_rcar.c +7 -4
@@ -907,7 +907,7 @@ static int sata_rcar_probe(struct platform_device *pdev)pm_runtime_enable (dev); ret =pm_runtime_get_sync (dev);if (ret <0 ) - goto err_pm_disable; + goto err_pm_put; host =ata_host_alloc (dev,1 );if (!host) {
@@ -937,7 +937,6 @@ static int sata_rcar_probe(struct platform_device *pdev) err_pm_put:pm_runtime_put (dev); -err_pm_disable:pm_runtime_disable (dev);return ret; }
@@ -991,8 +990,10 @@ static int sata_rcar_resume(struct device *dev)int ret; ret =pm_runtime_get_sync (dev); -if (ret <0 ) +if (ret <0 ) { +pm_runtime_put (dev);return ret; + }if (priv->type ==RCAR_GEN3_SATA ) {sata_rcar_init_module (priv);
@@ -1017,8 +1018,10 @@ static int sata_rcar_restore(struct device *dev)int ret; ret =pm_runtime_get_sync (dev); -if (ret <0 ) +if (ret <0 ) { +pm_runtime_put (dev);return ret; + }sata_rcar_setup_port (host);
Signature · 1 line
2.17.1
Jens Axboe
AppliedQuoted 3 lines · Navid Emamdoost
Calling
pm_runtime_get_syncincrements the counter even in case of failure, causing incorrect ref count. Callpm_runtime_putifpm_runtime_get_syncfails.
Applied, thanks.
Signature · 1 line
Jens Axboe