Skip to contentSkip to conversation

rtw88: pci: disable aspm for platform inter-op with module parameter

PATCH In review [email protected] 4 participants 10 messages Jun 5, 2020 – Jul 15, 2020 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtw88: pci: disable aspm for platform inter-op with module parameter

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=206411
[2] Note that my lenovo T430 is the same.

Fixes 3dff7c6e3749 ("rtw88: allows to enable/disable HCI link PS mechanism")
---
 drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/net/wireless/realtek/rtw88/pci.c +9 -0
index 8228db9a5fc8..3413973bc475 100644
@@ -14,8 +14,11 @@
 #include "debug.h"
 
 static bool rtw_disable_msi;
+static bool rtw_pci_disable_aspm;
 module_param_named(disable_msi, rtw_disable_msi, bool, 0644);
+module_param_named(disable_aspm, rtw_pci_disable_aspm, bool, 0644);
 MODULE_PARM_DESC(disable_msi, "Set Y to disable MSI interrupt support");
+MODULE_PARM_DESC(disable_aspm, "Set Y to disable PCI ASPM support");
 
 static u32 rtw_pci_tx_queue_idx_addr[] = {
 	[RTW_TX_QUEUE_BK]	= RTK_PCI_TXBD_IDX_BKQ,
@@ -1200,6 +1203,9 @@ static void rtw_pci_clkreq_set(struct rtw_dev *rtwdev, bool enable)
 	u8 value;
 	int ret;
 
+	if (rtw_pci_disable_aspm)
+		return;
+
 	ret = rtw_dbi_read8(rtwdev, RTK_PCIE_LINK_CFG, &value);
 	if (ret) {
 		rtw_err(rtwdev, "failed to read CLKREQ_L1, ret=%d", ret);
@@ -1219,6 +1225,9 @@ static void rtw_pci_aspm_set(struct rtw_dev *rtwdev, bool enable)
 	u8 value;
 	int ret;
 
+	if (rtw_pci_disable_aspm)
+		return;
+
 	ret = rtw_dbi_read8(rtwdev, RTK_PCIE_LINK_CFG, &value);
 	if (ret) {
 		rtw_err(rtwdev, "failed to read ASPM, ret=%d", ret);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 2 lines

[1] https://bugzilla.kernel.org/show_bug.cgi?id=206411
[2] Note that my lenovo T430 is the same.

Sebastian

#2 lore raw
Quoted 12 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Quoted 8 lines

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

Yen-Hsuan

#3 lore raw
Quoted 21 lines · Tony Chuang
Quoted 12 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Quoted 8 lines

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 4 lines

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

Then it does not sound safe to enable it by default.

Quoted 2 lines

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

So for those platform, where the error occurs, you expect that the user manages to read the error message (a backtrace from rtw_dbi_read8()) and connects this the need to set a certain module option.

Quoted 1 line

Yen-Hsuan

Sebastian

#4 lore raw
Quoted 21 lines · Tony Chuang
Quoted 21 lines
Quoted 20 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 6 lines
Quoted 4 lines

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

Then it does not sound safe to enable it by default.

We have had a discussion about this, but I cannot find the thread now. People suggested that the module parameter should not be used. And they think that if the ASPM can help for power consumption, then it should be default enabled. But I think it should be based on that the other platforms will not just fail to bring up the device. However, the platforms are less than the others, not sure if default enable or disable is better.

Quoted 7 lines
Quoted 3 lines

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

So for those platform, where the error occurs, you expect that the user manages to read the error message (a backtrace from rtw_dbi_read8()) and connects this the need to set a certain module option.

Yes, we can discuss if it should be default enabled or not. Otherwise the people with those platforms can only do that to prevent this. Really bad.

Quoted 2 lines

Sebastian

Yen-Hsuan

#5 lore raw
Quoted 29 lines · Tony Chuang
Quoted 21 lines · Tony Chuang
Quoted 21 lines
Quoted 20 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 6 lines
Quoted 4 lines

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

Then it does not sound safe to enable it by default.

Quoted 7 lines

We have had a discussion about this, but I cannot find the thread now. People suggested that the module parameter should not be used. And they think that if the ASPM can help for power consumption, then it should be default enabled. But I think it should be based on that the other platforms will not just fail to bring up the device. However, the platforms are less than the others, not sure if default enable or disable is better.

What I fail to understand is if this error affects other PCI devices as well or just this one. And if it is possible to reset the wifi device and everything gets back no normal. Or is it just the register reading, that spams the log and would affect the system otherwise if you would just avoided after the first fail.

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

So for those platform, where the error occurs, you expect that the user manages to read the error message (a backtrace from rtw_dbi_read8()) and connects this the need to set a certain module option.

Yes, we can discuss if it should be default enabled or not. Otherwise the people with those platforms can only do that to prevent this. Really bad.

It would be good to know the root cause of this. So then default enable would depend on it.
You could have a allow/forbid list based on DMI once you identified good/bad systems but this includes additional maintenance.

I think that at the very least, if the read fails you should give the user additional information how to stop this from happening again. And either stop issuing the commands again or skip driver loading (depending what it means for device stability).

Quoted 1 line

Yen-Hsuan

Sebastian

#6 lore raw
Quoted 51 lines · Sebastian Andrzej Siewior
Quoted 29 lines · Tony Chuang
Quoted 21 lines · Tony Chuang
Quoted 21 lines
Quoted 20 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 6 lines
Quoted 4 lines

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

Then it does not sound safe to enable it by default.

Quoted 7 lines

We have had a discussion about this, but I cannot find the thread now. People suggested that the module parameter should not be used. And they think that if the ASPM can help for power consumption, then it should be default enabled. But I think it should be based on that the other platforms will not just fail to bring up the device. However, the platforms are less than the others, not sure if default enable or disable is better.

What I fail to understand is if this error affects other PCI devices as well or just this one. And if it is possible to reset the wifi device and everything gets back no normal. Or is it just the register reading, that spams the log and would affect the system otherwise if you would just avoided after the first fail.

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

So for those platform, where the error occurs, you expect that the user manages to read the error message (a backtrace from rtw_dbi_read8()) and connects this the need to set a certain module option.

Quoted 7 lines
Quoted 2 lines

Yes, we can discuss if it should be default enabled or not. Otherwise the people with those platforms can only do that to prevent this. Really bad.

It would be good to know the root cause of this. So then default enable would depend on it.
You could have a allow/forbid list based on DMI once you identified good/bad systems but this includes additional maintenance.

I think there should be this kind of quirk list in rtw88 which would disable ASPM automatically on problematic platforms. We should not require the user to figure out the problem on their own and disable ASPM manually using the module parameter.

Quoted 4 lines

I think that at the very least, if the read fails you should give the user additional information how to stop this from happening again. And either stop issuing the commands again or skip driver loading (depending what it means for device stability).

Yes, if we can guess that this is an ASPM problem giving additional information is very helpful for the user, please do that as well.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#7 lore raw
Quoted 62 lines
Quoted 38 lines · Sebastian Andrzej Siewior
Quoted 29 lines · Tony Chuang
Quoted 21 lines · Tony Chuang
Quoted 21 lines
Quoted 20 lines · On 2020-06-05 15:47:03 [+0800], [email protected] wrote:
Quoted 10 lines

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Can you set disable_aspm if rtw_dbi_read8() fails? Or make a test if it is save to use?

If someone notices the warning they still have to search for the warning in order to make the link towards loading the module with the disable_aspm=1 paramter.
Is it known what causes the failure?

Quoted 6 lines
Quoted 4 lines

I think as long as the rtw_dbi_read() fails, the consequent register operation will also fail, and still get an error read/write the register. And this is some sort of PCI issue, and I am not really familiar with it. Such as the root cause or how it fails.

Then it does not sound safe to enable it by default.

Quoted 7 lines

We have had a discussion about this, but I cannot find the thread now. People suggested that the module parameter should not be used. And they think that if the ASPM can help for power consumption, then it should be default enabled. But I think it should be based on that the other platforms will not just fail to bring up the device. However, the platforms are less than the others, not sure if default enable or disable is better.

Quoted 11 lines

What I fail to understand is if this error affects other PCI devices as well or just this one. And if it is possible to reset the wifi device and everything gets back no normal. Or is it just the register reading, that spams the log and would affect the system otherwise if you would just avoided after the first fail.

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

If we can default disable it, then we can help those platforms, but then other platform will suffer from higher power consumption.

So for those platform, where the error occurs, you expect that the user manages to read the error message (a backtrace from rtw_dbi_read8())

and

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

connects this the need to set a certain module option.

Yes, we can discuss if it should be default enabled or not. Otherwise the people with those platforms can only do that to prevent this. Really bad.

It would be good to know the root cause of this. So then default enable would depend on it.
You could have a allow/forbid list based on DMI once you identified good/bad systems but this includes additional maintenance.

Quoted 4 lines

I think there should be this kind of quirk list in rtw88 which would disable ASPM automatically on problematic platforms. We should not require the user to figure out the problem on their own and disable ASPM manually using the module parameter.

OK, I'll add a quirk list for the platforms.

Quoted 9 lines
Quoted 5 lines

I think that at the very least, if the read fails you should give the user additional information how to stop this from happening again. And either stop issuing the commands again or skip driver loading (depending what it means for device stability).

Yes, if we can guess that this is an ASPM problem giving additional information is very helpful for the user, please do that as well.

Yes, should add additional information for the users, so they can help to report the platforms.

Yen-Hsuan

#8 lore raw
In reply to [email protected]
Quoted 11 lines · On 6/5/20 2:47 AM, [email protected] wrote:

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Quoted 2 lines

[1] https://bugzilla.kernel.org/show_bug.cgi?id=206411
[2] Note that my lenovo T430 is the same.

As someone who maintains these drivers in a GitHub repo so that users of older kernels can have access to them, I am in favor of this module option. Only a very few cases would need to disable ASPM, and I see no reason for everyone else to use additional power as would be needed with automatic disabling. Adding a new machine to some quirk list would be more difficult than merely telling a novice user how to turn ASPM off for their system.

In case someone is collecting machines that would need a quirk, I found another one as shown in https://github.com/lwfinger/rtlwifi_new/issues/622. That one is a Lenovo Thinkpad E490.

Larry

#9 lore raw
In reply to [email protected]
Quoted 11 lines · <[email protected]> wrote:

From: Yan-Hsuan Chuang <[email protected]>

Some platforms cannot read the DBI register successfully for the ASPM settings. After the read failed, the bus could be unstable, and the device just became unavailable [1]. For those platforms, the ASPM should be disabled. But as the ASPM can help the driver to save the power consumption in power save mode, the ASPM is still needed. So, add a module parameter for them to disable it, then the device can still work, while others can benefit from the less power consumption that brings by ASPM enabled.

Quoted 5 lines

[1] https://bugzilla.kernel.org/show_bug.cgi?id=206411
[2] Note that my lenovo T430 is the same.

Fixes 3dff7c6e3749 ("rtw88: allows to enable/disable HCI link PS mechanism")

Patch applied to wireless-drivers-next.git, thanks.

68aa716b7dd3 rtw88: pci: disable aspm for platform inter-op with module parameter

Signature · 3 lines
https://patchwork.kernel.org/patch/11589181/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches