Skip to contentSkip to conversation

MAINTAINERS: Add an entry to review Avocado based acceptance tests

PATCH In review Philippe Mathieu-Daudé 4 participants 7 messages Jun 5, 2020 – Jul 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add an entry to review Avocado based acceptance tests

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 3e7d9cb0a5..c2ae2bf390 100644
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture
Signature · 1 line
2.21.3
#1 lore raw
Quoted 15 lines · Philippe Mathieu-Daudé

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +0 -0
index 3e7d9cb0a5..c2ae2bf390 100644

MAINTAINERS S: Maintained · line 2932

Quoted 10 lines
MAINTAINERS +7 -0
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/

Ping...? Please Nack if you don't want to be included.

Quoted 5 lines
MAINTAINERS +1 -0
+
 Documentation
 -------------
 Build system architecture
Acked-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 6 lines · Philippe Mathieu-Daudé

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

Thank you very much for volunteering!

Quoted 26 lines
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 3e7d9cb0a5..c2ae2bf390 100644
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture
Signature · 1 line
2.21.3
Signature · 1 line
Eduardo
#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 20 lines · Philippe Mathieu-Daudé

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +1 -0
index 3e7d9cb0a5..c2ae2bf390 100644
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework

MAINTAINERS S: Maintained · line 2936

Quoted 10 lines
MAINTAINERS +7 -0
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture

Eh I already sent a similar patch... [1].

Considering Wainer reply in [2], patch applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next

[1] https://www.mail-archive.com/[email protected]/msg675105.html
[2] https://www.mail-archive.com/[email protected]/msg675698.html

Reviewed-by on v1 1/1
#5 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 6 lines · Philippe Mathieu-Daudé

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

Quoted 23 lines
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 3e7d9cb0a5..c2ae2bf390 100644
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture
Signature · 1 line
Alex Bennée
#6 lore raw
Quoted 11 lines · Alex Bennée
Quoted 6 lines · Philippe Mathieu-Daudé

Add an entry for to allow reviewers to be notified when acceptance / integration tests are added or modified.
The designated reviewers are not maintainers, subsystem maintainers are expected to merge their tests.

Thanks, but the v2 has already been merged (commit 6634f1c43d).
https://www.mail-archive.com/[email protected]/msg675105.html

Quoted 26 lines
Quoted 24 lines
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 3e7d9cb0a5..c2ae2bf390 100644
@@ -2923,6 +2923,14 @@ S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
+Acceptance (Integration) Testing with the Avocado framework
+W: https://trello.com/b/6Qi1pxVn/avocado-qemu
+R: Cleber Rosa <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
+R: Wainer dos Santos Moschetta <[email protected]>
+S: Odd Fixes
+F: tests/acceptance/
+
 Documentation
 -------------
 Build system architecture