Skip to contentSkip to conversation

x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel()

PATCH In review Benjamin Thiel 3 participants 3 messages Jun 6, 2020 – Jun 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel()

Fix:

arch/x86/xen/enlighten_pv.c:1212:34:
warning: no previous prototype for ‘xen_start_kernel’ [-Wmissing-prototypes] asmlinkage __visible void __init xen_start_kernel(void)

Add a prototype for xen_start_kernel() in a separate xen-specific header.

---
 arch/x86/include/asm/xen/setup.h | 7 +++++++
 arch/x86/xen/enlighten_pv.c      | 1 +
 2 files changed, 8 insertions(+)
 create mode 100644 arch/x86/include/asm/xen/setup.h
arch/x86/include/asm/xen/setup.h new file +7 -0
new file mode 100644
index 000000000000..b7bd97f4b837
@@ -0,0 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_X86_XEN_SETUP_H
+#define _ASM_X86_XEN_SETUP_H
+
+asmlinkage __visible void __init xen_start_kernel(void);
+
+#endif /*_ASM_X86_XEN_SETUP_H */
arch/x86/xen/enlighten_pv.c +1 -0
index 35321f4d49f1..dc0850f09c70 100644
@@ -55,6 +55,7 @@
 #include <asm/xen/hypercall.h>
 #include <asm/xen/hypervisor.h>
 #include <asm/xen/cpuid.h>
+#include <asm/xen/setup.h>
 #include <asm/fixmap.h>
 #include <asm/processor.h>
 #include <asm/proto.h>
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Benjamin Thiel

Fix:

arch/x86/xen/enlighten_pv.c:1212:34:
warning: no previous prototype for ‘xen_start_kernel’ [-Wmissing-prototypes] asmlinkage __visible void __init xen_start_kernel(void)

Add a prototype for xen_start_kernel() in a separate xen-specific header.

TBH I am not sure it's worth a new header file for a routine that is only called from assembly (and never returns). I'd just add the prototype right above function definition, with a comment describing why. I see a few examples of this in the tree. Or maybe we even have an attribute for this case?

(I also suspect the same may be needed for xen_prepare_pvh() BTW).

-boris

maintainer
#2 lore raw
Quoted 4 lines · Boris Ostrovsky

TBH I am not sure it's worth a new header file for a routine that is only called from assembly (and never returns). I'd just add the prototype right above function definition, with a comment describing why.

Right, that works too.

Quoted 2 lines

I see a few examples of this in the tree. Or maybe we even have an attribute for this case?

Not that I'm aware of.

Quoted 1 line

(I also suspect the same may be needed for xen_prepare_pvh() BTW).

Yeah, Benni is working through the rest of them. Btw, the final goal of this whole work is to enable -Wmissing-prototypes by default on x86.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette