Skip to contentSkip to conversation

Enable fp16 scanout on DCE 8 and DCE 10

PATCH New Mario Kleiner 1 participant 3 messages Jun 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

So i'm sending these on the off-chance that DCE-8/10 do support fp16 scanout without hw bugs. Would be nice to enable this if it is supported, even if the hw can't do HDR. This is also useful for non-HDR to get effectively 11 bpc precision from the fb to the display outputs for more precise color reproduction.

thanks,
-mario

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#1 lore raw

PATCH 1/2 drm/amd/display: Enable fp16 also on DCE-10.

Assuming the hw supports fp16, this would be also useful for standard dynamic range displays, not only for HDR use cases, because it would allow to get more precise color reproduction with about ~11 bpc linear precision in the unorm range 0.0 -1.0.

---
 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +1 -1
index a28c4ae0f259..10bb4e6e7bac 100644
@@ -385,7 +385,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {
Signature · 6 lines
2.24.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#2 lore raw

PATCH 2/2 drm/amd/display: Enable fp16 also on DCE-8.

In reply to Mario Kleiner

Assuming the hw supports fp16, this would be also useful for standard dynamic range displays, not only for HDR use cases, because it would allow to get more precise color reproduction with about ~11 bpc linear precision in the unorm range 0.0 -1.0.

---
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1 -1
index a19be9de2df7..0dcea3106886 100644
@@ -402,7 +402,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {
Signature · 6 lines
2.24.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx