Skip to contentSkip to conversation

igc: Remove TCP segmentation TX fail counter

PATCH New Sasha Neftin 2 participants 4 messages Jun 7, 2020 – Jun 24, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igc: Remove TCP segmentation TX fail counter

TCP segmentation TX context fail counter is not
applicable for i225 devices.
This patch comes to clean up this counter.

---
 drivers/net/ethernet/intel/igc/igc_mac.c  | 1 -
 drivers/net/ethernet/intel/igc/igc_main.c | 1 -
 drivers/net/ethernet/intel/igc/igc_regs.h | 1 -
 3 files changed, 3 deletions(-)
drivers/net/ethernet/intel/igc/igc_mac.c +0 -1
index f3f7717b6233..9a5e44ef45f4 100644
@@ -289,7 +289,6 @@ void igc_clear_hw_cntrs_base(struct igc_hw *hw)
 	rd32(IGC_TNCRS);
 	rd32(IGC_HTDPMC);
 	rd32(IGC_TSCTC);
-	rd32(IGC_TSCTFC);
 
 	rd32(IGC_MGTPRC);
 	rd32(IGC_MGTPDC);
drivers/net/ethernet/intel/igc/igc_main.c +0 -1
index b92e7e20ce78..5d70751e8ab3 100644
@@ -3740,7 +3740,6 @@ void igc_update_stats(struct igc_adapter *adapter)
 	adapter->stats.algnerrc += rd32(IGC_ALGNERRC);
 
 	adapter->stats.tsctc += rd32(IGC_TSCTC);
-	adapter->stats.tsctfc += rd32(IGC_TSCTFC);
 
 	adapter->stats.iac += rd32(IGC_IAC);
 	adapter->stats.icrxoc += rd32(IGC_ICRXOC);
drivers/net/ethernet/intel/igc/igc_regs.h +0 -1
index eb3e8e70501d..1c46cec5a799 100644
@@ -181,7 +181,6 @@
 #define IGC_MPTC	0x040F0  /* Multicast Packets Tx Count - R/clr */
 #define IGC_BPTC	0x040F4  /* Broadcast Packets Tx Count - R/clr */
 #define IGC_TSCTC	0x040F8  /* TCP Segmentation Context Tx - R/clr */
-#define IGC_TSCTFC	0x040FC  /* TCP Segmentation Context Tx Fail - R/clr */
 #define IGC_IAC		0x04100  /* Interrupt Assertion Count */
 #define IGC_ICTXPTC	0x0410C  /* Interrupt Cause Tx Pkt Timer Expire Count */
 #define IGC_ICTXATC	0x04110  /* Interrupt Cause Tx Abs Timer Expire Count */
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 igc: Remove TCP segmentation TX fail counter

Quoted 11 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Sasha Neftin
Sent: Sunday, June 7, 2020 1:51 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation TX fail counter

TCP segmentation TX context fail counter is not
applicable for i225 devices.
This patch comes to clean up this counter.

With this patch include I am seeing what appears to be the removed counter when I look at ethtool stats.
----
u1322:[0]/usr/src/kernels/next-queue> ethtool -S eth1|grep seg

     tx_tcp_seg_good: 857
     tx_tcp_seg_failed: 0

u1322:[0]/usr/src/kernels/next-queue>
----

Does something need to be done to strip the counter display? Or am I just looking at a similar counter.

Quoted 58 lines
---
 drivers/net/ethernet/intel/igc/igc_mac.c  | 1 -
 drivers/net/ethernet/intel/igc/igc_main.c | 1 -
 drivers/net/ethernet/intel/igc/igc_regs.h | 1 -
 3 files changed, 3 deletions(-)
drivers/net/ethernet/intel/igc/igc_mac.c +0 -1
index f3f7717b6233..9a5e44ef45f4 100644
@@ -289,7 +289,6 @@ void igc_clear_hw_cntrs_base(struct igc_hw *hw)
 	rd32(IGC_TNCRS);
 	rd32(IGC_HTDPMC);
 	rd32(IGC_TSCTC);
-	rd32(IGC_TSCTFC);
 
 	rd32(IGC_MGTPRC);
 	rd32(IGC_MGTPDC);
drivers/net/ethernet/intel/igc/igc_main.c +0 -1
index b92e7e20ce78..5d70751e8ab3 100644
@@ -3740,7 +3740,6 @@ void igc_update_stats(struct igc_adapter
 *adapter)
 	adapter->stats.algnerrc += rd32(IGC_ALGNERRC);
 
 	adapter->stats.tsctc += rd32(IGC_TSCTC);
-	adapter->stats.tsctfc += rd32(IGC_TSCTFC);
 
 	adapter->stats.iac += rd32(IGC_IAC);
drivers/net/ethernet/intel/igc/igc_main.c +0 -0
 	adapter->stats.icrxoc += rd32(IGC_ICRXOC);
drivers/net/ethernet/intel/igc/igc_regs.h +0 -1
index eb3e8e70501d..1c46cec5a799 100644
@@ -181,7 +181,6 @@
 #define IGC_MPTC	0x040F0  /* Multicast Packets Tx Count - R/clr */
 #define IGC_BPTC	0x040F4  /* Broadcast Packets Tx Count - R/clr */
 #define IGC_TSCTC	0x040F8  /* TCP Segmentation Context Tx - R/clr */
-#define IGC_TSCTFC	0x040FC  /* TCP Segmentation Context Tx Fail - R/clr
 */
 #define IGC_IAC		0x04100  /* Interrupt Assertion Count */
 #define IGC_ICTXPTC	0x0410C  /* Interrupt Cause Tx Pkt Timer Expire

Count */
#define IGC_ICTXATC 0x04110 /* Interrupt Cause Tx Abs Timer Expire
Count */
--
2.11.0

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#2 lore raw

PATCH 1/1 igc: Remove TCP segmentation TX fail counter

Quoted 16 lines · Aaron F
Quoted 11 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Sasha Neftin
Sent: Sunday, June 7, 2020 1:51 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation TX fail counter

TCP segmentation TX context fail counter is not
applicable for i225 devices.
This patch comes to clean up this counter.

With this patch include I am seeing what appears to be the removed counter when I look at ethtool stats.
----
u1322:[0]/usr/src/kernels/next-queue> ethtool -S eth1|grep seg

Quoted 6 lines
      tx_tcp_seg_good: 857
      tx_tcp_seg_failed: 0

u1322:[0]/usr/src/kernels/next-queue>
----

Does something need to be done to strip the counter display? Or am I just looking at a similar counter.

It is ok. You look at right counter exposed by ethtool. I've removed the "TCP Segmentation Context Tx" register not applicable to the i225 device.

Quoted 59 lines
Quoted 59 lines
---
  drivers/net/ethernet/intel/igc/igc_mac.c  | 1 -
  drivers/net/ethernet/intel/igc/igc_main.c | 1 -
  drivers/net/ethernet/intel/igc/igc_regs.h | 1 -
  3 files changed, 3 deletions(-)
drivers/net/ethernet/intel/igc/igc_mac.c +0 -1
index f3f7717b6233..9a5e44ef45f4 100644
@@ -289,7 +289,6 @@ void igc_clear_hw_cntrs_base(struct igc_hw *hw)
  rd32(IGC_TNCRS);
  rd32(IGC_HTDPMC);
  rd32(IGC_TSCTC);
-rd32(IGC_TSCTFC);
 
  rd32(IGC_MGTPRC);
  rd32(IGC_MGTPDC);
drivers/net/ethernet/intel/igc/igc_main.c +0 -1
index b92e7e20ce78..5d70751e8ab3 100644
@@ -3740,7 +3740,6 @@ void igc_update_stats(struct igc_adapter
 *adapter)
  adapter->stats.algnerrc += rd32(IGC_ALGNERRC);
 
  adapter->stats.tsctc += rd32(IGC_TSCTC);
-adapter->stats.tsctfc += rd32(IGC_TSCTFC);
 
  adapter->stats.iac += rd32(IGC_IAC);
  adapter->stats.icrxoc += rd32(IGC_ICRXOC);
drivers/net/ethernet/intel/igc/igc_regs.h +0 -1
index eb3e8e70501d..1c46cec5a799 100644
@@ -181,7 +181,6 @@
  #define IGC_MPTC0x040F0  /* Multicast Packets Tx Count - R/clr */
  #define IGC_BPTC0x040F4  /* Broadcast Packets Tx Count - R/clr */
  #define IGC_TSCTC0x040F8  /* TCP Segmentation Context Tx - R/clr */
-#define IGC_TSCTFC0x040FC  /* TCP Segmentation Context Tx Fail - R/clr
 */
  #define IGC_IAC0x04100  /* Interrupt Assertion Count */
  #define IGC_ICTXPTC0x0410C  /* Interrupt Cause Tx Pkt Timer Expire

Count */
#define IGC_ICTXATC0x04110 /* Interrupt Cause Tx Abs Timer Expire
Count */
--
2.11.0

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#3 lore raw

PATCH 1/1 igc: Remove TCP segmentation TX fail counter

Quoted 32 lines

From: Neftin, Sasha <[email protected]>
Sent: Tuesday, June 23, 2020 8:22 PM
To: Brown, Aaron F <[email protected]>; intel-wired-
lan at lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation TX fail counter

Quoted 2 lines · Aaron F
Quoted 2 lines

From: Intel-wired-lan <[email protected]> On Behalf

Of

Quoted 4 lines
Quoted 4 lines

Sasha Neftin
Sent: Sunday, June 7, 2020 1:51 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation

TX

Quoted 8 lines
Quoted 5 lines

fail counter

TCP segmentation TX context fail counter is not
applicable for i225 devices.
This patch comes to clean up this counter.

With this patch include I am seeing what appears to be the removed

counter when I look at ethtool stats.

Quoted 7 lines

----
u1322:[0]/usr/src/kernels/next-queue> ethtool -S eth1|grep seg

      tx_tcp_seg_good: 857
      tx_tcp_seg_failed: 0

u1322:[0]/usr/src/kernels/next-queue>
----

Quoted 4 lines
Quoted 1 line

Does something need to be done to strip the counter display? Or am I just

looking at a similar counter.
It is ok. You look at right counter exposed by ethtool. I've removed the "TCP Segmentation Context Tx" register not applicable to the i225 device.

Thanks for the explanation.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
---
  drivers/net/ethernet/intel/igc/igc_mac.c  | 1 -
  drivers/net/ethernet/intel/igc/igc_main.c | 1 -
  drivers/net/ethernet/intel/igc/igc_regs.h | 1 -
  3 files changed, 3 deletions(-)