Skip to contentSkip to conversation

rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

PATCH New Mark Kettenis 5 participants 8 messages Jun 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

Enable CONFIG_PCI and CONFIG_NVME and related configs for the Firefly RK3399 board.

---
 configs/firefly-rk3399_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
configs/firefly-rk3399_defconfig +4 -0
index 4c9f1e189b..5bb54f5835 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
@@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYSRESET=y
Signature · 1 line
2.27.0
#1 lore raw

PATCH v3 2/2 rockchip: Enable PCIe and NVMe on ROCKPro64

Enable CONFIG_PCI and CONFIG_NVME and related configs for the ROCKPro64 board.

---
 configs/rockpro64-rk3399_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
configs/rockpro64-rk3399_defconfig +4 -0
index 8c4b2f35c1..23eacddf12 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
@@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
Signature · 1 line
2.27.0
#2 lore raw

PATCH v3 2/2 rockchip: Enable PCIe and NVMe on ROCKPro64

Quoted 6 lines · Mark Kettenis

Enable CONFIG_PCI and CONFIG_NVME and related configs for the ROCKPro64 board.

It's generally considered good taste to cc: the maintainer, you can find out who that is with "./scripts/get_maintainer.pl configs/pinebook-pro-rk3399_defconfig"

Peter

Quoted 33 lines
---
 configs/rockpro64-rk3399_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
configs/rockpro64-rk3399_defconfig +4 -1
index 8c4b2f35c1..23eacddf12 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
@@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
--

2.27.0

#3 lore raw

PATCH v3 2/2 rockchip: Enable PCIe and NVMe on ROCKPro64

Quoted 6 lines · Peter Robinson
Quoted 4 lines · Mark Kettenis

Enable CONFIG_PCI and CONFIG_NVME and related configs for the ROCKPro64 board.

Quoted 7 lines
Quoted 2 lines

It's generally considered good taste to cc: the maintainer, you can find out who that is with "./scripts/get_maintainer.pl configs/pinebook-pro-rk3399_defconfig"

Oh and that comment was meant against the Pinebook pro, I think someone else already sent patches for the RockPro64 to do this

Quoted 35 lines

Peter

Quoted 33 lines
---
 configs/rockpro64-rk3399_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
configs/rockpro64-rk3399_defconfig +4 -1
index 8c4b2f35c1..23eacddf12 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
@@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_REGULATOR_PWM=y
 CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
 CONFIG_RAM_RK3399_LPDDR4=y
 CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_SHIFT=2
--

2.27.0

#4 lore raw

PATCH v3 2/2 rockchip: Enable PCIe and NVMe on ROCKPro64

Quoted 9 lines · Peter Robinson
Quoted 8 lines · Peter Robinson
Quoted 6 lines · Mark Kettenis

Enable CONFIG_PCI and CONFIG_NVME and related configs for the ROCKPro64 board.

Quoted 8 lines
Quoted 5 lines

It's generally considered good taste to cc: the maintainer, you can find out who that is with "./scripts/get_maintainer.pl configs/pinebook-pro-rk3399_defconfig"

Oh and that comment was meant against the Pinebook pro, I think someone else already sent patches for the RockPro64 to do this

Heh. I just took the same list of people that was CCed here. I trusted Mark's mail-sending-skills to already CC the people that are likely to respond to diffs. ;) Maybe next time I'll remember how the script is called.

#5 lore raw

PATCH v3 1/2 rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

In reply to Mark Kettenis

Hi Mark,

??? What's the change in this new version?

Thanks,

- Kever

Quoted 36 lines · Mark Kettenis

Enable CONFIG_PCI and CONFIG_NVME and related configs for the Firefly RK3399 board.

---
  configs/firefly-rk3399_defconfig | 4 ++++
  1 file changed, 4 insertions(+)
configs/firefly-rk3399_defconfig +4 -0
index 4c9f1e189b..5bb54f5835 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
  # CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TIME=y
  CONFIG_SPL_OF_CONTROL=y
@@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000
  CONFIG_DM_ETH=y
  CONFIG_ETH_DESIGNWARE=y
  CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
  CONFIG_PMIC_RK8XX=y
  CONFIG_REGULATOR_PWM=y
  CONFIG_REGULATOR_RK8XX=y
  CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
  CONFIG_BAUDRATE=1500000
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_SYSRESET=y
#6 lore raw

PATCH v3 1/2 rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

Quoted 6 lines

From: Kever Yang <[email protected]>
Date: Sun, 7 Jun 2020 20:32:33 +0800

Hi Mark,

??? What's the change in this new version?

No change. Just regenerated from a clean master such that there are no conflicts when applying.

Quoted 40 lines · Mark Kettenis
Quoted 36 lines

Enable CONFIG_PCI and CONFIG_NVME and related configs for the Firefly RK3399 board.

---
  configs/firefly-rk3399_defconfig | 4 ++++
  1 file changed, 4 insertions(+)
configs/firefly-rk3399_defconfig +4 -0
index 4c9f1e189b..5bb54f5835 100644
@@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_MMC=y
  CONFIG_CMD_USB=y
+CONFIG_CMD_PCI=y
  # CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TIME=y
  CONFIG_SPL_OF_CONTROL=y
@@ -38,10 +39,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000
  CONFIG_DM_ETH=y
  CONFIG_ETH_DESIGNWARE=y
  CONFIG_GMAC_ROCKCHIP=y
+CONFIG_NVME=y
+CONFIG_PCI=y
  CONFIG_PMIC_RK8XX=y
  CONFIG_REGULATOR_PWM=y
  CONFIG_REGULATOR_RK8XX=y
  CONFIG_PWM_ROCKCHIP=y
+CONFIG_DM_RESET=y
  CONFIG_BAUDRATE=1500000
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_SYSRESET=y
#7 lore raw

Re: [PATCH v3 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399【请注意,邮件由[email protected]代发】

Hi Mark,

Quoted 8 lines · Mark Kettenis
Quoted 6 lines

From: Kever Yang <[email protected]>
Date: Sun, 7 Jun 2020 20:32:33 +0800

Hi Mark,

??? What's the change in this new version?

No change. Just regenerated from a clean master such that there are no conflicts when applying.

Thanks, already apply to u-boot-rockchip master.

Thanks,

- Kever