Skip to contentSkip to conversation

Dockerfile: add libguestfs-tools package

PATCH New Heinrich Schuchardt 3 participants 5 messages May 30, 2020 – Jun 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Dockerfile: add libguestfs-tools package

In some of our Python tests we build disk images. Currently this involves using the sudo command for losetup and mount. For some tests sudo is not necessary if the command guestmount of package libguestfs-tools is available. Another useful tool in libguestfs-tools is virt-make-fs.

Generally we should get rid of using a root user for building and testing. As a first step install libguestfs-tools in our Docker image.

---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)
Dockerfile +1 -0
index 4138415..20a861f 100644
@@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
 	iasl \
 	imagemagick \
 	iputils-ping \
+	libguestfs-tools \
 	libisl15 \
 	liblz4-tool \
 	libpixman-1-dev \

--
2.26.2

#1 lore raw

PATCH 1/1 Dockerfile: add libguestfs-tools package

Quoted 18 lines · Heinrich Schuchardt

In some of our Python tests we build disk images. Currently this involves using the sudo command for losetup and mount. For some tests sudo is not necessary if the command guestmount of package libguestfs-tools is available. Another useful tool in libguestfs-tools is virt-make-fs.

Generally we should get rid of using a root user for building and testing. As a first step install libguestfs-tools in our Docker image.

---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)
Dockerfile +0 -0
index 4138415..20a861f 100644

Dockerfile RUN apt-get update && apt-get install -y \ · line 63

Quoted 7 lines
Dockerfile +1 -0
@@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
 	iasl \
 	imagemagick \
 	iputils-ping \
+	libguestfs-tools \
 	libisl15 \
 	liblz4-tool \
 	libpixman-1-dev \

I haven't applied this as in order to also convert any of the tests to libguestfs-tools based approaches, Azure/GitLab (or Travis even) can be locally modified to point at your own fork of the image. If you really need me to push this change to unblock further conversion please let me know, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200605/1b9616d6/attachment.sig>
#2 lore raw

PATCH 1/1 Dockerfile: add libguestfs-tools package

Quoted 15 lines · Tom Rini
Quoted 13 lines · Heinrich Schuchardt

In some of our Python tests we build disk images. Currently this involves using the sudo command for losetup and mount. For some tests sudo is not necessary if the command guestmount of package libguestfs-tools is available. Another useful tool in libguestfs-tools is virt-make-fs.

Generally we should get rid of using a root user for building and testing. As a first step install libguestfs-tools in our Docker image.

---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

Dockerfile RUN apt-get update && apt-get install -y \ · line 63

Quoted 12 lines
Dockerfile +1 -0
index 4138415..20a861f 100644
@@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
 	iasl \
 	imagemagick \
 	iputils-ping \
+	libguestfs-tools \
 	libisl15 \
 	liblz4-tool \
 	libpixman-1-dev \

I haven't applied this as in order to also convert any of the tests to libguestfs-tools based approaches, Azure/GitLab (or Travis even) can be

As far as I know, the only use of sudo can be seen in tests I added:
a test_fs
b test_efi_secboot

(a) has a flexible approach like:
if (tool_is_in_path('guestmount'):

    ...
  else
    check_call('sudo mount ...')

I also took a similar approach in (b) when I posted my patch, but Heinrich deleted "non-sudo" part from my original code when it was merged.

-Takahiro Akashi

Quoted 6 lines

locally modified to point at your own fork of the image. If you really need me to push this change to unblock further conversion please let me know, thanks!

Signature · 1 line
Tom
#3 lore raw

PATCH 1/1 Dockerfile: add libguestfs-tools package

Quoted 38 lines · AKASHI Takahiro
Quoted 15 lines · Tom Rini
Quoted 13 lines · Heinrich Schuchardt

In some of our Python tests we build disk images. Currently this involves using the sudo command for losetup and mount. For some tests sudo is not necessary if the command guestmount of package libguestfs-tools is available. Another useful tool in libguestfs-tools is virt-make-fs.

Generally we should get rid of using a root user for building and testing. As a first step install libguestfs-tools in our Docker image.

---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

Dockerfile RUN apt-get update && apt-get install -y \ · line 63

Quoted 12 lines
Dockerfile +1 -0
index 4138415..20a861f 100644
@@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
 	iasl \
 	imagemagick \
 	iputils-ping \
+	libguestfs-tools \
 	libisl15 \
 	liblz4-tool \
 	libpixman-1-dev \

I haven't applied this as in order to also convert any of the tests to libguestfs-tools based approaches, Azure/GitLab (or Travis even) can be

As far as I know, the only use of sudo can be seen in tests I added:
a test_fs
b test_efi_secboot

(a) has a flexible approach like:
if (tool_is_in_path('guestmount'):

Quoted 7 lines
    ...
  else
    check_call('sudo mount ...')

I also took a similar approach in (b) when I posted my patch, but Heinrich deleted "non-sudo" part from my original code when it was merged.

Ah, I had forgotten that guestmount was part of it already. I'll apply this patch soon then, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/bc6cfe8e/attachment.sig>
Applied
#4 lore raw

PATCH 1/1 Dockerfile: add libguestfs-tools package

In reply to Heinrich Schuchardt
Quoted 9 lines · Heinrich Schuchardt

In some of our Python tests we build disk images. Currently this involves using the sudo command for losetup and mount. For some tests sudo is not necessary if the command guestmount of package libguestfs-tools is available. Another useful tool in libguestfs-tools is virt-make-fs.

Generally we should get rid of using a root user for building and testing. As a first step install libguestfs-tools in our Docker image.

Applied to gitlab-ci-runner/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200619/cc52fb33/attachment.sig>