Skip to contentSkip to conversation

drm/i915/display: Avoid PSR and FBC features concurently.

PATCH In review Jason Le 3 participants 6 messages Jun 8, 2020

Subsystems (3)
lore
Share & tools
lore

Jason Le

author
#0 lore raw

PATCH 1/1 drm/i915/display: Avoid PSR and FBC features concurently.

Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS 13.5" QHD Glare NE135FBM-N41/NC135GFL02). Disbling either PSR or FBC will solve this flicker issue.

Both PSR and FBC features save power when render is not busy. When PSR is active, saving power achieved by source turning off source transmitter and main link, putting memory on self-refresh mode. Therefore with PSR enabled,
FBC role is minimized since PSR power saving already covers most what FBC does. Disabling FBC in case to avoid conflict between PSR and FBC which causes display anomaly in some scenarios.

Tests:
Booted system with PSR enabled, verified FBC disabled. Disabled PSR with disabled (i915.enable_psr=0), verified FBC enabled.

---
 drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++++++
 drivers/gpu/drm/i915/display/intel_psr.c | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_fbc.c +6 -0
index 1c26673acb2d..52bc7483adb5 100644
@@ -1419,6 +1419,12 @@ void intel_fbc_init(struct drm_i915_private *dev_priv)
 	drm_dbg_kms(&dev_priv->drm, "Sanitized enable_fbc value: %d\n",
 		    i915_modparams.enable_fbc);
 
+	if (i915_modparams.enable_psr) {
+               i915_modparams.enable_fbc = 0;
+                DRM_DEBUG_KMS("PSR enabled. FBC no longer needed.  Disable FBC. \n");
+	}
+
+
 	if (!HAS_FBC(dev_priv)) {
 		fbc->no_fbc_reason = "unsupported by this chipset";
 		return;
drivers/gpu/drm/i915/display/intel_psr.c +3 -1
index b7a2c102648a..25accfdd5ad3 100644
@@ -1439,8 +1439,10 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
 	if (!HAS_PSR(dev_priv))
 		return;
 
-	if (!dev_priv->psr.sink_support)
+	if (!dev_priv->psr.sink_support) {
+		i915_modparams.enable_psr = 0;
 		return;
+	}
 
 	if (IS_HASWELL(dev_priv))
 		/*
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Avoid PSR and FBC features concurently.

== Series Details ==

== Series Details ==

Series: drm/i915/display: Avoid PSR and FBC features concurently.
URL : https://patchwork.freedesktop.org/series/78107/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
dee7c897c6ed drm/i915/display: Avoid PSR and FBC features concurently.
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS

-:6: WARNING:TYPO_SPELLING: 'Enble' may be misspelled - perhaps 'Enable'? #6:
Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS

-:29: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15) #29: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1422:
+ if (i915_modparams.enable_psr) {
+ i915_modparams.enable_fbc = 0;

-:30: ERROR:CODE_INDENT: code indent should use tabs where possible #30: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1423:
+ i915_modparams.enable_fbc = 0;$

-:30: WARNING:LEADING_SPACE: please, no spaces at the start of a line #30: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1423:
+ i915_modparams.enable_fbc = 0;$

-:31: ERROR:CODE_INDENT: code indent should use tabs where possible #31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable FBC. \n");$

-:31: WARNING:LEADING_SPACE: please, no spaces at the start of a line #31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable FBC. \n");$

-:31: WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #31: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1424:
+ DRM_DEBUG_KMS("PSR enabled. FBC no longer needed. Disable FBC. \n");

-:34: CHECK:LINE_SPACING: Please don't use multiple blank lines #34: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1427:
+
+

-:53: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 6 warnings, 1 checks, 23 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Avoid PSR and FBC features concurently.

In reply to Jason Le
== Series Details ==

== Series Details ==

Series: drm/i915/display: Avoid PSR and FBC features concurently.
URL : https://patchwork.freedesktop.org/series/78107/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8599 -> Patchwork_17904
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/index.html

Known issues
------------

Here are the changes found in Patchwork_17904 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@reload:
- fi-byt-n2820: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-byt-n2820/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-byt-n2820/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-bsw-n3050/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-bsw-n3050/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-guc: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-icl-guc/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-icl-guc/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [DMESG-WARN][7] ([i915#95]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-whl-u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-whl-u/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-dsi}: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-tgl-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-tgl-dsi/igt@[email protected]

* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-kbl-x1275/igt@kms_busy@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-kbl-x1275/igt@kms_busy@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-bsw-kefka/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-bsw-kefka/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-icl-u2/igt@[email protected]

#### Warnings ####

* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-kbl-x1275/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/fi-kbl-x1275/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (46 -> 41)
------------------------------

Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

Build changes
-------------

* Linux: CI_DRM_8599 -> Patchwork_17904

CI-20190529: 20190529
CI_DRM_8599: 41ca9ea98b74c926c923e84931b9b4a4c3955e08 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5697: 5b8be04285ded1201fac5a2c2b50a7d70fa332d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17904: dee7c897c6ed8262b5655c110352e85c7e13e8c1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

dee7c897c6ed drm/i915/display: Avoid PSR and FBC features concurently.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Avoid PSR and FBC features concurently.

In reply to Jason Le
== Series Details ==

== Series Details ==

Series: drm/i915/display: Avoid PSR and FBC features concurently.
URL : https://patchwork.freedesktop.org/series/78107/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8599_full -> Patchwork_17904_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_17904_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl7/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] / [i915#716])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl7/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#118] / [i915#95]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-glk1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-glk8/igt@[email protected]

* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl10/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-hsw: [PASS][9] -> [DMESG-WARN][10] ([i915#128])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-hsw1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-hsw2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#265])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl9/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109642] / [fdo#111068])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb2/igt@kms_psr2_su@page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb8/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@suspend:
- shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([i915#1185])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb3/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([i915#69])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl10/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_schedule@smoketest-all:
- shard-glk: [DMESG-WARN][21] ([i915#118] / [i915#95]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-glk1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-glk8/igt@[email protected]

* igt@gem_pread@display:
- shard-hsw: [INCOMPLETE][23] ([i915#61]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-hsw4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-hsw7/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][25] ([i915#1436] / [i915#716]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl2/igt@[email protected]
- shard-glk: [DMESG-WARN][27] ([i915#1436] / [i915#716]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-glk8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-glk2/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-skl: [DMESG-WARN][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl5/igt@[email protected]

* igt@kms_atomic@test-only:
- shard-apl: [DMESG-WARN][31] ([i915#95]) -> [PASS][32] +45 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-kbl: [DMESG-FAIL][33] ([i915#54] / [i915#95]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][35] ([i915#57]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-hsw8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-hsw4/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled:
- shard-apl: [DMESG-FAIL][37] ([i915#54] / [i915#95]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl3/igt@[email protected]

* igt@kms_fbcon_fbt@fbc:
- shard-kbl: [FAIL][39] ([i915#64]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][41] ([i915#1525]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl8/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][43] ([i915#180]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl2/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl6/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl8/igt@kms_flip@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
- shard-glk: [INCOMPLETE][47] ([i915#58] / [k.org#198133]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][49] ([i915#93] / [i915#95]) -> [PASS][50] +46 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl7/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][53] ([i915#1188]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl4/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl10/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- shard-apl: [DMESG-FAIL][55] ([i915#95]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl4/igt@[email protected]
- shard-kbl: [DMESG-FAIL][57] ([i915#95]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [DMESG-WARN][59] ([i915#180] / [i915#95]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-skl: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +11 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-skl4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-skl5/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][65] ([fdo#109642] / [fdo#111068]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][69] ([i915#1542]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-iclb1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@atomic:
- shard-apl: [FAIL][71] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][72] ([i915#1319] / [i915#1635])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl8/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-kbl: [TIMEOUT][73] ([i915#1319] / [i915#1958]) -> [TIMEOUT][74] ([i915#1319]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl4/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl7/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-kbl: [TIMEOUT][75] ([i915#1319]) -> [FAIL][76] ([fdo#110321] / [fdo#110336])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-kbl2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-kbl2/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: [TIMEOUT][77] ([i915#1319]) -> [FAIL][78] ([fdo#110321])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8599/shard-apl8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/shard-apl7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_8599 -> Patchwork_17904

CI-20190529: 20190529
CI_DRM_8599: 41ca9ea98b74c926c923e84931b9b4a4c3955e08 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5697: 5b8be04285ded1201fac5a2c2b50a7d70fa332d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17904: dee7c897c6ed8262b5655c110352e85c7e13e8c1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17904/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Jason Le
Quoted 10 lines · Jason Le

Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS 13.5" QHD Glare NE135FBM-N41/NC135GFL02). Disbling either PSR or FBC will solve this flicker issue.

Both PSR and FBC features save power when render is not busy. When PSR is active, saving power achieved by source turning off source transmitter and main link, putting memory on self-refresh mode. Therefore with PSR enabled,
FBC role is minimized since PSR power saving already covers most what FBC does. Disabling FBC in case to avoid conflict between PSR and FBC which causes display anomaly in some scenarios.

The combination of both saves even more power so no to this, we should fix the issue not disable features because of a single panel having issues.

A PSR2 fix was merged yesterday "drm/i915/psr: Program default IO buffer Wake and Fast Wake" try with that, if just that don't fix try set psr_safest_params=1. If this do not helps, please file a bug, add debug information and then we proceed from that.

Quoted 32 lines

Tests:
Booted system with PSR enabled, verified FBC disabled. Disabled PSR with disabled (i915.enable_psr=0), verified FBC enabled.

---
 drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++++++
 drivers/gpu/drm/i915/display/intel_psr.c | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_fbc.c +6 -0
index 1c26673acb2d..52bc7483adb5 100644
@@ -1419,6 +1419,12 @@ void intel_fbc_init(struct drm_i915_private *dev_priv)
 	drm_dbg_kms(&dev_priv->drm, "Sanitized enable_fbc value: %d\n",
 		    i915_modparams.enable_fbc);
 
+	if (i915_modparams.enable_psr) {
+               i915_modparams.enable_fbc = 0;
+                DRM_DEBUG_KMS("PSR enabled. FBC no longer needed.  Disable FBC. \n");
+	}
+
+
 	if (!HAS_FBC(dev_priv)) {
 		fbc->no_fbc_reason = "unsupported by this chipset";
 		return;
drivers/gpu/drm/i915/display/intel_psr.c +0 -0
index b7a2c102648a..25accfdd5ad3 100644
@@ -1439,8 +1439,10 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
 	if (!HAS_PSR(dev_priv))

drivers/gpu/drm/i915/display/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1448

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_psr.c +3 -1
 		return;
 
-	if (!dev_priv->psr.sink_support)
+	if (!dev_priv->psr.sink_support) {
+		i915_modparams.enable_psr = 0;
 		return;
+	}
 
 	if (IS_HASWELL(dev_priv))
 		/*

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

I had a meeting with an Intel Display Architect. The expected behavior for the driver is PSR2-SU enabling should disable FBC. I will update the patch to limit fbc disabling for PSR2-SU only, not PSR1. Please look at the HSD below for expected driver implementation.
https://hsdes.intel.com/appstore/article/#/14010265390
Thanks,
Jason

-----Original Message-----
From: Souza, Jose <[email protected]>
Sent: Monday, June 08, 2020 9:52 AM
To: Le, Jason V <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Avoid PSR and FBC features concurently.

Quoted 10 lines · Jason Le

Issue: Enble both PSR and FBC caused some fickers on some eDP panels (eg. Panel GIS 13.5" QHD Glare NE135FBM-N41/NC135GFL02). Disbling either PSR or FBC will solve this flicker issue.

Both PSR and FBC features save power when render is not busy. When PSR is active, saving power achieved by source turning off source transmitter and main link, putting memory on self-refresh mode. Therefore with PSR enabled, FBC role is minimized since PSR power saving already covers most what FBC does. Disabling FBC in case to avoid conflict between PSR and FBC which causes display anomaly in some scenarios.

The combination of both saves even more power so no to this, we should fix the issue not disable features because of a single panel having issues.

A PSR2 fix was merged yesterday "drm/i915/psr: Program default IO buffer Wake and Fast Wake" try with that, if just that don't fix try set psr_safest_params=1. If this do not helps, please file a bug, add debug information and then we proceed from that.

Quoted 34 lines

Tests:
Booted system with PSR enabled, verified FBC disabled. Disabled PSR with disabled (i915.enable_psr=0), verified FBC enabled.

---
 drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++++++  
drivers/gpu/drm/i915/display/intel_psr.c | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_fbc.c +6 -0
index 1c26673acb2d..52bc7483adb5 100644
@@ -1419,6 +1419,12 @@ void intel_fbc_init(struct drm_i915_private *dev_priv)
 	drm_dbg_kms(&dev_priv->drm, "Sanitized enable_fbc value: %d\n",
 		    i915_modparams.enable_fbc);
 
+	if (i915_modparams.enable_psr) {
+               i915_modparams.enable_fbc = 0;
+                DRM_DEBUG_KMS("PSR enabled. FBC no longer needed.  Disable FBC. \n");
+	}
+
+
 	if (!HAS_FBC(dev_priv)) {
 		fbc->no_fbc_reason = "unsupported by this chipset";
 		return;
drivers/gpu/drm/i915/display/intel_psr.c +0 -0
index b7a2c102648a..25accfdd5ad3 100644
@@ -1439,8 +1439,10 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
 	if (!HAS_PSR(dev_priv))

drivers/gpu/drm/i915/display/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1448

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_psr.c +3 -1
 		return;
 
-	if (!dev_priv->psr.sink_support)
+	if (!dev_priv->psr.sink_support) {
+		i915_modparams.enable_psr = 0;
 		return;
+	}
 
 	if (IS_HASWELL(dev_priv))
 		/*

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx