Skip to contentSkip to conversation

vhost/test: fix up after API change

PATCH In review Michael S. Tsirkin 2 participants 3 messages Jun 8, 2020 – Jun 9, 2020

Subsystems (5)
lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 vhost/test: fix up after API change

Pass a flag to request kernel thread use.

Fixes 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker")
---
 drivers/vhost/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/test.c +1 -1
index f55cb584b84a..12304eb8da15 100644
@@ -122,7 +122,7 @@ static int vhost_test_open(struct inode *inode, struct file *f)
 	vqs[VHOST_TEST_VQ] = &n->vqs[VHOST_TEST_VQ];
 	n->vqs[VHOST_TEST_VQ].handle_kick = handle_vq_kick;
 	vhost_dev_init(dev, vqs, VHOST_TEST_VQ_MAX, UIO_MAXIOV + 64,
-		       VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, NULL);
+		       VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, true, NULL);
 
 	f->private_data = n;
 
Signature · 1 line
MST
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Michael S. Tsirkin

Pass a flag to request kernel thread use.

Fixes 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker")
---
  drivers/vhost/test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/test.c +0 -0
index f55cb584b84a..12304eb8da15 100644

drivers/vhost/test.c static int vhost_test_open(struct inode *inode, struct file *f) · line 128

Quoted 8 lines
drivers/vhost/test.c +1 -1
@@ -122,7 +122,7 @@ static int vhost_test_open(struct inode *inode, struct file *f)
  	vqs[VHOST_TEST_VQ] = &n->vqs[VHOST_TEST_VQ];
  	n->vqs[VHOST_TEST_VQ].handle_kick = handle_vq_kick;
  	vhost_dev_init(dev, vqs, VHOST_TEST_VQ_MAX, UIO_MAXIOV + 64,
-		       VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, NULL);
+		       VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, true, NULL);
 
  	f->private_data = n;
 

Just to confirm, have you queued the doorbell mapping patches already? Or you expect I squash this into v2 of doorbell mapping series?

Thanks

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#2 lore raw
Quoted 26 lines · Jason Wang
Quoted 13 lines · Michael S. Tsirkin

Pass a flag to request kernel thread use.

Fixes 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker")

---
  drivers/vhost/test.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/test.c +0 -0
index f55cb584b84a..12304eb8da15 100644

drivers/vhost/test.c static int vhost_test_open(struct inode *inode, · line 127

Quoted 7 lines
drivers/vhost/test.c +1 -1
@@ -122,7 +122,7 @@ static int vhost_test_open(struct inode *inode, 
 struct file *f)
       vqs[VHOST_TEST_VQ] = &n->vqs[VHOST_TEST_VQ];
       n->vqs[VHOST_TEST_VQ].handle_kick = handle_vq_kick;
       vhost_dev_init(dev, vqs, VHOST_TEST_VQ_MAX, UIO_MAXIOV + 64,
-               VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, NULL);
+               VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, true, NULL);
         f->private_data = n;
Quoted 1 line

Just to confirm, have you queued the doorbell mapping patches already? Or you expect I squash this into v2 of doorbell mapping series?

Ok, I saw the patches in your linux-next branch.

Thanks

Quoted 3 lines

Thanks