imx8mp_evk: spl: drop useless code
Fabio Estevam
reviewerPATCH v3 1/5 imx8mp_evk: spl: drop useless code
From: Peng Fan <[email protected]>
Drop useless getting ccm device, there is no need to explicted do this in board code, and we not enable SPL CLK currently.
---
Changes since v2:
- None. Rebased against U-Boot master
board/freescale/imx8mp_evk/spl.c | 14 -------------- 1 file changed, 14 deletions(-)
board/freescale/imx8mp_evk/spl.c +0 -14
@@ -29,11 +29,6 @@#include <mmc.h> #include <asm/arch/ddr.h> -#include <dm/uclass.h> -#include <dm/device.h> -#include <dm/uclass-internal.h> -#include <dm/device-internal.h> -DECLARE_GLOBAL_DATA_PTR ;int spl_board_boot_device (enum boot_device boot_dev_spl)
@@ -48,16 +43,7 @@ void spl_dram_init(void)void spl_board_init (void ) { -struct udevice *dev; -int ret; -puts ("Normal Boot\n" ); - - ret =uclass_get_device_by_name (UCLASS_CLK , -"clock-controller at 30380000" , - &dev); -if (ret <0 ) -printf ("Failed to find clock node. Check device tree\n" ); }#define I2C_PAD_CTRL (PAD_CTL_DSE6 | PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PE)
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH v3 1/5 imx8mp_evk: spl: drop useless code
Hi Stefano,
Quoted 8 lines · Fabio Estevam
From: Peng Fan <[email protected]>
Drop useless getting ccm device, there is no need to explicted do this in board code, and we not enable SPL CLK currently.
Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Please consider this series for 2020.07 as it fixes the boot problem.
Thanks
PATCH v3 1/5 imx8mp_evk: spl: drop useless code
Quoted 6 lines · Fabio Estevam
Hi Stefano,
Quoted 3 lines · Fabio Estevam
From: Peng Fan <[email protected]>
Quoted 8 lines
Quoted 5 lines
Drop useless getting ccm device, there is no need to explicted do this in board code, and we not enable SPL CLK currently.
Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>Please consider this series for 2020.07 as it fixes the boot problem.
Ok, thanks - I will go on through patches to check what should be pushed to Tom.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH v3 2/5 imx8mp_evk: spl: drop timer_init
In reply to Fabio EstevamFrom: Peng Fan <[email protected]>
timer_init has been invoked in arch_cpu_init, no need to invoke it again in board code.
---
Changes since v2:
- None. Rebased against U-Boot master
board/freescale/imx8mp_evk/spl.c | 2 -- 1 file changed, 2 deletions(-)
board/freescale/imx8mp_evk/spl.c +0 -2
@@ -118,8 +118,6 @@ void board_init_f(ulong dummy)board_early_init_f (); -timer_init (); -preloader_console_init ();/* Clear the BSS. */
Signature · 1 line
2.17.1
PATCH v3 2/5 imx8mp_evk: spl: drop timer_init
Quoted 5 lines
From: Peng Fan <[email protected]>
timer_inithas been invoked inarch_cpu_init, no need to invoke it again in board code.Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH v3 3/5 imx8mp_evk: spl: use spl_early_init
In reply to Fabio EstevamFrom: Peng Fan <[email protected]>
Use spl_early_init to replace spl_init, spl_init will be invoked in board_init_r, we only need use spl_early_init to setup malloc and scan early dt.
---
Changes since v2:
- None. Rebased against U-Boot master
board/freescale/imx8mp_evk/spl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
board/freescale/imx8mp_evk/spl.c +6 -6
@@ -118,17 +118,17 @@ void board_init_f(ulong dummy)board_early_init_f (); -preloader_console_init (); - -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); - - ret =spl_init (); + ret =spl_early_init ();if (ret) {debug ("spl_init() failed: %d\n" , ret);hang (); } +preloader_console_init (); + +/* Clear the BSS. */ +memset (__bss_start,0 , __bss_end - __bss_start); +enable_tzc380 ();setup_i2c (0 ,CONFIG_SYS_I2C_SPEED ,0x7f , &i2c_pad_info1);
Signature · 1 line
2.17.1
PATCH v3 3/5 imx8mp_evk: spl: use spl_early_init
Quoted 6 lines
From: Peng Fan <[email protected]>
Usespl_early_initto replacespl_init,spl_initwill be invoked inboard_init_r, we only need usespl_early_initto setup malloc and scan early dt.Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH v3 4/5 imx8mp_evk: spl: no need the code since spl framework could do that
In reply to Fabio EstevamFrom: Peng Fan <[email protected]>
We no need invoke the code, since spl framework could help us do that.
---
Changes since v2:
- None. Rebased against U-Boot master
board/freescale/imx8mp_evk/spl.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
board/freescale/imx8mp_evk/spl.c +1 -5
@@ -108,6 +108,7 @@ int board_fit_config_name_match(const char *name) }#endif +/* Do not use BSS area in this phase */ void board_init_f (ulong dummy) {int ret;
@@ -126,9 +127,6 @@ void board_init_f(ulong dummy)preloader_console_init (); -/* Clear the BSS. */ -memset (__bss_start,0 , __bss_end - __bss_start); -enable_tzc380 ();setup_i2c (0 ,CONFIG_SYS_I2C_SPEED ,0x7f , &i2c_pad_info1);
@@ -137,6 +135,4 @@ void board_init_f(ulong dummy)/* DDR initialization */ spl_dram_init (); - -board_init_r (NULL ,0 ); }
Signature · 1 line
2.17.1
PATCH v3 4/5 imx8mp_evk: spl: no need the code since spl framework could do that
Quoted 5 lines
From: Peng Fan <[email protected]>
We no need invoke the code, since spl framework could help us do that.Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH v3 5/5 imx: imx8mp_evk: fix boot issue
In reply to Fabio EstevamFrom: Peng Fan <[email protected]>
The u-boot-spl.bin pad with ddr firmware conflicts with the CONFIG_MALLOC_F_ADDR area, the ddr firmware will be overwritten by malloc in SPL stage and cause ddr initialization not able to finish. So update the related addresses to fix the issue.
---
Changes since v2:
- None. Rebased against U-Boot master
configs/imx8mp_evk_defconfig | 3 ++- include/configs/imx8mp_evk.h | 12 +++++------- 2 files changed, 7 insertions(+), 8 deletions(-)
configs/imx8mp_evk_defconfig +2 -1
@@ -4,7 +4,8 @@ CONFIG_SYS_TEXT_BASE=0x40200000 CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y -CONFIG_SYS_MALLOC_F_LEN=0x10000 +CONFIG_SYS_MALLOC_F_LEN=0x8000 +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_ENV_SIZE=0x1000 CONFIG_ENV_OFFSET=0x400000 CONFIG_SYS_I2C_MXC_I2C1=y
include/configs/imx8mp_evk.h +5 -7
@@ -24,16 +24,14 @@#ifdef CONFIG_SPL_BUILD /*#define CONFIG_ENABLE_DDR_TRAINING_DEBUG*/ #define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv8/u-boot-spl.lds" -#define CONFIG_SPL_STACK 0x990000 -#define CONFIG_SPL_BSS_START_ADDR 0x0095e000 -#define CONFIG_SPL_BSS_MAX_SIZE 0x2000/* 8 KB */ -#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 -#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K/* 512 KB */ +#define CONFIG_SPL_STACK 0x960000 +#define CONFIG_SPL_BSS_START_ADDR 0x0098FC00 +#define CONFIG_SPL_BSS_MAX_SIZE 0x400/* 1 KB */ +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K/* 512 KB */ #define CONFIG_SYS_ICACHE_OFF #define CONFIG_SYS_DCACHE_OFF -#define CONFIG_MALLOC_F_ADDR 0x940000 -#define CONFIG_SPL_ABORT_ON_RAW_IMAGE #undef CONFIG_DM_MMC
Signature · 1 line
2.17.1
PATCH v3 5/5 imx: imx8mp_evk: fix boot issue
Quoted 8 lines
From: Peng Fan <[email protected]>
The u-boot-spl.bin pad with ddr firmware conflicts with theCONFIG_MALLOC_F_ADDRarea, the ddr firmware will be overwritten by malloc in SPL stage and cause ddr initialization not able to finish. So update the related addresses to fix the issue.Reported-by Fabio Estevam <[email protected]>Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v3 1/5 imx8mp_evk: spl: drop useless code
In reply to Fabio EstevamQuoted 5 lines
From: Peng Fan <[email protected]>
Drop useless getting ccm device, there is no need to explicted do this in board code, and we not enable SPL CLK currently.Signed-off-by Peng Fan <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================