nios2: signal: Mark expected switch fall-through
PATCH 1/1 nios2: signal: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
Fix the following warning through the use of the new the new pseudo-keyword fallthrough;
arch/nios2/kernel/signal.c:254:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
254 | restart = -2;
| ~~~~~~~~^~~~
arch/nios2/kernel/signal.c:255:3: note: here
255 | case ERESTARTNOHAND:
| ^~~~--- arch/nios2/kernel/signal.c | 1 + 1 file changed, 1 insertion(+)
arch/nios2/kernel/signal.c +1 -0
@@ -252,6 +252,7 @@ static int do_signal(struct pt_regs *regs)switch (retval) {case ERESTART_RESTARTBLOCK : restart =-2 ; + fallthrough;case ERESTARTNOHAND :case ERESTARTSYS :case ERESTARTNOINTR :
Signature · 1 line
2.27.0
Quoted 24 lines
-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: Tuesday, June 9, 2020 1:37 AM
To: Tan, Ley Foon <[email protected]>; Christian Brauner <[email protected]>
Cc: [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH] nios2: signal: Mark expected switch fall-throughMark switch cases where we are expecting to fall through.
Fix the following warning through the use of the new the new pseudo- keyword fallthrough;
arch/nios2/kernel/signal.c:254:12: warning: this statement may fall through [-Wimplicit-fallthrough=]254 | restart = -2; | ~~~~~~~~^~~~ arch/nios2/kernel/signal.c:255:3: note: here 255 | case ERESTARTNOHAND: | ^~~~
Quoted 3 lines
Reported-by Christian Brauner <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>---
Will merge to coming release.
Thanks.
Regards
Ley Foon