packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled
PATCH 1/1 packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in DISTRO_FEATURES:
ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb
--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5 -0
@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0"
Signature · 1 line
2.26.2
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --
Quoted 2 lines
2.26.2
Ping.
Signature · 2 lines
Paul Barker Konsulko Group
Quoted 26 lines · Paul Barker
Quoted 25 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-0@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb
Quoted 6 lines
Quoted 4 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +0
-1PR = "r0" --2.26.2
Ping.
Thanks, I'll merge it shortly.
Signature · 1 line
Denys
Quoted 27 lines · Denys Dmytriyenko
Quoted 26 lines · Paul Barker
Quoted 25 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-0@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +0
-1PR = "r0" --2.26.2
Ping.
Thanks, I'll merge it shortly.
Actually, should this simply use REQUIRED_DISTRO_FEATURES from features_check.bbclass?
Signature · 1 line
Denys
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?
Actually, yes, that should work. We just need to set REQUIRED_DISTRO_FEATURES and inherit features_check before require recipes-core/packagegroups/packagegroup-core-boot.bb as that's where the error is raised.
In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
Thanks,
Signature · 2 lines
Paul Barker Konsulko Group
Quoted 47 lines · Paul Barker
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?Actually, yes, that should work. We just need to set
REQUIRED_DISTRO_FEATURESand inheritfeatures_checkbeforerequire recipes-core/packagegroups/packagegroup-core-boot.bbas that's where the error is raised.
Quoted 4 lines
In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults.
Signature · 1 line
Denys
Quoted 49 lines · Denys Dmytriyenko
Quoted 47 lines · Paul Barker
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?Actually, yes, that should work. We just need to set
REQUIRED_DISTRO_FEATURESand inheritfeatures_checkbeforerequire recipes-core/packagegroups/packagegroup-core-boot.bbas that's where the error is raised.
Quoted 8 lines
Quoted 4 lines
In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults.
That sounds like it should be done by an arago-tiny distro rather than by image/packagegroup recipes. When building this image you've still got systemd in DISTRO_FEATURES and so some applications may be built in a way that requires systemd.
Signature · 2 lines
Paul Barker Konsulko Group
Quoted 55 lines · Paul Barker
Quoted 54 lines · Denys Dmytriyenko
Quoted 51 lines · Paul Barker
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?Actually, yes, that should work. We just need to set
REQUIRED_DISTRO_FEATURESand inheritfeatures_checkbeforerequire recipes-core/packagegroups/packagegroup-core-boot.bbas that's where the error is raised.In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
Quoted 8 lines
Quoted 3 lines
The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults.
That sounds like it should be done by an
arago-tinydistro rather than by image/packagegroup recipes. When building this image you've still got systemd inDISTRO_FEATURESand so some applications may be built in a way that requires systemd.
A new distro is not going to work in this case - tiny image is needed along the side of other systemd images and may be packaged and used inside as initramfs and demo rootfs for Jailhouse or other hypervisors.
Signature · 1 line
Denys
Quoted 60 lines · Denys Dmytriyenko
Quoted 59 lines · Paul Barker
Quoted 57 lines · Denys Dmytriyenko
Quoted 47 lines · Paul Barker
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?Actually, yes, that should work. We just need to set
REQUIRED_DISTRO_FEATURESand inheritfeatures_checkbeforerequire recipes-core/packagegroups/packagegroup-core-boot.bbas that's where the error is raised.Quoted 4 lines
In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults.
Quoted 8 lines
Quoted 4 lines
That sounds like it should be done by an
arago-tinydistro rather than by image/packagegroup recipes. When building this image you've still got systemd inDISTRO_FEATURESand so some applications may be built in a way that requires systemd.A new distro is not going to work in this case - tiny image is needed along the side of other systemd images and may be packaged and used inside as initramfs and demo rootfs for Jailhouse or other hypervisors.
Paul,
Any updates on this? Do you still need it?
Do you have a patch with REQUIRED_DISTRO_FEATURES as discussed above?
Signature · 1 line
Denys
Quoted 67 lines · Denys Dmytriyenko
Quoted 65 lines · Denys Dmytriyenko
Quoted 63 lines · Paul Barker
Quoted 49 lines · Denys Dmytriyenko
Quoted 47 lines · Paul Barker
Quoted 36 lines · Denys Dmytriyenko
Quoted 34 lines · Denys Dmytriyenko
Quoted 32 lines · Paul Barker
Quoted 27 lines · Paul Barker
This change fixes the following error seen at parse time when the meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in
DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bbSigned-off-by Paul Barker <[email protected]>--- .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ 1 file changed, 5 insertions(+)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb +5
-1@@ -1,3 +1,8 @@ +python __anonymous() { + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): + raise bb.parse.SkipRecipe("sysvinit is not enabled") +} + require recipes-core/packagegroups/packagegroup-core-boot.bb PR = "r0" --Quoted 2 lines
2.26.2
Ping.
Quoted 4 lines
Quoted 1 line
Thanks, I'll merge it shortly.
Actually, should this simply use
REQUIRED_DISTRO_FEATURESfrom features_check.bbclass?Actually, yes, that should work. We just need to set
REQUIRED_DISTRO_FEATURESand inheritfeatures_checkbeforerequire recipes-core/packagegroups/packagegroup-core-boot.bbas that's where the error is raised.Quoted 8 lines
Quoted 4 lines
In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment.
The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults.
That sounds like it should be done by an
arago-tinydistro rather than by image/packagegroup recipes. When building this image you've still got systemd inDISTRO_FEATURESand so some applications may be built in a way that requires systemd.
Quoted 8 lines
Quoted 3 lines
A new distro is not going to work in this case - tiny image is needed along the side of other systemd images and may be packaged and used inside as initramfs and demo rootfs for Jailhouse or other hypervisors.
Paul,
Any updates on this? Do you still need it?
Do you have a patch withREQUIRED_DISTRO_FEATURESas discussed above?
Now I've resolved the issues with my other patch I'm confident this change is good. I'll resubmit the patch using REQUIRED_DISTRO_FEATURES.
Thanks,
Signature · 2 lines
Paul Barker Konsulko Group