Skip to contentSkip to conversation

kdd: remove zero-length arrays

PATCH In review Olaf Hering 7 participants 18 messages Jun 8, 2020 – Jun 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kdd: remove zero-length arrays

Struct 'kdd_hdr' already has a member named 'payload[]' to easily refer to the data after the header. Remove the payload member from 'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error:

kdd.c: In function 'kdd_tx':
kdd.c:746:30: error: array subscript 65534 is outside the bounds of an interior zero-length array 'uint8_t[0]' {aka 'unsigned char[]'} [-Werror=zero-length-bounds]

  746 |         sum += s->txp.payload[i];
      |                ~~~~~~~~~~~~~~^~~
In file included from kdd.c:53:
kdd.h:326:17: note: while referencing 'payload'
  326 |         uint8_t payload[0];
      |                 ^~~~~~~

cc1: all warnings being treated as errors

---
 tools/debugger/kdd/kdd.c | 10 +++++-----
 tools/debugger/kdd/kdd.h |  3 +--
 2 files changed, 6 insertions(+), 7 deletions(-)
tools/debugger/kdd/kdd.c +5 -5
index 3ebda9b12c..4c6b39c22b 100644
@@ -249,7 +249,7 @@ static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p)
 
     /* Re-check the checksum */
     for (i = 0; i < p->h.len; i++)
-        sum += p->payload[i];
+        sum += p->h.payload[i];
 
     fprintf(f, "\n"
             "%s: %s type 0x%4.4"PRIx16" len 0x%4.4"PRIx16
@@ -267,8 +267,8 @@ static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p)
             fprintf(f, "%8.8x ", i);
         } else if (i % 8 == 0)
             fprintf(f, " ");
-        fprintf(f, " %2.2x", p->payload[i]);
-        ascii[i % 16] = (isprint(((int)p->payload[i])) ? p->payload[i] : 0x2e);
+        fprintf(f, " %2.2x", p->h.payload[i]);
+        ascii[i % 16] = (isprint(((int)p->h.payload[i])) ? p->h.payload[i] : 0x2e);
         if (i % 16 == 15)
             fprintf(f, "  |%s|\n", ascii);
     }
@@ -743,7 +743,7 @@ static void kdd_tx(kdd_state *s)
 
     /* Fix up the checksum before we send */
     for (i = 0; i < s->txp.h.len; i++)
-        sum += s->txp.payload[i];
+        sum += s->txp.h.payload[i];
     s->txp.h.sum = sum;
 
     kdd_log_pkt(s, "TX", &s->txp);
@@ -1127,7 +1127,7 @@ static void kdd_handle_pkt(kdd_state *s, kdd_pkt *p)
 
     /* Simple checksum: add all the bytes */
     for (i = 0; i < p->h.len; i++)
-        sum += p->payload[i];
+        sum += p->h.payload[i];
     if (p->h.sum != sum) {
         kdd_send_ack(s, p->h.id, KDD_ACK_BAD);
         return;
tools/debugger/kdd/kdd.h +1 -2
index bfb00ba5c5..57525d36c6 100644
@@ -68,7 +68,7 @@ typedef struct {
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
+    uint8_t payload[];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +323,6 @@ typedef struct {
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
     };
 } PACKED kdd_pkt;
 
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Xen-devel <[email protected]> On Behalf Of Olaf Hering
Sent: 08 June 2020 21:39
To: [email protected]
Cc: Ian Jackson <[email protected]>; Olaf Hering <[email protected]>; Tim Deegan <[email protected]>; Wei Liu <[email protected]>
Subject: [PATCH v1] kdd: remove zero-length arrays

Struct 'kdd_hdr' already has a member named 'payload[]' to easily refer to the data after the header. Remove the payload member from 'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error:

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []? In fact I can't see any use of the payload field in kdd_hdr so it looks like that is the one that ought to be dropped.

Paul

Quoted 81 lines

kdd.c: In function 'kdd_tx':
kdd.c:746:30: error: array subscript 65534 is outside the bounds of an interior zero-length array 'uint8_t[0]' {aka 'unsigned char[]'} [-Werror=zero-length-bounds]

  746 |         sum += s->txp.payload[i];
      |                ~~~~~~~~~~~~~~^~~
In file included from kdd.c:53:
kdd.h:326:17: note: while referencing 'payload'
  326 |         uint8_t payload[0];
      |                 ^~~~~~~

cc1: all warnings being treated as errors

---
 tools/debugger/kdd/kdd.c | 10 +++++-----
 tools/debugger/kdd/kdd.h |  3 +--
 2 files changed, 6 insertions(+), 7 deletions(-)
tools/debugger/kdd/kdd.c +5 -5
index 3ebda9b12c..4c6b39c22b 100644
@@ -249,7 +249,7 @@ static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p)
 
     /* Re-check the checksum */
     for (i = 0; i < p->h.len; i++)
-        sum += p->payload[i];
+        sum += p->h.payload[i];
 
     fprintf(f, "\n"
             "%s: %s type 0x%4.4"PRIx16" len 0x%4.4"PRIx16
@@ -267,8 +267,8 @@ static void kdd_log_pkt(kdd_state *s, char *name, kdd_pkt *p)
             fprintf(f, "%8.8x ", i);
         } else if (i % 8 == 0)
             fprintf(f, " ");
-        fprintf(f, " %2.2x", p->payload[i]);
-        ascii[i % 16] = (isprint(((int)p->payload[i])) ? p->payload[i] : 0x2e);
+        fprintf(f, " %2.2x", p->h.payload[i]);
+        ascii[i % 16] = (isprint(((int)p->h.payload[i])) ? p->h.payload[i] : 0x2e);
         if (i % 16 == 15)
             fprintf(f, "  |%s|\n", ascii);
     }
@@ -743,7 +743,7 @@ static void kdd_tx(kdd_state *s)
 
     /* Fix up the checksum before we send */
     for (i = 0; i < s->txp.h.len; i++)
-        sum += s->txp.payload[i];
+        sum += s->txp.h.payload[i];
     s->txp.h.sum = sum;
 
     kdd_log_pkt(s, "TX", &s->txp);
@@ -1127,7 +1127,7 @@ static void kdd_handle_pkt(kdd_state *s, kdd_pkt *p)
 
     /* Simple checksum: add all the bytes */
     for (i = 0; i < p->h.len; i++)
-        sum += p->payload[i];
+        sum += p->h.payload[i];
     if (p->h.sum != sum) {
         kdd_send_ack(s, p->h.id, KDD_ACK_BAD);
         return;
tools/debugger/kdd/kdd.h +1 -2
index bfb00ba5c5..57525d36c6 100644
@@ -68,7 +68,7 @@ typedef struct {
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
+    uint8_t payload[];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +323,6 @@ typedef struct {
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
     };
 } PACKED kdd_pkt;
 
#2 lore raw

Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant <[email protected]>:

Quoted 1 line

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []?

AFAIR this lead to compile errors.

Olaf

#3 lore raw
Quoted 8 lines

-----Original Message-----
From: Olaf Hering <[email protected]>
Sent: 09 June 2020 10:00
To: Paul Durrant <[email protected]>
Cc: [email protected]; [email protected]; 'Ian Jackson' <[email protected]>; 'Tim Deegan' <[email protected]>; 'Wei Liu' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 7 lines

Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant <[email protected]>:

Quoted 1 line

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []?

AFAIR this lead to compile errors.

OOI which compiler (might be worth mentioning in the commit comment too, for reference)? I'm not seeing a problem.

Paul

Quoted 1 line

Olaf

#4 lore raw
Quoted 11 lines · Paul Durrant
Quoted 11 lines

-----Original Message-----
From: Olaf Hering <[email protected]>
Sent: 09 June 2020 10:00
To: Paul Durrant <[email protected]>
Cc: [email protected]; [email protected]; 'Ian Jackson' <[email protected]>; 'Tim Deegan' <[email protected]>; 'Wei Liu' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant <[email protected]>:

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []?

AFAIR this lead to compile errors.

OOI which compiler (might be worth mentioning in the commit comment too, for reference)? I'm not seeing a problem.

We don't use array[] in public headers, but AFAIK using them internally is fine.

Juergen

#5 lore raw
Quoted 22 lines

-----Original Message-----
From: Jürgen Groß <[email protected]>
Sent: 09 June 2020 10:06
To: [email protected]; 'Olaf Hering' <[email protected]>; 'Paul Durrant' <[email protected]>
Cc: [email protected]; 'Ian Jackson' <[email protected]>; 'Wei Liu' <[email protected]>; 'Tim Deegan' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 13 lines · Paul Durrant
Quoted 13 lines

-----Original Message-----
From: Olaf Hering <[email protected]>
Sent: 09 June 2020 10:00
To: Paul Durrant <[email protected]>
Cc: [email protected]; [email protected]; 'Ian Jackson' <[email protected]>; 'Tim Deegan' <[email protected]>; 'Wei Liu' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant <[email protected]>:

Quoted 1 line

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []?

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

AFAIR this lead to compile errors.

OOI which compiler (might be worth mentioning in the commit comment too, for reference)? I'm not

seeing a problem.

We don't use array[] in public headers, but AFAIK using them internally is fine.

Yeah, we have XEN_FLEX_ARRAY_DIM for public headers.

Paul

Quoted 2 lines

Juergen

#6 lore raw
In reply to Paul Durrant

Am Tue, 9 Jun 2020 10:04:30 +0100
schrieb Paul Durrant <[email protected]>:

Quoted 1 line

OOI which compiler (might be worth mentioning in the commit comment too, for reference)? I'm not seeing a problem.

This is from gcc10. I think the build automation for Tumbleweed will show this error, unless the Tumbleweed image is older than a week.

Olaf

#7 lore raw
In reply to Paul Durrant

Hi,

Quoted 8 lines · Paul Durrant
Quoted 8 lines

-----Original Message-----
From: Xen-devel <[email protected]> On Behalf Of Olaf Hering
Sent: 08 June 2020 21:39
To: [email protected]
Cc: Ian Jackson <[email protected]>; Olaf Hering <[email protected]>; Tim Deegan <[email protected]>; Wei Liu <[email protected]>
Subject: [PATCH v1] kdd: remove zero-length arrays

Quoted 6 lines
Quoted 3 lines

Struct 'kdd_hdr' already has a member named 'payload[]' to easily refer to the data after the header. Remove the payload member from 'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error:

Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []? In fact I can't see any use of the payload field in kdd_hdr so it looks like that is the one that ought to be dropped.

Yes, if one of these has to go, it should be the one in the header, since it's not used and the one in the packet is neatly in the union with the other decriptions of the packet payload.

I'm not currently in a position to test patches, but might be later in the week. Olaf, can you try dropping the 'payload' field from the header and replacing the payload[0] in pkt with payload[] ?

Cheers,

Tim.

#8 lore raw

Am Tue, 9 Jun 2020 13:15:49 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

Olaf, can you try dropping the 'payload' field from the header and replacing the payload[0] in pkt with payload[] ?

In file included from kdd.c:53:
kdd.h:325:17: error: flexible array member in union
325 | uint8_t payload[];

kdd.h 2020-06-09 13:20:36.724887538 +0000 renamed from kdd.h 2020-06-08 17:40:05.000000000 +0000 +1 -2
@@ -68,7 +68,6 @@
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +322,7 @@
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
+        uint8_t payload[];
     };
 } PACKED kdd_pkt;
 

Olaf

#9 lore raw

Olaf Hering writes ("Re: [PATCH v1] kdd: remove zero-length arrays"):

Quoted 8 lines

Am Tue, 9 Jun 2020 13:15:49 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

Olaf, can you try dropping the 'payload' field from the header and replacing the payload[0] in pkt with payload[] ?

In file included from kdd.c:53:
kdd.h:325:17: error: flexible array member in union
325 | uint8_t payload[];

...

kdd.h 2020-06-09 13:20:36.724887538 +0000 line 327

Quoted 5 lines
         kdd_stc stc;
kdd.h 2020-06-09 13:20:36.724887538 +0000 renamed from kdd.h 2020-06-08 17:40:05.000000000 +0000 +1 -1
-        uint8_t payload[0];
+        uint8_t payload[];
     };
 } PACKED kdd_pkt;

Try

Quoted 3 lines
         kdd_stc stc;
-        uint8_t payload[0];
     };

+ uint8_t payload[];

Quoted 1 line

} PACKED kdd_pkt;

?

(I haven't read the surrounding code...)

Ian.

#10 lore raw

Am Tue, 9 Jun 2020 14:26:46 +0100
schrieb Ian Jackson <[email protected]>:

Quoted 1 line

+ uint8_t payload[];

This compiles, but will access memory behind the union{};, which is most likely not what the intention is.

Olaf

#11 lore raw
In reply to Olaf Hering
Quoted 8 lines · Olaf Hering

Am Tue, 9 Jun 2020 13:15:49 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

Olaf, can you try dropping the 'payload' field from the header and replacing the payload[0] in pkt with payload[] ?

In file included from kdd.c:53:
kdd.h:325:17: error: flexible array member in union
325 | uint8_t payload[];

How tedious. Well, the only place we actually allocate one of these we already leave enough space for a max-size packet, so how about this?

kdd: stop using [0] arrays to access packet contents.

GCC 10 is unhappy about this, and we already use 64k buffers in the only places where packets are allocated, so move the 64k size into the packet definition.

---
 tools/debugger/kdd/kdd.c | 4 ++--
 tools/debugger/kdd/kdd.h | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
debugger/kdd/kdd.c +2 -2
index 3ebda9b12c..a7d0976ea4 100644
@@ -79,11 +79,11 @@ typedef struct {
 /* State of the debugger stub */
 typedef struct {
     union {
-        uint8_t txb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for tx */
+        uint8_t txb[sizeof (kdd_pkt)];           /* Marshalling area for tx */
         kdd_pkt txp;                 /* Also readable as a packet structure */
     };
     union {
-        uint8_t rxb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for rx */
+        uint8_t rxb[sizeof (kdd_pkt)];           /* Marshalling area for rx */
         kdd_pkt rxp;                 /* Also readable as a packet structure */
     };
     unsigned int cur;       /* Offset into rx where we'll put the next byte */
debugger/kdd/kdd.h +1 -2
index bfb00ba5c5..b9a17440df 100644
@@ -68,7 +68,6 @@ typedef struct {
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +322,7 @@ typedef struct {
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
+        uint8_t payload[65536];
     };
 } PACKED kdd_pkt;
 
Signature · 1 line
2.26.2
#12 lore raw

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

How tedious.

Indeed. This compiles for me as well:

kdd.h 2020-06-11 19:00:44.234364040 +0000 renamed from kdd.h 2020-06-08 17:40:05.000000000 +0000 +1 -2
@@ -68,7 +68,6 @@
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +322,7 @@
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
+        uint8_t payload[65536];
     };
 } PACKED kdd_pkt;
 
kdd.c 2020-06-11 19:08:36.775724640 +0000 renamed from kdd.c 2020-06-08 17:40:05.000000000 +0000 +2 -2
@@ -79,11 +79,11 @@
 /* State of the debugger stub */
 typedef struct {
     union {
-        uint8_t txb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for tx */
+        uint8_t txb[sizeof (kdd_hdr) + 0xffff];   /* Marshalling area for tx */
         kdd_pkt txp;                 /* Also readable as a packet structure */
     };
     union {
-        uint8_t rxb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for rx */
+        uint8_t rxb[sizeof (kdd_hdr)];   /* Marshalling area for rx */
         kdd_pkt rxp;                 /* Also readable as a packet structure */
     };
     unsigned int cur;       /* Offset into rx where we'll put the next byte */

Olaf

#13 lore raw
Quoted 7 lines · Olaf Hering

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

How tedious.

Indeed. This compiles for me as well:

just a nudge on this; it would be nice to get a patch into the tree since the build failure affects master builds of Xen in OpenEmbedded now.

Christopher

Quoted 38 lines
kdd.h 2020-06-11 19:00:44.234364040 +0000 renamed from kdd.h 2020-06-08 17:40:05.000000000 +0000 +1 -2
@@ -68,7 +68,6 @@
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +322,7 @@
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
+        uint8_t payload[65536];
     };
 } PACKED kdd_pkt;
 
kdd.c 2020-06-11 19:08:36.775724640 +0000 renamed from kdd.c 2020-06-08 17:40:05.000000000 +0000 +2 -2
@@ -79,11 +79,11 @@
 /* State of the debugger stub */
 typedef struct {
     union {
-        uint8_t txb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for tx */
+        uint8_t txb[sizeof (kdd_hdr) + 0xffff];   /* Marshalling area for tx */
         kdd_pkt txp;                 /* Also readable as a packet structure */
     };
     union {
-        uint8_t rxb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for rx */
+        uint8_t rxb[sizeof (kdd_hdr)];   /* Marshalling area for rx */
         kdd_pkt rxp;                 /* Also readable as a packet structure */
     };
     unsigned int cur;       /* Offset into rx where we'll put the next byte */

Olaf

#14 lore raw
Quoted 13 lines

-----Original Message-----
From: Christopher Clark <[email protected]>
Sent: 16 June 2020 21:50
To: Olaf Hering <[email protected]>
Cc: Tim Deegan <[email protected]>; xen-devel <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>; [email protected]
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 4 lines · Olaf Hering

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

How tedious.

Indeed. This compiles for me as well:

just a nudge on this; it would be nice to get a patch into the tree since the build failure affects master builds of Xen in OpenEmbedded now.

I'd be happy to take a patch into 4.14 if someone can provide one with a suitable maintainer ack.

Paul

Quoted 40 lines

Christopher

Quoted 38 lines
kdd.h 2020-06-11 19:00:44.234364040 +0000 renamed from kdd.h 2020-06-08 17:40:05.000000000 +0000 +1 -2
@@ -68,7 +68,6 @@
     uint16_t len;     /* Payload length, excl. header and trailing byte */
     uint32_t id;      /* Echoed in responses */
     uint32_t sum;     /* Unsigned sum of all payload bytes */
-    uint8_t payload[0];
 } PACKED kdd_hdr;
 
 #define KDD_PKT_CMD 0x0002      /* Debugger commands (and replies to them) */
@@ -323,7 +322,7 @@
         kdd_msg msg;
         kdd_reg reg;
         kdd_stc stc;
-        uint8_t payload[0];
+        uint8_t payload[65536];
     };
 } PACKED kdd_pkt;
 
kdd.c 2020-06-11 19:08:36.775724640 +0000 renamed from kdd.c 2020-06-08 17:40:05.000000000 +0000 +2 -2
@@ -79,11 +79,11 @@
 /* State of the debugger stub */
 typedef struct {
     union {
-        uint8_t txb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for tx */
+        uint8_t txb[sizeof (kdd_hdr) + 0xffff];   /* Marshalling area for tx */
         kdd_pkt txp;                 /* Also readable as a packet structure */
     };
     union {
-        uint8_t rxb[sizeof (kdd_hdr) + 65536];   /* Marshalling area for rx */
+        uint8_t rxb[sizeof (kdd_hdr)];   /* Marshalling area for rx */
         kdd_pkt rxp;                 /* Also readable as a packet structure */
     };
     unsigned int cur;       /* Offset into rx where we'll put the next byte */

Olaf

#15 lore raw
Quoted 15 lines · Paul Durrant
Quoted 15 lines

-----Original Message-----
From: Christopher Clark <[email protected]>
Sent: 16 June 2020 21:50
To: Olaf Hering <[email protected]>
Cc: Tim Deegan <[email protected]>; xen-devel <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>; [email protected]
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 6 lines · Olaf Hering

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

How tedious.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Indeed. This compiles for me as well:

just a nudge on this; it would be nice to get a patch into the tree since the build failure affects master builds of Xen in OpenEmbedded now.

I'd be happy to take a patch into 4.14 if someone can provide one with a suitable maintainer ack.

Tim is the maintainer of KDD. :-)

I take it you're happy with me committing his patch then?

Wei.

#16 lore raw
Quoted 32 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 26 June 2020 11:27
To: [email protected]
Cc: 'Christopher Clark' <[email protected]>; 'Olaf Hering' <[email protected]>; 'Tim Deegan' <[email protected]>; 'xen-devel' <[email protected]>; 'Ian Jackson' <[email protected]>; 'Wei Liu' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 22 lines · Paul Durrant
Quoted 21 lines

-----Original Message-----
From: Christopher Clark <[email protected]>
Sent: 16 June 2020 21:50
To: Olaf Hering <[email protected]>
Cc: Tim Deegan <[email protected]>; xen-devel <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>; [email protected]
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 7 lines · Olaf Hering

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

How tedious.

Indeed. This compiles for me as well:

just a nudge on this; it would be nice to get a patch into the tree since the build failure affects master builds of Xen in OpenEmbedded now.

Quoted 6 lines
Quoted 1 line

I'd be happy to take a patch into 4.14 if someone can provide one with a suitable maintainer ack.

Tim is the maintainer of KDD. :-)

I take it you're happy with me committing his patch then?

I'm happy, but ought it not have an ack from 'the rest' since Tim submitted the patch?

Quoted 1 line

Wei.

Acked-by
#17 lore raw
Quoted 32 lines · Paul Durrant
Quoted 32 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 26 June 2020 11:27
To: [email protected]
Cc: 'Christopher Clark' <[email protected]>; 'Olaf Hering' <[email protected]>; 'Tim Deegan' <[email protected]>; 'xen-devel' <[email protected]>; 'Ian Jackson' <[email protected]>; 'Wei Liu' <[email protected]>
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 22 lines · Paul Durrant
Quoted 21 lines

-----Original Message-----
From: Christopher Clark <[email protected]>
Sent: 16 June 2020 21:50
To: Olaf Hering <[email protected]>
Cc: Tim Deegan <[email protected]>; xen-devel <[email protected]>; Ian Jackson <[email protected]>; Wei Liu <[email protected]>; [email protected]
Subject: Re: [PATCH v1] kdd: remove zero-length arrays

Quoted 7 lines · Olaf Hering

Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan <[email protected]>:

Quoted 1 line

How tedious.

Indeed. This compiles for me as well:

just a nudge on this; it would be nice to get a patch into the tree since the build failure affects master builds of Xen in OpenEmbedded now.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I'd be happy to take a patch into 4.14 if someone can provide one with a suitable maintainer ack.

Tim is the maintainer of KDD. :-)

I take it you're happy with me committing his patch then?

I'm happy, but ought it not have an ack from 'the rest' since Tim submitted the patch?

Alright. FWIW:

Quoted 2 lines

Thanks.

Wei.

Quoted 3 lines
Quoted 2 lines

Wei.