scsi: ufs: Fix imprecise time in devfreq window
Subsystems (2)
PATCH v2 1/1 scsi: ufs: Fix imprecise time in devfreq window
Promise precision of devfreq windows by
1. Align time base of both devfreq_dev_status.total_time and devfreq_dev_status.busy_time to ktime-based time.
2. Align below timelines,
- The beginning of devfreq window
- The beginning of busy time in new window
- The end of busy time in current window
--- drivers/scsi/ufs/ufshcd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/scsi/ufs/ufshcd.c +6 -5
@@ -1314,6 +1314,7 @@ static int ufshcd_devfreq_get_dev_status(struct device *dev,unsigned long flags;struct list_head *clk_list = &hba->clk_list_head;struct ufs_clk_info *clki; +ktime_t curr_t;if (!ufshcd_is_clkscaling_supported (hba))return -EINVAL ;
@@ -1321,6 +1322,7 @@ static int ufshcd_devfreq_get_dev_status(struct device *dev,memset (stat,0 ,sizeof (*stat));spin_lock_irqsave (hba->host->host_lock, flags); + curr_t =ktime_get ();if (!scaling->window_start_t) goto start_window;
@@ -1332,18 +1334,17 @@ static int ufshcd_devfreq_get_dev_status(struct device *dev,*/ stat->current_frequency = clki->curr_freq;if (scaling->is_busy_started) - scaling->tot_busy_t +=ktime_to_us (ktime_sub (ktime_get (), + scaling->tot_busy_t +=ktime_to_us (ktime_sub (curr_t, scaling->busy_start_t)); - stat->total_time =jiffies_to_usecs ((long )jiffies - - (long )scaling->window_start_t); + stat->total_time =ktime_to_us (curr_t) - scaling->window_start_t; stat->busy_time = scaling->tot_busy_t; start_window: - scaling->window_start_t = jiffies; + scaling->window_start_t =ktime_to_us (curr_t); scaling->tot_busy_t =0 ;if (hba->outstanding_reqs) { - scaling->busy_start_t =ktime_get (); + scaling->busy_start_t = curr_t; scaling->is_busy_started = true; }else { scaling->busy_start_t =0 ;
Signature · 1 line
2.18.0
Hi Stanley,
Quoted 3 lines
Promise precision of devfreq windows by
Promise -> guarantee / assure / verify that the?
Can you please also elaborate why the current window isn't accurate enough? And add a fixes tag?
Hi Avri,
Quoted 8 lines · Avri Altman
Hi Stanley,
Quoted 3 lines
Promise precision of devfreq windows by
Promise -> guarantee / assure / verify that the?
Can you please also elaborate why the current window isn't accurate enough? And add a fixes tag?
OK! I will fix all of them in next version.
Thanks,
Stanley Chu