Skip to contentSkip to conversation

net: sched: export __netdev_watchdog_up()

PATCH In review Valentin Longchamp 2 participants 2 messages Jun 9, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 net: sched: export __netdev_watchdog_up()

Since the quiesce/activate rework, __netdev_watchdog_up() is directly called in the ucc_geth driver.

Unfortunately, this function is not available for modules and thus ucc_geth cannot be built as a module anymore. Fix it by exporting __netdev_watchdog_up().

Since the commit introducing the regression was backported to stable branches, this one should ideally be as well.

Fixes 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")
---
 net/sched/sch_generic.c | 1 +
 1 file changed, 1 insertion(+)
net/sched/sch_generic.c +1 -0
index b19a0021a0bd..265a61d011df 100644
@@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
 			dev_hold(dev);
 	}
 }
+EXPORT_SYMBOL_GPL(__netdev_watchdog_up);
 
 static void dev_watchdog_up(struct net_device *dev)
 {
Signature · 1 line
2.25.1
maintainer
#1 lore raw

From: Valentin Longchamp <[email protected]>
Date: Tue, 9 Jun 2020 22:11:54 +0200

Quoted 7 lines

Since the quiesce/activate rework, __netdev_watchdog_up() is directly called in the ucc_geth driver.

Unfortunately, this function is not available for modules and thus ucc_geth cannot be built as a module anymore. Fix it by exporting __netdev_watchdog_up().

Quoted 6 lines

Since the commit introducing the regression was backported to stable branches, this one should ideally be as well.

Fixes 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")

Applied and queued up for -stable, please don't CC: stable for networking changes in the future, thank you.