Skip to contentSkip to conversation

iotests: Add copyright line in qcow2.py

PATCH Applied Eric Blake 4 participants 4 messages Jun 9, 2020 – Jun 17, 2020

lore
Share & tools
lore

Eric Blake

author
#0 lore raw

PATCH 1/1 iotests: Add copyright line in qcow2.py

The file qcow2.py was originally contributed in 2012 by Kevin Wolf, but was not given traditional boilerplate headers at the time. The missing license was just rectified (commit 16306a7b39) using the project-default GPLv2+, but as Vladimir is not at Red Hat, he did not add a Copyright line. All earlier contributions have come from CC'd authors, where all but Stefan used a Red Hat address at the time of the contribution, and that copyright carries over to the split to qcow2_format.py (d5262c7124).

CC Kevin Wolf <[email protected]>
CC Stefan Hajnoczi <[email protected]>
CC Eduardo Habkost <[email protected]>
CC Max Reitz <[email protected]>
CC Philippe Mathieu-Daudé <[email protected]>
CC Paolo Bonzini <[email protected]>

---
Commit ids above assume my bitmaps pull request does not have to be respun...
Based-on: <[email protected]>

---
 tests/qemu-iotests/qcow2.py        | 2 ++
 tests/qemu-iotests/qcow2_format.py | 1 +
 2 files changed, 3 insertions(+)
tests/qemu-iotests/qcow2.py +2 -0
index 8c187e9a7292..0910e6ac0705 100755
@@ -2,6 +2,8 @@
 #
 # Manipulations with qcow2 image
 #
+# Copyright (C) 2012 Red Hat, Inc.
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 2 of the License, or
tests/qemu-iotests/qcow2_format.py +1 -0
index 0f65fd161d5b..cc432e7ae06c 100644
@@ -1,6 +1,7 @@
 # Library for manipulations with qcow2 image
 #
 # Copyright (c) 2020 Virtuozzo International GmbH.
+# Copyright (C) 2012 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Eric Blake

The file qcow2.py was originally contributed in 2012 by Kevin Wolf, but was not given traditional boilerplate headers at the time. The missing license was just rectified (commit 16306a7b39) using the project-default GPLv2+, but as Vladimir is not at Red Hat, he did not add a Copyright line. All earlier contributions have come from CC'd authors, where all but Stefan used a Red Hat address at the time of the contribution, and that copyright carries over to the split to qcow2_format.py (d5262c7124).

Quoted 7 lines
CC Kevin Wolf <[email protected]>
CC Stefan Hajnoczi <[email protected]>
CC Eduardo Habkost <[email protected]>
CC Max Reitz <[email protected]>
CC Philippe Mathieu-Daudé <[email protected]>
CC Paolo Bonzini <[email protected]>
Quoted 34 lines

---
Commit ids above assume my bitmaps pull request does not have to be respun...
Based-on: <[email protected]>

---
 tests/qemu-iotests/qcow2.py        | 2 ++
 tests/qemu-iotests/qcow2_format.py | 1 +
 2 files changed, 3 insertions(+)
tests/qemu-iotests/qcow2.py +2 -0
index 8c187e9a7292..0910e6ac0705 100755
@@ -2,6 +2,8 @@
 #
 # Manipulations with qcow2 image
 #
+# Copyright (C) 2012 Red Hat, Inc.
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 2 of the License, or
tests/qemu-iotests/qcow2_format.py +1 -0
index 0f65fd161d5b..cc432e7ae06c 100644
@@ -1,6 +1,7 @@
 # Library for manipulations with qcow2 image
 #
 # Copyright (c) 2020 Virtuozzo International GmbH.
+# Copyright (C) 2012 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
Acked-by on v1 1/1
#2 lore raw
In reply to Eric Blake
Quoted 17 lines · Eric Blake

The file qcow2.py was originally contributed in 2012 by Kevin Wolf, but was not given traditional boilerplate headers at the time. The missing license was just rectified (commit 16306a7b39) using the project-default GPLv2+, but as Vladimir is not at Red Hat, he did not add a Copyright line. All earlier contributions have come from CC'd authors, where all but Stefan used a Red Hat address at the time of the contribution, and that copyright carries over to the split to qcow2_format.py (d5262c7124).

CC Kevin Wolf <[email protected]>
CC Stefan Hajnoczi <[email protected]>
CC Eduardo Habkost <[email protected]>
CC Max Reitz <[email protected]>
CC Philippe Mathieu-Daudé <[email protected]>
CC Paolo Bonzini <[email protected]>
Quoted 7 lines

---
Commit ids above assume my bitmaps pull request does not have to be respun...
Based-on: <[email protected]>

---
 tests/qemu-iotests/qcow2.py        | 2 ++
 tests/qemu-iotests/qcow2_format.py | 1 +
 2 files changed, 3 insertions(+)

The git history shows which lines were contributed by IBM and is more detailed than a single copyright line at the top of the file. It's also common to make smaller contributions, like the one I made here, without adding a copyright line. In light of this I see no issue with adding a Red Hat copyright line and there is no need to add one for IBM:

Applied
#3 lore raw
In reply to Eric Blake

Am 09.06.2020 um 22:59 hat Eric Blake geschrieben:

Quoted 9 lines

The file qcow2.py was originally contributed in 2012 by Kevin Wolf, but was not given traditional boilerplate headers at the time. The missing license was just rectified (commit 16306a7b39) using the project-default GPLv2+, but as Vladimir is not at Red Hat, he did not add a Copyright line. All earlier contributions have come from CC'd authors, where all but Stefan used a Red Hat address at the time of the contribution, and that copyright carries over to the split to qcow2_format.py (d5262c7124).

Quoted 7 lines
CC Kevin Wolf <[email protected]>
CC Stefan Hajnoczi <[email protected]>
CC Eduardo Habkost <[email protected]>
CC Max Reitz <[email protected]>
CC Philippe Mathieu-Daudé <[email protected]>
CC Paolo Bonzini <[email protected]>

Thanks, applied to the block branch.

Kevin