Skip to contentSkip to conversation

clk: mediatek: Remove ifr{0,1}_cfg_regs structures

PATCH In review Stephen Boyd 2 participants 2 messages Jun 9, 2020 – Jun 18, 2020

Subsystems (2)
lore
Share & tools
lore

Stephen Boyd

author maintainer
#0 lore raw

PATCH 1/1 clk: mediatek: Remove ifr{0,1}_cfg_regs structures

These aren't used and the macros that reference them aren't used either. Remove the dead code to avoid compile warnings.

Cc Owen Chen <[email protected]>
Cc Mars Cheng <[email protected]>
Cc Macpaul Lin <[email protected]>
Fixes 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
---
 drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
 1 file changed, 30 deletions(-)
drivers/clk/mediatek/clk-mt6765.c +0 -30
index 3ec53cb62ece..db8db1b3b79d 100644
@@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
 	GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
 };
 
-static const struct mtk_gate_regs ifr0_cg_regs = {
-	.set_ofs = 0x200,
-	.clr_ofs = 0x200,
-	.sta_ofs = 0x200,
-};
-
-static const struct mtk_gate_regs ifr1_cg_regs = {
-	.set_ofs = 0x74,
-	.clr_ofs = 0x74,
-	.sta_ofs = 0x74,
-};
-
 static const struct mtk_gate_regs ifr2_cg_regs = {
 	.set_ofs = 0x80,
 	.clr_ofs = 0x84,
@@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
 	.sta_ofs = 0xc8,
 };
 
-#define GATE_IFR0(_id, _name, _parent, _shift) {	\
-		.id = _id,				\
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr0_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
-	}
-
-#define GATE_IFR1(_id, _name, _parent, _shift) {	\
-		.id = _id,				\
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr1_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr,	\
-	}
-
 #define GATE_IFR2(_id, _name, _parent, _shift) {	\
 		.id = _id,				\
 		.name = _name,				\
Signature · 1 line
Sent by a computer, using git, on the internet
#1 lore raw
Quoted 51 lines · Stephen Boyd

These aren't used and the macros that reference them aren't used either. Remove the dead code to avoid compile warnings.

Cc Owen Chen <[email protected]>
Cc Mars Cheng <[email protected]>
Cc Macpaul Lin <[email protected]>
Fixes 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
---
 drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
 1 file changed, 30 deletions(-)
drivers/clk/mediatek/clk-mt6765.c +0 -23
index 3ec53cb62ece..db8db1b3b79d 100644
@@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
 	GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
 };
 
-static const struct mtk_gate_regs ifr0_cg_regs = {
-	.set_ofs = 0x200,
-	.clr_ofs = 0x200,
-	.sta_ofs = 0x200,
-};
-
-static const struct mtk_gate_regs ifr1_cg_regs = {
-	.set_ofs = 0x74,
-	.clr_ofs = 0x74,
-	.sta_ofs = 0x74,
-};
-
 static const struct mtk_gate_regs ifr2_cg_regs = {
 	.set_ofs = 0x80,
 	.clr_ofs = 0x84,
@@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
 	.sta_ofs = 0xc8,
 };
 
-#define GATE_IFR0(_id, _name, _parent, _shift) {	\
-		.id = _id,				\
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr0_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
-	}
-
-#define GATE_IFR1(_id, _name, _parent, _shift) {	\
-		.id = _id,				\

drivers/clk/mediatek/clk-mt6765.c static const struct mtk_gate_regs ifr5_cg_regs = { · line 563

Quoted 10 lines
drivers/clk/mediatek/clk-mt6765.c +0 -7
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr1_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr,	\
-	}
-
 #define GATE_IFR2(_id, _name, _parent, _shift) {	\
 		.id = _id,				\
 		.name = _name,				\

Thank you so much!
Owen and I were busy in other issues hence cannot help fix this issue in time.

Thanks a lot!
BR,
Macpaul Lin