Skip to contentSkip to conversation

toybox-inittab: Get rid of bashism

PATCH In review Khem Raj 2 participants 2 messages Jun 10, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 toybox-inittab: Get rid of bashism

Be explicit about copying the files, makes it simpler for dash to handle it

Cc Martin Jansa <[email protected]>
Cc Adam Miartus <[email protected]>
---
 meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb +2 -2
index 8d7ff61e86..9af1e3f149 100644
@@ -26,8 +26,8 @@ do_patch[noexec] = "1"
 
 do_configure() {
 	# copy over files now to have a fresh start on each config
-	for file in ${SRC_URI}; do
-		cp ${WORKDIR}/${file/file:\/\//} ${S}
+	for f in inittab rcK rcS; do
+		cp ${WORKDIR}/$f ${S}
 	done
 
 	for config in ${PACKAGECONFIG_CONFARGS}; do
Signature · 1 line
2.27.0
#1 lore raw

Thanks, my world builds will be green again! .. maybe.. :)

Quoted 30 lines · Khem Raj

Be explicit about copying the files, makes it simpler for dash to handle it

Cc Martin Jansa <[email protected]>
Cc Adam Miartus <[email protected]>
---
 meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb +2 -3
index 8d7ff61e86..9af1e3f149 100644
@@ -26,8 +26,8 @@ do_patch[noexec] = "1"
 
 do_configure() {
        # copy over files now to have a fresh start on each config
-       for file in ${SRC_URI}; do
-               cp ${WORKDIR}/${file/file:\/\//} ${S}
+       for f in inittab rcK rcS; do
+               cp ${WORKDIR}/$f ${S}
        done
 
        for config in ${PACKAGECONFIG_CONFARGS}; do
--

2.27.0