Skip to contentSkip to conversation

EDAC, {skx,i10nm}: Advice mcelog that the error were handled

PATCH In review Zhenzhong Duan 3 participants 4 messages Jun 10, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC, {skx,i10nm}: Advice mcelog that the error were handled

If one MCE error has been processed in kernel, it's not necessory to pass it to user level mcelog.

---
 drivers/edac/skx_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/skx_common.c +2 -1
index 46be1a7..8c0165b 100644
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
 
 	skx_mce_output_error(mci, mce, &res);
 
-	return NOTIFY_DONE;
+	/* Advice mcelog that the error were handled */
+	return NOTIFY_STOP;
 }
 
 void skx_remove(void)
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 14 lines · Zhenzhong Duan

If one MCE error has been processed in kernel, it's not necessory to pass it to user level mcelog.

---
 drivers/edac/skx_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/skx_common.c +0 -0
index 46be1a7..8c0165b 100644

drivers/edac/skx_common.c int skx_mce_check_error(struct notifier_block *nb, unsigned long val, · line 622

Quoted 9 lines
drivers/edac/skx_common.c +2 -1
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
 
 	skx_mce_output_error(mci, mce, &res);
 
-	return NOTIFY_DONE;
+	/* Advice mcelog that the error were handled */
+	return NOTIFY_STOP;
 }
 
 void skx_remove(void)

No, we won't be doing that anymore. See here:

https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568

it should appear mainline soon-ish, I hope.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#2 lore raw
Quoted 23 lines · Borislav Petkov
Quoted 21 lines · Zhenzhong Duan

If one MCE error has been processed in kernel, it's not necessory to pass it to user level mcelog.

---
 drivers/edac/skx_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/skx_common.c +2 -1
index 46be1a7..8c0165b 100644
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
 
      skx_mce_output_error(mci, mce, &res);
 
-     return NOTIFY_DONE;
+     /* Advice mcelog that the error were handled */
+     return NOTIFY_STOP;
 }
 
Quoted 8 lines

drivers/edac/skx_common.c int skx_mce_check_error(struct notifier_block *nb, unsigned long val,

Quoted 2 lines
drivers/edac/skx_common.c +0 -1
 void skx_remove(void)
--

No, we won't be doing that anymore. See here:

https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568

it should appear mainline soon-ish, I hope.

I see, thanks for showing.

Zhenzhong

Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled

In reply to Zhenzhong Duan
Quoted 4 lines · Zhenzhong Duan

If one MCE error has been processed in kernel, it's not necessory to pass it to user level mcelog.

Quoted 9 lines
---
 drivers/edac/skx_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/skx_common.c +0 -0
index 46be1a7..8c0165b 100644

drivers/edac/skx_common.c int skx_mce_check_error(struct notifier_block *nb, unsigned long val, · line 618

Quoted 5 lines
drivers/edac/skx_common.c +1 -1
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
 
 	skx_mce_output_error(mci, mce, &res);
 
-	return NOTIFY_DONE;
+	/* Advice mcelog that the error were handled */

... error was ...

And make a sentence out of it, so close with a dot.

drivers/edac/skx_common.c int skx_mce_check_error(struct notifier_block *nb, unsigned long val, · line 619

Quoted 1 line
drivers/edac/skx_common.c +1 -0
+	return NOTIFY_STOP;

This change aligns with other implementation in:

i7core_mce_check_error(),
amd_decode_mce() and
sbridge_mce_check_error().

-Robert

Quoted 6 lines
drivers/edac/skx_common.c +0 -0
 }
 
 void skx_remove(void)
Signature · 1 line
1.8.3.1