Skip to contentSkip to conversation

uftrace: add PV to update the package version

PATCH In review Adrian Bunk 2 participants 3 messages Jun 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uftrace: add PV to update the package version

From: Honggyu Kim <[email protected]>

uftrace_0.9.4.bb now doesn't actually use exact 0.9.4 version, so it has to add a PV value to update the package version.

---
 meta-oe/recipes-devtools/uftrace/uftrace_0.9.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/uftrace/uftrace_0.9.4.bb +1 -1
index c33fa048c..a3d060218 100644
@@ -10,7 +10,7 @@ DEPENDS_append_libc-musl = " argp-standalone"
 
 inherit autotools
 
-# v0.9.4
+PV .= "+git${SRCPV}"
 SRCREV = "d648bbffedef529220896283fb59e35531c13804"
 SRC_URI = "git://github.com/namhyung/${BPN} \
            "
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Adrian Bunk

From: Honggyu Kim <[email protected]>

uftrace_0.9.4.bb now doesn't actually use exact 0.9.4 version, so it has to add a PV value to update the package version.

I remember looking at this one. As I could not see how this had any bearing on the function of the package I skipped it.

Why does it have merit?

-armin

Quoted 23 lines
---
 meta-oe/recipes-devtools/uftrace/uftrace_0.9.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/uftrace/uftrace_0.9.4.bb +1 -1
index c33fa048c..a3d060218 100644
@@ -10,7 +10,7 @@ DEPENDS_append_libc-musl = " argp-standalone"
 
 inherit autotools
 
-# v0.9.4
+PV .= "+git${SRCPV}"
 SRCREV = "d648bbffedef529220896283fb59e35531c13804"
 SRC_URI = "git://github.com/namhyung/${BPN} \
            "
#2 lore raw
Quoted 10 lines · On Wed, Jun 10, 2020 at 07:09:11AM -0700, akuster808 wrote:
Quoted 4 lines · Adrian Bunk

From: Honggyu Kim <[email protected]>

uftrace_0.9.4.bb now doesn't actually use exact 0.9.4 version, so it has to add a PV value to update the package version.

I remember looking at this one. As I could not see how this had any bearing on the function of the package I skipped it.

Why does it have merit?

It does show the correct version of the software.

0.9.4 is upstream version 0.9.4
0.9.4+git is some git snapshot after 0.9.4

This is a difference, e.g. when reporting a bug to upstream.

Quoted 1 line

-armin

cu
Adrian