Skip to contentSkip to conversation

LIB: Use INTERNAL_LIB for ltp lib

PATCH Superseded Yang Xu 3 participants 6 messages Jun 10, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 57a1c19e-d8e5-4389-8565-20e49f144657@G08CNEXMBPEKD05.g08.fujitsu.local

Yang Xu

author
#1 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

Hi Petr

Nothing blocks this simple patch, I guess we can directly push this patch(don't forget jan's acked-by).

Best Regards
Yang Xu

Quoted 29 lines

Hi petr
just reply for your ?Given Jan acked v1, I'd be also for merge?? v2 is OK.

Best Regards
Yang Xu

---Original---
*From:* "Petr Vorel"<[email protected]>
*Date:* Mon, Jun 8, 2020 19:41 PM
*To:* "Yang Xu"<[email protected]>;
*Cc:* "ltp"<[email protected]>;
*Subject:* Re: [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib

Hi?Xu,

Quoted 4 lines

?>?Cyril?concerned?3rd?party?use?of?lib/libltp.a,?but?nobody?complained. ?>?Given?Jan?acked?v1,?I'd?be?also?for?merge.

??We?also?should?include?android_libpthread?and?android_librt?Makefile.

Not?sure?what?you?mean.?You?did?the?change?in?android_libpthread?and android_librt?Makefile?(this?is?v2?thread),?thus?I?consider?this?patch?ready. Or?am?I?missing?something?

Kind?regards,
Petr

Signature · 1 line
Mailing?list?info:?https://lists.linux.it/listinfo/ltp
#2 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

Hi Xu,

Quoted 4 lines

Hi Petr

Nothing blocks this simple patch, I guess we can directly push this patch(don't forget jan's acked-by).

I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).

Maybe removing libdir could be in separate commit, it looks to me as unrelated change.

And you haven't replied to my question:
https://lists.linux.it/pipermail/ltp/2020-June/017495.html

But newer mind :). Maybe it's just me, but "Also include Android_libpthread and android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and android_librt" (because include is ambiguous, when we're trying not to install/include these statically linked libraries.

BTW if you ack it, I can do this changes before merge.

Kind regards,
Petr

author
#3 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

Hi Petr

Quoted 8 lines

Hi Xu,

Quoted 4 lines

Hi Petr

Nothing blocks this simple patch, I guess we can directly push this patch(don't forget jan's acked-by).

I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).

Yes.

Quoted 4 lines

Maybe removing libdir could be in separate commit, it looks to me as unrelated change.

Agree.

Quoted 7 lines

And you haven't replied to my question:
https://lists.linux.it/pipermail/ltp/2020-June/017495.html

But newer mind :). Maybe it's just me, but "Also include Android_libpthread and android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and android_librt" (because include is ambiguous, when we're trying not to install/include these statically linked libraries.

Yes, My meaning is that v1 does not modify Android_libpthread/android_librt, and v2 does this. Using modify is better.

Quoted 2 lines

BTW if you ack it, I can do this changes before merge.

acked.

Best Regards
Yang Xu

Quoted 5 lines

Kind regards,
Petr

#4 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

Hi Xu,

Quoted 5 lines
Quoted 1 line

I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).

Yes.

Quoted 2 lines

Maybe removing libdir could be in separate commit, it looks to me as unrelated change.

Actually, when looking into this more (this part is new in v2, Jan didn't review it).

I'd keep keep libdir in include/mk/config.mk.in, because we use it in our lib/ltp.pc file. Maybe we don't need if we don't install any library, but then we should remove also LIB variable and associated code in include/mk/lib.mk. Which should be a second step (second commit).

Also libdir is somehow expected by automake (it's referenced in generated ./m4/Makefile.in ./testcases/realtime/m4/Makefile.in).

Kind regards,
Petr

#5 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

In reply to Petr Vorel
Quoted 11 lines · Petr Vorel

Hi Xu,

Quoted 4 lines

Hi Petr

Nothing blocks this simple patch, I guess we can directly push this patch(don't forget jan's acked-by).

I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).

Maybe removing libdir could be in separate commit, it looks to me as unrelated change.

Hi Petr, Xu

Agreed, This patch should focus on replacing LIB with INTERNAL_LIB.

My question about the issue is not important, we can just keep libdir for now as you want because someone may add dynamic library linking in future.

Thanks,
Xiao Yang

Quoted 14 lines

And you haven't replied to my question:
https://lists.linux.it/pipermail/ltp/2020-June/017495.html

But newer mind :). Maybe it's just me, but "Also include Android_libpthread and android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and android_librt" (because include is ambiguous, when we're trying not to install/include these statically linked libraries.

BTW if you ack it, I can do this changes before merge.

Kind regards,
Petr

#6 lore raw

PATCH v2 1/1 LIB: Use INTERNAL_LIB for ltp lib

Hi Yang, Xu,

Quoted 1 line

Agreed, This patch should focus on replacing LIB with INTERNAL_LIB.

+1 merged (with adjusted commit message, added realtime and keeping libdir changes for now).

Xu, thank you!

Quoted 2 lines

My question about the issue is not important, we can just keep libdir for now as you want because someone may add dynamic library linking in future.

Yep, let's leave it now. I guess for adding LTP into traditional linux distribution (not just have it in QA teams repositories or in embedded distros) LTP libraries would have to be dynamically linked.

Also traditional distros would probably install most of LTP binaries outside of /usr/bin, into LTP library path (e.g. /usr/lib64/ltp). Thus I'm for keeping that old comment in include/mk/generic_leaf_target.inc.

Kind regards,
Petr