Skip to contentSkip to conversation

Install/uninstall dialer DLL as part of Windows installer operation

PATCH In review Kevin Kane 2 participants 2 messages Jul 25, 2018 – Jun 10, 2020

lore
Share & tools
lore

Kevin Kane

author
#0 lore raw

PATCH v2 1/1 Install/uninstall dialer DLL as part of Windows installer operation

---
 windows-nsis/openvpn.nsi | 4 ++++
 1 file changed, 4 insertions(+)
windows-nsis/openvpn.nsi +4 -0
index e92904d..aff7cb3 100755
@@ -1,6 +1,7 @@
 ; ****************************************************************************
 ; * Copyright (C) 2002-2010 OpenVPN Technologies, Inc.                       *
 ; * Copyright (C)      2012 Alon Bar-Lev <[email protected]...>             *
+; * Portions Copyright (C) 2018 Microsoft Corporation                        *
 ; *  This program is free software; you can redistribute it and/or modify    *
 ; *  it under the terms of the GNU General Public License version 2          *
 ; *  as published by the Free Software Foundation.                           *
@@ -443,8 +444,10 @@ Section /o "${PACKAGE_NAME} GUI" SecOpenVPNGUI
 
 	${If} ${RunningX64}
 		File "${OPENVPN_ROOT_X86_64}\bin\openvpn-gui.exe"
+		File "${OPENVPN_ROOT_X86_64}\bin\libopenvpndialer-0.dll"
 	${Else}
 		File "${OPENVPN_ROOT_I686}\bin\openvpn-gui.exe"
+		File "${OPENVPN_ROOT_I686}\bin\libopenvpndialer-0.dll"
 	${EndIf}
 
 	${If} ${SectionIsSelected} ${SecAddShortcutsWorkaround}
@@ -770,6 +773,7 @@ Section "Uninstall"
 	${EndIf}
 
 	Delete "$INSTDIR\bin\openvpn-gui.exe"
+	Delete "$INSTDIR\bin\libopenvpndialer-0.dll"
 	Delete "$DESKTOP\${PACKAGE_NAME} GUI.lnk"
 
 	Delete "$INSTDIR\bin\openvpn.exe"
Signature · 1 line
2.17.1.windows.2
#1 lore raw

Hi,

Quoted 4 lines · Kevin Kane via Openvpn-devel
---
 windows-nsis/openvpn.nsi | 4 ++++
 1 file changed, 4 insertions(+)

I'm trying to clean up "dangling" OpenVPN stuff while in the run-down to 2.5 code freeze.

Came across your patchset to make OpenVPN a proper "dial-on demand" VPN (if I remember right).

Was this ever finished into something mergeable?

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...