KVM: selftests: fix sync_with_host() in smm_test
PATCH 1/1 KVM: selftests: fix sync_with_host() in smm_test
It was reported that older GCCs compile smm_test in a way that breaks it completely:
kvm_exit: reason EXIT_CPUID rip 0x4014db info 0 0
func 7ffffffd idx 830 rax 0 rbx 0 rcx 0 rdx 0, cpuid entry not found
...
kvm_exit: reason EXIT_MSR rip 0x40abd9 info 0 0
kvm_msr: msr_read 487 = 0x0 (#GP)
...
Note, '7ffffffd' was supposed to be '80000001' as we're checking for SVM. Dropping '-O2' from compiler flags help. Turns out, asm block in sync_with_host() is wrong. We us 'in 0xe, %%al' instruction to sync with the host and in 'AL' register we actually pass the parameter (stage) but after sync 'AL' gets written to but GCC thinks the value is still there and uses it to compute 'EAX' for 'cpuid'.
smm_test can't fully use standard ucall() framework as we need to write a very simple SMI handler there. Fix the immediate issue by making RAX input/output operand. While on it, make sync_with_host() static inline.
--- tools/testing/selftests/kvm/x86_64/smm_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/kvm/x86_64/smm_test.c +2 -2
@@ -47,10 +47,10 @@ uint8_t smi_handler[] = { 0x0f, 0xaa, /* rsm */ }; -void sync_with_host (uint64_t phase) +static inline void sync_with_host (uint64_t phase) { asm volatile("in $" XSTR(SYNC_PORT)", %%al \n" - : : "a" (phase)); + : "+a" (phase)); } void self_smi(void)
Signature · 1 line
2.25.4
Quoted 11 lines · Vitaly Kuznetsov
It was reported that older GCCs compile
smm_testin a way that breaks it completely:
kvm_exit: reasonEXIT_CPUIDrip0x4014dbinfo 0 0
func7ffffffdidx 830 rax 0 rbx 0 rcx 0 rdx 0, cpuid entry not found
...
kvm_exit: reasonEXIT_MSRrip0x40abd9info 0 0
kvm_msr:msr_read487 =0x0(#GP)
...
Quoted 6 lines
Note, '
7ffffffd' was supposed to be '80000001' as we're checking for SVM. Dropping '-O2' from compiler flags help. Turns out, asm block insync_with_host()is wrong. We us 'in0xe, %%al' instruction to sync with the host and in 'AL' register we actually pass the parameter (stage) but after sync 'AL' gets written to but GCC thinks the value is still there and uses it to compute 'EAX' for 'cpuid'.
That smells like VMware's hypercall madness!
Quoted 7 lines
smm_testcan't fully use standarducall()framework as we need to write a very simple SMI handler there. Fix the immediate issue by making RAX input/output operand. While on it, makesync_with_host()static inline.Reported-by Marcelo Bandeira Condotta <[email protected]>Signed-off-by Vitaly Kuznetsov <[email protected]>
Quoted 36 lines · Vitaly Kuznetsov
It was reported that older GCCs compile
smm_testin a way that breaks it completely:
kvm_exit: reasonEXIT_CPUIDrip0x4014dbinfo 0 0
func7ffffffdidx 830 rax 0 rbx 0 rcx 0 rdx 0, cpuid entry not found
...
kvm_exit: reasonEXIT_MSRrip0x40abd9info 0 0
kvm_msr:msr_read487 =0x0(#GP)
...Note, '
7ffffffd' was supposed to be '80000001' as we're checking for SVM. Dropping '-O2' from compiler flags help. Turns out, asm block insync_with_host()is wrong. We us 'in0xe, %%al' instruction to sync with the host and in 'AL' register we actually pass the parameter (stage) but after sync 'AL' gets written to but GCC thinks the value is still there and uses it to compute 'EAX' for 'cpuid'.
smm_testcan't fully use standarducall()framework as we need to write a very simple SMI handler there. Fix the immediate issue by making RAX input/output operand. While on it, makesync_with_host()static inline.Reported-by Marcelo Bandeira Condotta <[email protected]>Signed-off-by Vitaly Kuznetsov <[email protected]>--- tools/testing/selftests/kvm/x86_64/smm_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/kvm/x86_64/smm_test.c +0
-0@@ -47,10 +47,10 @@ uint8_t smi_handler[] = { 0x0f, 0xaa, /* rsm */ };
tools/testing/selftests/kvm/x86_64/smm_test.c uint8_t smi_handler[] = { · line 56
Quoted 10 lines
tools/testing/selftests/kvm/x86_64/smm_test.c +2
-2-void sync_with_host (uint64_t phase) +static inline void sync_with_host (uint64_t phase) { asm volatile("in $" XSTR(SYNC_PORT)", %%al \n" - : : "a" (phase)); + : "+a" (phase)); } void self_smi(void)
Queued, thanks.
Paolo