Skip to contentSkip to conversation

dt-bindings: mfd: Ensure 'syscon' has a more specific compatible

PATCH In review Rob Herring 2 participants 2 messages Jun 10, 2020 – Jun 11, 2020

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mfd: Ensure 'syscon' has a more specific compatible

Using 'syscon' alone should be avoided as compatible strings should be specific enough to identify the exact set of registers contained. Update the schema to ensure at least 2 compatible strings are present.

Cc Lee Jones <[email protected]>
Cc Maxime Ripard <[email protected]>

---
FYI, there's 43 cases of this on arm32 in my testing.

 Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/syscon.yaml +2 -1
index 19bdaf781853..af7a68051392 100644
@@ -43,7 +43,8 @@ properties:
 
       - contains:
           const: syscon
-        additionalItems: true
+        minItems: 2
+        maxItems: 4  # Should be enough
 
   reg:
     maxItems: 1
Signature · 1 line
2.25.1
#1 lore raw

Arnd,

Quoted 3 lines · Rob Herring

Using 'syscon' alone should be avoided as compatible strings should be specific enough to identify the exact set of registers contained. Update the schema to ensure at least 2 compatible strings are present.

I'm assuming you're okay with this?

Quoted 23 lines
Cc Lee Jones <[email protected]>
Cc Maxime Ripard <[email protected]>

---
FYI, there's 43 cases of this on arm32 in my testing.

 Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/syscon.yaml +2 -1
index 19bdaf781853..af7a68051392 100644
@@ -43,7 +43,8 @@ properties:
 
       - contains:
           const: syscon
-        additionalItems: true
+        minItems: 2
+        maxItems: 4  # Should be enough
 
   reg:
     maxItems: 1
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog