net: dwc_eth_qos: add Kconfig option to select supported configuration
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Add configuration flag to select the supported dwc driver configuration:
- CONFIG_DWC_ETH_QOS_TEGRA186
- CONFIG_DWC_ETH_QOS_IMX
- CONFIG_DWC_ETH_QOS_STM32
See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
---
Hi,
I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net: dwc_eth_qos: Make clk_rx and clk_tx optional
http://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595
[2] net: dwc_eth_qos: update the compatible supported for STM32
http://patchwork.ozlabs.org/project/uboot/list/?series=176917
drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)
drivers/net/Kconfig +24 -3
@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip. config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
drivers/net/dwc_eth_qos.c +9 -3
@@ -2100,7 +2100,7 @@ static struct eqos_ops eqos_tegra186_ops = { .eqos_get_tick_clk_rate = eqos_get_tick_clk_rate_tegra186 }; -static const struct eqos_config eqos_tegra186_config = { +static const struct eqos_config __maybe_unused eqos_tegra186_config = { .reg_access_always_ok = false, .mdio_wait =10 , .swr_wait =10 ,
@@ -2127,7 +2127,7 @@ static struct eqos_ops eqos_stm32_ops = { .eqos_get_tick_clk_rate = eqos_get_tick_clk_rate_stm32 }; -static const struct eqos_config eqos_stm32_config = { +static const struct eqos_config __maybe_unused eqos_stm32_config = { .reg_access_always_ok = false, .mdio_wait =10000 , .swr_wait =50 ,
@@ -2154,7 +2154,7 @@ static struct eqos_ops eqos_imx_ops = { .eqos_get_tick_clk_rate = eqos_get_tick_clk_rate_imx }; -struct eqos_config eqos_imx_config = { +struct eqos_config __maybe_unused eqos_imx_config = { .reg_access_always_ok = false, .mdio_wait =10000 , .swr_wait =50 ,
@@ -2165,18 +2165,24 @@ struct eqos_config eqos_imx_config = { };static const struct udevice_id eqos_ids[] = { +#if IS_ENABLED(CONFIG_DWC_ETH_QOS_TEGRA186) { .compatible ="nvidia,tegra186-eqos" , .data = (ulong)&eqos_tegra186_config }, +#endif +#if IS_ENABLED(CONFIG_DWC_ETH_QOS_STM32) { .compatible ="snps,dwmac-4.20a" , .data = (ulong)&eqos_stm32_config }, +#endif +#if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX) { .compatible ="fsl,imx-eqos" , .data = (ulong)&eqos_imx_config }, +#endif { } };
Signature · 1 line
2.17.1
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 58 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +17
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. +
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 10 lines
drivers/net/Kconfig +7
-0+config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip. config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"
I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/1161f393/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.
Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 76 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Quoted 3 lines
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a Kconfig choice to just Kconfig options I don't see that as being a relevant question here.
Or did I misunderstand the question?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/c071337a/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 81 lines · Tom Rini
Quoted 76 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Quoted 3 lines
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a Kconfig option generate it's _SPL and _TPL variant.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 88 lines · Marek Vasut
Quoted 87 lines · Tom Rini
Quoted 76 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Quoted 3 lines
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.
Quoted 4 lines
Quoted 1 line
Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.
Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/615dee38/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 89 lines · Tom Rini
Quoted 88 lines · Marek Vasut
Quoted 87 lines · Tom Rini
Quoted 76 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Quoted 3 lines
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
For some sort of universal SPL, maybe ?
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 92 lines · Marek Vasut
Quoted 91 lines · Tom Rini
Quoted 90 lines · Marek Vasut
Quoted 88 lines · Tom Rini
Quoted 76 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>---
Hi,I propose this patch after Marek's remark in [1].
It is also linked to [2] to limit the STM32 glue for ST compatible.
[1] net:
dwc_eth_qos: Makeclk_rxandclk_txoptionalhttp://patchwork.ozlabs.org/project/uboot/patch/20200512095603.29126-5-david.wu at rock-chips.com/#2432595[2] net:
dwc_eth_qos: update the compatible supported for STM32http://patchwork.ozlabs.org/project/uboot/list/?series=176917drivers/net/Kconfig | 27 ++++++++++++++++++++++++--- drivers/net/dwc_eth_qos.c | 12 +++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-)drivers/net/Kconfig +24
-3@@ -156,9 +156,30 @@ config DWC_ETH_QOS help This driver supports the Synopsys Designware Ethernet QOS (Quality Of Service) IP block. The IP supports many options for bus type, - clocking/reset structure, and feature list. This driver currently - supports the specific configuration used in NVIDIA's Tegra186 chip, - but should be extensible to other combinations quite easily. + clocking/reset structure, and feature list. + +config DWC_ETH_QOS_IMX + bool "Synopsys DWC Ethernet QOS device support for IMX" + depends on DWC_ETH_QOS + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in IMX soc. + +config DWC_ETH_QOS_STM32 + bool "Synopsys DWC Ethernet QOS device support for STM32" + depends on DWC_ETH_QOS + default y if ARCH_STM32MP + help + The Synopsys Designware Ethernet QOS IP block with the specific + configuration used in STM32MP soc. + +config DWC_ETH_QOS_TEGRA186 + bool "Synopsys DWC Ethernet QOS device support for TEGRA186" + depends on DWC_ETH_QOS + default y if TEGRA186 + help + The Synopsys Designware Ethernet QOS IP block with specific + configuration used in NVIDIA's Tegra186 chip.Quoted 6 lines
drivers/net/Kconfig config DWC_ETH_QOS · line 185
Quoted 2 lines
drivers/net/Kconfig +0
-0config E1000 bool "Intel PRO/1000 Gigabit Ethernet support"I like this idea. But, is there a reason to have more than one of these enabled? Assuming not, we should do this as a choice I think so it'll be clear to the next SoC that they'll need to add this table right away.
Quoted 3 lines
Should we be able to enable different settings in U-Boot and in SPL , e.g. for the use case where the SPL is the same on different SoCs, while the U-Boot binary is not ?
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/ab2e203b/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate _SPL and _TPL variants of Kconfig entries for all Kconfig entries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 16 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.
In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more than one of those.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/34a1515a/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 21 lines · Tom Rini
Quoted 20 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Quoted 8 lines
Quoted 4 lines
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more than one of those.
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 27 lines · Marek Vasut
Quoted 26 lines · Tom Rini
Quoted 24 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.
Quoted 8 lines
Quoted 3 lines
In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more than one of those.
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
So that's the case I brought up at first and you said no to. I don't see that in the foreseeable future but I don't feel so strongly about making this config area tidy enough to argue the point. So fine, leave it as separate options, the default y if ... is reasonable enough to ensure we get functional builds.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/d88b1238/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 32 lines · Tom Rini
Quoted 31 lines · Marek Vasut
Quoted 29 lines · Tom Rini
Quoted 16 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more than one of those.
Quoted 6 lines
Quoted 4 lines
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
So that's the case I brought up at first and you said no to.
I think I don't understand this part.
Quoted 5 lines
I don't
see that in the foreseeable future but I don't feel so strongly about making this config area tidy enough to argue the point. So fine, leave it as separate options, the default y if ... is reasonable enough to ensure we get functional builds.
This patch is OK as-is.
My point is more in the general direction of being able to configure SPL/TPL/U-Boot separately, without being forced to craft nasty ifdeffery in include/config/board.h if I need something enabled in SPL, but not in U-Boot, and vice versa. And for that the Kconfig should be able to somehow emit the _SPL/_TPL/U-Boot options of all symbols I think, so that we won't need separate entry for each.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 33 lines · Marek Vasut
Quoted 32 lines · Tom Rini
Quoted 31 lines · Marek Vasut
Quoted 29 lines · Tom Rini
Quoted 16 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
Quoted 7 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being a relevant question here.Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their own set of options.In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more than one of those.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
So that's the case I brought up at first and you said no to.
I think I don't understand this part.
You're talking about a binary that runs on more than one dissimilar SoC, yes?
Quoted 7 lines
Quoted 5 lines
I don't
see that in the foreseeable future but I don't feel so strongly about making this config area tidy enough to argue the point. So fine, leave it as separate options, the default y if ... is reasonable enough to ensure we get functional builds.This patch is OK as-is.
Yes, since I'm no longer asking for changes to it, it's fine.
Quoted 6 lines
My point is more in the general direction of being able to configure SPL/TPL/U-Boot separately, without being forced to craft nasty ifdeffery in
include/config/board.hif I need something enabled in SPL, but not in U-Boot, and vice versa. And for that theKconfigshould be able to somehow emit the _SPL/_TPL/U-Boot options of all symbols I think, so that we won't need separate entry for each.
I haven't seen a case where the nasty ifdeffery in a config header file wasn't basically either:
- Now wrong (we _have_ the symbols today to say we don't want X in SPL)
- Working around a case where we need to use $(SPL_TPL_) somewhere but didn't know that we could use $(SPL_TPL_) to fix the problem instead.
- Now not useful (for example, disable CMD_xxx for SPL, but we've really sorted things out so now so doing that didn't help anything).
Now I'm happy to admit that I just might be missing a case as I've only gotten as far as "undef CONFIG_[ABC]" and BOOTCOMMAND is possibly leading to embedding a long string where we really don't want it. Please point me at more undef cases that need to be resolved in some way. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/647cddd5/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
On 6/10/20 11:57 PM, Tom Rini wrote:
[...]
Quoted 15 lines
Quoted 6 lines
My point is more in the general direction of being able to configure SPL/TPL/U-Boot separately, without being forced to craft nasty ifdeffery in
include/config/board.hif I need something enabled in SPL, but not in U-Boot, and vice versa. And for that theKconfigshould be able to somehow emit the _SPL/_TPL/U-Boot options of all symbols I think, so that we won't need separate entry for each.I haven't seen a case where the nasty ifdeffery in a config header file wasn't basically either:
- Now wrong (we _have_ the symbols today to say we don't want X in SPL)
- Working around a case where we need to use $(SPL_TPL_) somewhere but didn't know that we could use $(SPL_TPL_) to fix the problem instead.
- Now not useful (for example, disableCMD_xxxfor SPL, but we've really sorted things out so now so doing that didn't help anything).
Quoted 5 lines
Now I'm happy to admit that I just might be missing a case as I've only gotten as far as "undef CONFIG_[ABC]" and BOOTCOMMAND is possibly leading to embedding a long string where we really don't want it. Please point me at more undef cases that need to be resolved in some way.
I don't want to resolve these problems one-by-one , the obvious solution for them AND the growth of Kconfig files with multiple copies of the same symbol for SPL/TPL/U-Boot is the have Kconfig generate those symbols automatically for SPL/TPL/U-Boot and then let user pick the configuration as needed. That would make the undefs in include/configs/board.h go away easily and would reduce the duplication in Kconfig files.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 24 lines · Marek Vasut
On 6/10/20 11:57 PM, Tom Rini wrote:
[...]Quoted 15 lines
Quoted 6 lines
My point is more in the general direction of being able to configure SPL/TPL/U-Boot separately, without being forced to craft nasty ifdeffery in
include/config/board.hif I need something enabled in SPL, but not in U-Boot, and vice versa. And for that theKconfigshould be able to somehow emit the _SPL/_TPL/U-Boot options of all symbols I think, so that we won't need separate entry for each.I haven't seen a case where the nasty ifdeffery in a config header file wasn't basically either:
- Now wrong (we _have_ the symbols today to say we don't want X in SPL)
- Working around a case where we need to use $(SPL_TPL_) somewhere but didn't know that we could use $(SPL_TPL_) to fix the problem instead.
- Now not useful (for example, disableCMD_xxxfor SPL, but we've really sorted things out so now so doing that didn't help anything).Quoted 5 lines
Now I'm happy to admit that I just might be missing a case as I've only gotten as far as "undef CONFIG_[ABC]" and BOOTCOMMAND is possibly leading to embedding a long string where we really don't want it. Please point me at more undef cases that need to be resolved in some way.
Quoted 7 lines
I don't want to resolve these problems one-by-one , the obvious solution for them AND the growth of
Kconfigfiles with multiple copies of the same symbol for SPL/TPL/U-Boot is the haveKconfiggenerate those symbols automatically for SPL/TPL/U-Boot and then let user pick the configuration as needed. That would make the undefs ininclude/configs/board.hgo away easily and would reduce the duplication inKconfigfiles.
I strongly disagree that having two or three times the number of symbols to select from will result in a better outcome. I see 386 SPL_ '^config ' lines (of which a number are 'default y' lines) and that's more than I thought there would be. There's also 6175 overall symbols today. I would be hopeful that the "lets look at the DTS files and see what we can tell about a platform" thread could help with configuring a good binary better. Because to me the worrisome entries are things like MMC_HS200_SUPPORT / SPL_MMC_HS200_SUPPORT as I would start by asking if the cases where we don't enable that in SPL are intention or oversight.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200610/84b93f8c/attachment.sig>
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 33 lines · Tom Rini
Quoted 24 lines · Marek Vasut
On 6/10/20 11:57 PM, Tom Rini wrote:
[...]Quoted 15 lines
Quoted 6 lines
My point is more in the general direction of being able to configure SPL/TPL/U-Boot separately, without being forced to craft nasty ifdeffery in
include/config/board.hif I need something enabled in SPL, but not in U-Boot, and vice versa. And for that theKconfigshould be able to somehow emit the _SPL/_TPL/U-Boot options of all symbols I think, so that we won't need separate entry for each.I haven't seen a case where the nasty ifdeffery in a config header file wasn't basically either:
- Now wrong (we _have_ the symbols today to say we don't want X in SPL)
- Working around a case where we need to use $(SPL_TPL_) somewhere but didn't know that we could use $(SPL_TPL_) to fix the problem instead.
- Now not useful (for example, disableCMD_xxxfor SPL, but we've really sorted things out so now so doing that didn't help anything).Quoted 5 lines
Now I'm happy to admit that I just might be missing a case as I've only gotten as far as "undef CONFIG_[ABC]" and BOOTCOMMAND is possibly leading to embedding a long string where we really don't want it. Please point me at more undef cases that need to be resolved in some way.
Quoted 7 lines
I don't want to resolve these problems one-by-one , the obvious solution for them AND the growth of
Kconfigfiles with multiple copies of the same symbol for SPL/TPL/U-Boot is the haveKconfiggenerate those symbols automatically for SPL/TPL/U-Boot and then let user pick the configuration as needed. That would make the undefs ininclude/configs/board.hgo away easily and would reduce the duplication inKconfigfiles.
Quoted 9 lines
I strongly disagree that having two or three times the number of symbols to select from will result in a better outcome. I see 386
SPL_'^config ' lines (of which a number are 'default y' lines) and that's more than I thought there would be. There's also 6175 overall symbols today. I would be hopeful that the "lets look at the DTS files and see what we can tell about a platform" thread could help with configuring a good binary better. Because to me the worrisome entries are things likeMMC_HS200_SUPPORT/SPL_MMC_HS200_SUPPORTas I would start by asking if the cases where we don't enable that in SPL are intention or oversight.
Surely HS200 (and HS400/SDR104/UHS) , which wastes _A_LOT_ of boot time and a lot of space, is a good candidate for something to be disabled in SPL.
Some core platform-specific symbols are fine with not having matching _SPL/_TPL counterpart, sure, but that's not the majority of the Kconfig symbols, right? Or maybe we need some new Kconfig keyword (instead of 'config') to describe symbols which do need _SPL/_TPL variants ?
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
In reply to Tom RiniHi,
Quoted 57 lines
From: Tom Rini <[email protected]>
Sent: mercredi 10 juin 2020 23:58Quoted 11 lines · Marek Vasut
Quoted 10 lines · Tom Rini
Quoted 9 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 7 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being arelevant question here.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their ownset of options.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more
than one of those.
Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
So that's the case I brought up at first and you said no to.
I think I don't understand this part.
You're talking about a binary that runs on more than one dissimilar SoC, yes?
Quoted 6 lines
Quoted 5 lines
I don't
see that in the foreseeable future but I don't feel so strongly about making this config area tidy enough to argue the point. So fine, leave it as separate options, the default y if ... is reasonable enough to ensure we get functional builds.
Quoted 3 lines
Quoted 1 line
This patch is OK as-is.
Yes, since I'm no longer asking for changes to it, it's fine.
I don't see possible use case where the 3 drivers configurations can be activated at the same time, Except, as Marek indicated it, the same U-Boot binary compiled to be executed for several architecture (STM32, IMX, TEGRA).
But it is not possible (duplicate cote between arch) as each configuration is linked to archictecture variant (the synopsis IP is modified by SOC vendor).
For me it should be possible to change the config option to select,
even it is no more requested and the patch is OK as-is (I keep the possibility to have the 3 options activated).
Regards
Patrick
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
Quoted 61 lines · Patrick DELAUNAY
Hi,
Quoted 59 lines
From: Tom Rini <[email protected]>
Sent: mercredi 10 juin 2020 23:58Quoted 11 lines · Marek Vasut
Quoted 10 lines · Tom Rini
Quoted 9 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 7 lines · Marek Vasut
On 6/10/20 10:11 PM, Tom Rini wrote:
[...]Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
You mean be more like barebox and Linux where the board-specific stuff is kicked up one level and we have a more generic binary? I don't know and there's so much work that would be required before having to move this from a
Kconfigchoice to justKconfigoptions I don't see that as being arelevant question here.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Or did I misunderstand the question?
More like automatically have a
Kconfigoption generate it's_SPLand_TPLvariant.Ah. Well, that is rephrasing my first question. Would it ever make sense to have more than one of these enabled?
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
For some sort of universal SPL, maybe ?
So no, there's not a reason today then and it should be a choice.
Can you provide some more detailed explanation why we shouldn't generate
_SPLand_TPLvariants ofKconfigentries for allKconfigentries ? It would make things much simpler and permit configuring SPL/TPL the same way U-Boot is configured, with their ownset of options.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
In the context of this particular thread? I don't see how it's helpful to say 3 times that we're in fact building for Tegra or STM32 or SoCFPGA when you can't build something that runs on more
than one of those.
Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
In general.
Here I can imagine it is possible to build SoCFPGA+STM32 universal SD card image in fact.
So that's the case I brought up at first and you said no to.
I think I don't understand this part.
You're talking about a binary that runs on more than one dissimilar SoC, yes?
Quoted 7 lines
Quoted 5 lines
I don't
see that in the foreseeable future but I don't feel so strongly about making this config area tidy enough to argue the point. So fine, leave it as separate options, the default y if ... is reasonable enough to ensure we get functional builds.This patch is OK as-is.
Quoted 8 lines
Quoted 1 line
Yes, since I'm no longer asking for changes to it, it's fine.
I don't see possible use case where the 3 drivers configurations can be activated at the same time, Except, as Marek indicated it, the same U-Boot binary compiled to be executed for several architecture (STM32, IMX, TEGRA).
But it is not possible (duplicate cote between arch) as each configuration is linked to archictecture variant (the synopsis IP is modified by SOC vendor).
You can build Linux for all three and use the same zImage, so it should also be possible for U-Boot.
Quoted 2 lines
For me it should be possible to change the config option to select,
even it is no more requested and the patch is OK as-is (I keep the possibility to have the 3 options activated).
The patch is OK.
PATCH 1/1 net: dwc_eth_qos: add Kconfig option to select supported configuration
In reply to Patrick DelaunayQuoted 5 lines · Patrick Delaunay
Add configuration flag to select the supported dwc driver configuration:
-CONFIG_DWC_ETH_QOS_TEGRA186
-CONFIG_DWC_ETH_QOS_IMX
-CONFIG_DWC_ETH_QOS_STM32
Quoted 7 lines
See Linux driver ethernet/stmicro/stmmac and associated glue layers for other configuration examples.
This patch removes the not-selected compatibles and lets the linker remove the unused functions to reduce the size of the driver.
Signed-off-by Patrick Delaunay <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200805/9abe1301/attachment.sig>