Skip to contentSkip to conversation

drm/amdgpu: Reconfigure ULV for gfx9 server SKUs

PATCH In review Joseph Greathouse 2 participants 2 messages Jun 10, 2020 – Jun 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Reconfigure ULV for gfx9 server SKUs

SDMA ULV can benefit low-power modes, but can sometimes cause latency increases in small SDMA transfers. Server SKUs have a different trade-off space in this domain, so this configures the server SKUs' ULV hysteresis times differently than consumer SKUs'.

Change-Id Ifc33aa857714c4c209b19a5d44e0a05c478db195
---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 32 ++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +32 -0
index 2f1f47de9634..58382646d962 100644
@@ -505,6 +505,36 @@ static void sdma_v4_0_init_golden_registers(struct amdgpu_device *adev)
 	}
 }
 
+static void sdma_v4_0_setup_ulv(struct amdgpu_device *adev)
+{
+	int i;
+
+	/*
+	 * The only chips with SDMAv4 and ULV are VG10 and VG20.
+	 * Server SKUs take a different hysteresis setting from other SKUs.
+	 */
+	switch (adev->asic_type) {
+	case CHIP_VEGA10:
+		if (adev->pdev->device == 0x6860)
+			break;
+		return;
+	case CHIP_VEGA20:
+		if (adev->pdev->device == 0x66a1)
+			break;
+		return;
+	default:
+		return;
+	}
+
+	for (i = 0; i < adev->sdma.num_instances; i++) {
+		uint32_t temp;
+
+		temp = RREG32_SDMA(i, mmSDMA0_ULV_CNTL);
+		temp = REG_SET_FIELD(temp, SDMA0_ULV_CNTL, HYSTERESIS, 0x0);
+		WREG32_SDMA(i, mmSDMA0_ULV_CNTL, temp);
+	}
+}
+
 static int sdma_v4_0_init_inst_ctx(struct amdgpu_sdma_instance *sdma_inst)
 {
 	int err = 0;
@@ -1813,6 +1843,8 @@ static int sdma_v4_0_late_init(void *handle)
 		.cb = sdma_v4_0_process_ras_data_cb,
 	};
 
+	sdma_v4_0_setup_ulv(adev);
+
 	if (adev->sdma.funcs && adev->sdma.funcs->reset_ras_error_count)
 		adev->sdma.funcs->reset_ras_error_count(adev);
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

Regards,
Hawking

Sent from my iPhone

Quoted 71 lines · Joseph Greathouse

SDMA ULV can benefit low-power modes, but can sometimes cause latency increases in small SDMA transfers. Server SKUs have a different trade-off space in this domain, so this configures the server SKUs' ULV hysteresis times differently than consumer SKUs'.

Change-Id Ifc33aa857714c4c209b19a5d44e0a05c478db195

---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 32 ++++++++++++++++++++++++++

1 file changed, 32 insertions(+)
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +32 -0
index 2f1f47de9634..58382646d962 100644
@@ -505,6 +505,36 @@ static void sdma_v4_0_init_golden_registers(struct amdgpu_device *adev)
   }
 }
 
+static void sdma_v4_0_setup_ulv(struct amdgpu_device *adev)
+{
+    int i;
+
+    /*
+     * The only chips with SDMAv4 and ULV are VG10 and VG20.
+     * Server SKUs take a different hysteresis setting from other SKUs.
+     */
+    switch (adev->asic_type) {
+    case CHIP_VEGA10:
+        if (adev->pdev->device == 0x6860)
+            break;
+        return;
+    case CHIP_VEGA20:
+        if (adev->pdev->device == 0x66a1)
+            break;
+        return;
+    default:
+        return;
+    }
+
+    for (i = 0; i < adev->sdma.num_instances; i++) {
+        uint32_t temp;
+
+        temp = RREG32_SDMA(i, mmSDMA0_ULV_CNTL);
+        temp = REG_SET_FIELD(temp, SDMA0_ULV_CNTL, HYSTERESIS, 0x0);
+        WREG32_SDMA(i, mmSDMA0_ULV_CNTL, temp);
+    }
+}
+
 static int sdma_v4_0_init_inst_ctx(struct amdgpu_sdma_instance *sdma_inst)
 {
   int err = 0;
@@ -1813,6 +1843,8 @@ static int sdma_v4_0_late_init(void *handle)
       .cb = sdma_v4_0_process_ras_data_cb,
   };
 
+    sdma_v4_0_setup_ulv(adev);
+
   if (adev->sdma.funcs && adev->sdma.funcs->reset_ras_error_count)
       adev->sdma.funcs->reset_ras_error_count(adev);
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Chawking.zhang%40amd.com%7Cb638f4e1666c4aaca19d08d80d9508d8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637274281787658422&amp;sdata=QZslek%2BJvlifGnGWrrJu%2BwBjj93ew0NvCgUUm9TPNEg%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx