Skip to contentSkip to conversation

drivers/acpi/osl.c:1608 acpi_release_memory() warn: ignoring unreachable code.

PATCH New Dan Carpenter 1 participant 1 message Jun 11, 2020 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 drivers/acpi/osl.c:1608 acpi_release_memory() warn: ignoring unreachable code.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git acpica-osl
head:   3537ee81aa84bbcf47f7239f1053686d71bea47d
commit: 3537ee81aa84bbcf47f7239f1053686d71bea47d [3/3] ACPI: OSL: Define ACPI_OS_MAP_MEMORY_FAST_PATH()
config: i386-randconfig-m021-20200611 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/acpi/osl.c:1608 acpi_release_memory() warn: ignoring unreachable code.

# https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=3537ee81aa84bbcf47f7239f1053686d71bea47d
git remote add pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
git remote update pm
git checkout 3537ee81aa84bbcf47f7239f1053686d71bea47d
vim +1608 drivers/acpi/osl.c

d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1599  acpi_status acpi_release_memory(acpi_handle handle, struct resource *res,
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1600  				u32 level)
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1601  {
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1602  	if (!(res->flags & IORESOURCE_MEM))
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1603  		return AE_TYPE;
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1604  
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1605  	return acpi_walk_namespace(ACPI_TYPE_REGION, handle, level,
                                                        ^^^^^^

d2d2e3c46be5d6 Heikki Krogerus 2018-06-21 1606 acpi_deactivate_mem_region, NULL, res, NULL);
3537ee81aa84bb Rafael J. Wysocki 2020-06-10 1607

3537ee81aa84bb Rafael J. Wysocki 2020-06-10 @1608  	acpi_release_unused_memory_mappings();
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Unreachable.

d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1609  }
d2d2e3c46be5d6 Heikki Krogerus   2018-06-21  1610  EXPORT_SYMBOL_GPL(acpi_release_memory);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org