pwm: fsl-ftm: Use flat regmap cache
PATCH 1/1 pwm: fsl-ftm: Use flat regmap cache
From: Stefan Agner <[email protected]>
commit ad06fdeeef1cbadf86ebbe510e8079abada8b44e upstream.
Use flat regmap cache to avoid lockdep warning at probe:
[ 0.697285] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2755 lockdep_trace_alloc+0x15c/0x160() [ 0.697449] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))
The RB-tree regmap cache needs to allocate new space on first writes. However, allocations in an atomic context (e.g. when a spinlock is held) are not allowed. The function regmap_write calls map->lock, which acquires a spinlock in the fast_io case. Since the pwm-fsl-ftm driver uses MMIO, the regmap bus of type regmap_mmio is being used which has fast_io set to true.
The MMIO space of the pwm-fsl-ftm driver is reasonable condense, hence using the much faster flat regmap cache is anyway the better choice.
---
Fixes lockdep warning. Apply to v4.4 and newer.
--- drivers/pwm/pwm-fsl-ftm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-fsl-ftm.c +1 -1
@@ -392,7 +392,7 @@ static const struct regmap_config fsl_pwm_regmap_config = { .max_register = FTM_PWMLOAD, .volatile_reg = fsl_pwm_volatile_reg, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_FLAT, };static int fsl_pwm_probe (struct platform_device *pdev)
Signature · 1 line
2.17.1
Quoted 47 lines · Krzysztof Kozlowski
From: Stefan Agner <[email protected]>
commit
ad06fdeeef1cbadf86ebbe510e8079abada8b44eupstream.Use flat regmap cache to avoid lockdep warning at probe:
[ 0.697285] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2755 lockdep_trace_alloc+0x15c/0x160() [ 0.697449] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))The RB-tree regmap cache needs to allocate new space on first writes. However, allocations in an atomic context (e.g. when a spinlock is held) are not allowed. The function
regmap_writecallsmap->lock, which acquires a spinlock in thefast_iocase. Since the pwm-fsl-ftm driver uses MMIO, the regmap bus of typeregmap_mmiois being used which hasfast_ioset to true.The MMIO space of the pwm-fsl-ftm driver is reasonable condense, hence using the much faster flat regmap cache is anyway the better choice.
Signed-off-by Stefan Agner <[email protected]>Cc Mark Brown <[email protected]>Signed-off-by Thierry Reding <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>---
Fixes lockdep warning. Apply to v4.4 and newer.
--- drivers/pwm/pwm-fsl-ftm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pwm/pwm-fsl-ftm.c +1
-1@@ -392,7 +392,7 @@ static const struct regmap_config fsl_pwm_regmap_config = { .max_register = FTM_PWMLOAD, .volatile_reg = fsl_pwm_volatile_reg, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_FLAT, };static int fsl_pwm_probe (struct platform_device *pdev)Signature · 1 line
2.17.1
Now queued up, thanks.
greg k-h