Skip to contentSkip to conversation

i2c: Use separate MODULE_AUTHOR() statements for multiple authors

PATCH Applied Jarkko Nikula 3 participants 3 messages Jun 11, 2020 – Jul 4, 2020

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i2c: Use separate MODULE_AUTHOR() statements for multiple authors

Modules with multiple authors should use multiple MODULE_AUTHOR() statements according to comment in include/linux/module.h.

Split the i2c modules with multiple authors to use multiple MODULE_AUTHOR() statements.

---
v2: Jean Delvare noticed i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c were missing. Refer to module.h comment in commit log message.
I decided to change all these modules in one patch. I can split if needed.

---
 drivers/i2c/algos/i2c-algo-pca.c   | 4 ++--
 drivers/i2c/busses/i2c-ali1535.c   | 8 ++++----
 drivers/i2c/busses/i2c-ali15x3.c   | 6 +++---
 drivers/i2c/busses/i2c-emev2.c     | 3 ++-
 drivers/i2c/busses/i2c-i801.c      | 3 ++-
 drivers/i2c/busses/i2c-nomadik.c   | 3 ++-
 drivers/i2c/busses/i2c-piix4.c     | 4 ++--
 drivers/i2c/busses/i2c-pnx.c       | 3 ++-
 drivers/i2c/busses/i2c-sh_mobile.c | 3 ++-
 drivers/i2c/busses/i2c-sibyte.c    | 3 ++-
 drivers/i2c/busses/i2c-sirf.c      | 4 ++--
 drivers/i2c/busses/i2c-viapro.c    | 6 +++---
 drivers/i2c/i2c-dev.c              | 4 ++--
 13 files changed, 30 insertions(+), 24 deletions(-)
drivers/i2c/algos/i2c-algo-pca.c +2 -2
index 7f10312d1b88..8620963e442c 100644
@@ -541,8 +541,8 @@ int i2c_pca_add_numbered_bus(struct i2c_adapter *adap)
 }
 EXPORT_SYMBOL(i2c_pca_add_numbered_bus);
 
-MODULE_AUTHOR("Ian Campbell <[email protected]>, "
-	"Wolfram Sang <[email protected]>");
+MODULE_AUTHOR("Ian Campbell <[email protected]>");
+MODULE_AUTHOR("Wolfram Sang <[email protected]>");
 MODULE_DESCRIPTION("I2C-Bus PCA9564/PCA9665 algorithm");
 MODULE_LICENSE("GPL");
 
drivers/i2c/busses/i2c-ali1535.c +4 -4
index a43deea390f5..fb93152845f4 100644
@@ -519,9 +519,9 @@ static struct pci_driver ali1535_driver = {
 
 module_pci_driver(ali1535_driver);
 
-MODULE_AUTHOR("Frodo Looijaard <[email protected]>, "
-	      "Philip Edelbrock <[email protected]>, "
-	      "Mark D. Studebaker <[email protected]> "
-	      "and Dan Eaton <[email protected]>");
+MODULE_AUTHOR("Frodo Looijaard <[email protected]>");
+MODULE_AUTHOR("Philip Edelbrock <[email protected]>");
+MODULE_AUTHOR("Mark D. Studebaker <[email protected]>");
+MODULE_AUTHOR("Dan Eaton <[email protected]>");
 MODULE_DESCRIPTION("ALI1535 SMBus driver");
 MODULE_LICENSE("GPL");
drivers/i2c/busses/i2c-ali15x3.c +3 -3
index 02185a1cfa77..cc58feacd082 100644
@@ -502,8 +502,8 @@ static struct pci_driver ali15x3_driver = {
 
 module_pci_driver(ali15x3_driver);
 
-MODULE_AUTHOR ("Frodo Looijaard <[email protected]>, "
-		"Philip Edelbrock <[email protected]>, "
-		"and Mark D. Studebaker <[email protected]>");
+MODULE_AUTHOR("Frodo Looijaard <[email protected]>");
+MODULE_AUTHOR("Philip Edelbrock <[email protected]>");
+MODULE_AUTHOR("Mark D. Studebaker <[email protected]>");
 MODULE_DESCRIPTION("ALI15X3 SMBus driver");
 MODULE_LICENSE("GPL");
drivers/i2c/busses/i2c-emev2.c +2 -1
index 1a319352e51b..a08554c1a570 100644
@@ -442,6 +442,7 @@ static struct platform_driver em_i2c_driver = {
 module_platform_driver(em_i2c_driver);
 
 MODULE_DESCRIPTION("EMEV2 I2C bus driver");
-MODULE_AUTHOR("Ian Molton and Wolfram Sang <[email protected]>");
+MODULE_AUTHOR("Ian Molton");
+MODULE_AUTHOR("Wolfram Sang <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DEVICE_TABLE(of, em_i2c_ids);
drivers/i2c/busses/i2c-i801.c +2 -1
index fea644921a76..1fc7ae77753d 100644
@@ -1986,7 +1986,8 @@ static void __exit i2c_i801_exit(void)
 	pci_unregister_driver(&i801_driver);
 }
 
-MODULE_AUTHOR("Mark D. Studebaker <[email protected]>, Jean Delvare <[email protected]>");
+MODULE_AUTHOR("Mark D. Studebaker <[email protected]>");
+MODULE_AUTHOR("Jean Delvare <[email protected]>");
 MODULE_DESCRIPTION("I801 SMBus driver");
 MODULE_LICENSE("GPL");
 
drivers/i2c/busses/i2c-nomadik.c +2 -1
index e1e8d4ef9aa7..d4b1b0865f67 100644
@@ -1122,6 +1122,7 @@ static void __exit nmk_i2c_exit(void)
 subsys_initcall(nmk_i2c_init);
 module_exit(nmk_i2c_exit);
 
-MODULE_AUTHOR("Sachin Verma, Srinidhi KASAGAR");
+MODULE_AUTHOR("Sachin Verma");
+MODULE_AUTHOR("Srinidhi KASAGAR");
 MODULE_DESCRIPTION("Nomadik/Ux500 I2C driver");
 MODULE_LICENSE("GPL");
drivers/i2c/busses/i2c-piix4.c +2 -2
index 69740a4ff1db..8c1b31ed0c42 100644
@@ -1032,7 +1032,7 @@ static struct pci_driver piix4_driver = {
 
 module_pci_driver(piix4_driver);
 
-MODULE_AUTHOR("Frodo Looijaard <[email protected]> and "
-		"Philip Edelbrock <[email protected]>");
+MODULE_AUTHOR("Frodo Looijaard <[email protected]>");
+MODULE_AUTHOR("Philip Edelbrock <[email protected]>");
 MODULE_DESCRIPTION("PIIX4 SMBus driver");
 MODULE_LICENSE("GPL");
drivers/i2c/busses/i2c-pnx.c +2 -1
index 5d7207c10f1d..8c4ec7f13f5a 100644
@@ -781,7 +781,8 @@ static void __exit i2c_adap_pnx_exit(void)
 	platform_driver_unregister(&i2c_pnx_driver);
 }
 
-MODULE_AUTHOR("Vitaly Wool, Dennis Kovalev <[email protected]>");
+MODULE_AUTHOR("Vitaly Wool");
+MODULE_AUTHOR("Dennis Kovalev <[email protected]>");
 MODULE_DESCRIPTION("I2C driver for Philips IP3204-based I2C busses");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:pnx-i2c");
drivers/i2c/busses/i2c-sh_mobile.c +2 -1
index 2cca1b21e26e..cab725559999 100644
@@ -932,6 +932,7 @@ static void __exit sh_mobile_i2c_adap_exit(void)
 module_exit(sh_mobile_i2c_adap_exit);
 
 MODULE_DESCRIPTION("SuperH Mobile I2C Bus Controller driver");
-MODULE_AUTHOR("Magnus Damm and Wolfram Sang");
+MODULE_AUTHOR("Magnus Damm");
+MODULE_AUTHOR("Wolfram Sang");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:i2c-sh_mobile");
drivers/i2c/busses/i2c-sibyte.c +2 -1
index 9dcea2ba7168..8f71f01cb169 100644
@@ -180,6 +180,7 @@ static void __exit i2c_sibyte_exit(void)
 module_init(i2c_sibyte_init);
 module_exit(i2c_sibyte_exit);
 
-MODULE_AUTHOR("Kip Walker (Broadcom Corp.), Steven J. Hill <[email protected]>");
+MODULE_AUTHOR("Kip Walker (Broadcom Corp.)");
+MODULE_AUTHOR("Steven J. Hill <[email protected]>");
 MODULE_DESCRIPTION("SMBus adapter routines for SiByte boards");
 MODULE_LICENSE("GPL");
drivers/i2c/busses/i2c-sirf.c +2 -2
index d7f72ec331e8..30db8fafe078 100644
@@ -470,6 +470,6 @@ static struct platform_driver i2c_sirfsoc_driver = {
 module_platform_driver(i2c_sirfsoc_driver);
 
 MODULE_DESCRIPTION("SiRF SoC I2C master controller driver");
-MODULE_AUTHOR("Zhiwu Song <[email protected]>, "
-	"Xiangzhen Ye <[email protected]>");
+MODULE_AUTHOR("Zhiwu Song <[email protected]>");
+MODULE_AUTHOR("Xiangzhen Ye <[email protected]>");
 MODULE_LICENSE("GPL v2");
drivers/i2c/busses/i2c-viapro.c +3 -3
index 4abc7771af06..05aa92a3fbe0 100644
@@ -489,9 +489,9 @@ static void __exit i2c_vt596_exit(void)
 	}
 }
 
-MODULE_AUTHOR("Kyosti Malkki <[email protected]>, "
-	      "Mark D. Studebaker <[email protected]> and "
-	      "Jean Delvare <[email protected]>");
+MODULE_AUTHOR("Kyosti Malkki <[email protected]>");
+MODULE_AUTHOR("Mark D. Studebaker <[email protected]>");
+MODULE_AUTHOR("Jean Delvare <[email protected]>");
 MODULE_DESCRIPTION("vt82c596 SMBus driver");
 MODULE_LICENSE("GPL");
 
drivers/i2c/i2c-dev.c +2 -2
index da020acc9bbd..6ceb11cc4be1 100644
@@ -761,8 +761,8 @@ static void __exit i2c_dev_exit(void)
 	unregister_chrdev_region(MKDEV(I2C_MAJOR, 0), I2C_MINORS);
 }
 
-MODULE_AUTHOR("Frodo Looijaard <[email protected]> and "
-		"Simon G. Vogl <[email protected]>");
+MODULE_AUTHOR("Frodo Looijaard <[email protected]>");
+MODULE_AUTHOR("Simon G. Vogl <[email protected]>");
 MODULE_DESCRIPTION("I2C /dev entries driver");
 MODULE_LICENSE("GPL");
 
Signature · 1 line
2.26.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 26 lines · Jarkko Nikula

Modules with multiple authors should use multiple MODULE_AUTHOR() statements according to comment in include/linux/module.h.

Split the i2c modules with multiple authors to use multiple MODULE_AUTHOR() statements.

---
v2: Jean Delvare noticed i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c were missing. Refer to module.h comment in commit log message.
I decided to change all these modules in one patch. I can split if needed.

---
 drivers/i2c/algos/i2c-algo-pca.c   | 4 ++--
 drivers/i2c/busses/i2c-ali1535.c   | 8 ++++----
 drivers/i2c/busses/i2c-ali15x3.c   | 6 +++---
 drivers/i2c/busses/i2c-emev2.c     | 3 ++-
 drivers/i2c/busses/i2c-i801.c      | 3 ++-
 drivers/i2c/busses/i2c-nomadik.c   | 3 ++-
 drivers/i2c/busses/i2c-piix4.c     | 4 ++--
 drivers/i2c/busses/i2c-pnx.c       | 3 ++-
 drivers/i2c/busses/i2c-sh_mobile.c | 3 ++-
 drivers/i2c/busses/i2c-sibyte.c    | 3 ++-
 drivers/i2c/busses/i2c-sirf.c      | 4 ++--
 drivers/i2c/busses/i2c-viapro.c    | 6 +++---
 drivers/i2c/i2c-dev.c              | 4 ++--
 13 files changed, 30 insertions(+), 24 deletions(-)
Quoted 1 line

(...)

Signature · 2 lines
Jean Delvare
SUSE L3 Support
Applied
#2 lore raw
In reply to Jarkko Nikula
Quoted 7 lines · Jarkko Nikula

Modules with multiple authors should use multiple MODULE_AUTHOR() statements according to comment in include/linux/module.h.

Split the i2c modules with multiple authors to use multiple MODULE_AUTHOR() statements.

Applied to for-next, thanks!