ip address: Fix loop initial declarations are only allowed in C99
Subsystems (2)
PATCH 1/1 ip address: Fix loop initial declarations are only allowed in C99
On some distros, i.e. rhel 7.6, compilation fails with the following:
ipaddress.c: In function ‘lookup_flag_data_by_name’:
ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (int i = 0; i < ARRAY_SIZE(ifa_flag_data); ++i) {
^
ipaddress.c:1260:2: note: use option -std=c99 or -std=gnu99 to compile your code
This commit fixes the single place needed for compilation to pass.
--- ip/ipaddress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
ip/ipaddress.c +3 -1
@@ -1257,7 +1257,9 @@ static const struct ifa_flag_data_t {/* Returns a pointer to the data structure for a particular interface flag, or null if no flag could be found */ static const struct ifa_flag_data_t *lookup_flag_data_by_name (const char * flag_name) { -for (int i =0 ; i <ARRAY_SIZE (ifa_flag_data); ++i) { +unsigned int i; + +for (i =0 ; i <ARRAY_SIZE (ifa_flag_data); ++i) {if (strcmp (flag_name, ifa_flag_data[i].name) ==0 )return &ifa_flag_data[i]; }
Signature · 1 line
2.8.4
Quoted 8 lines · On Thu, 11 Jun 2020 20:35:43 +0300 Roi Dayan <[email protected]> wrote:
On some distros, i.e. rhel 7.6, compilation fails with the following:
ipaddress.c: In function ‘lookup_flag_data_by_name’:
ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (int i = 0; i <ARRAY_SIZE(ifa_flag_data); ++i) {
^
ipaddress.c:1260:2: note: use option -std=c99 or -std=gnu99 to compile your code
Quoted 4 lines
This commit fixes the single place needed for compilation to pass.
Fixes 9d59c86e575b ("iproute2: ip addr: Organize flag properties structurally")Signed-off-by Roi Dayan <[email protected]>
Agree.
Applied