checkpatch.pl: perform commit ID check from external to git folder
PATCH 1/1 checkpatch.pl: perform commit ID check from external to git folder
From: Leon Romanovsky <[email protected]>
The execution of scripts/checkpatch.pl in folder outside of git produces complains about invalid commit ID, despite having valid one.
➜ /tmp /home/leonro/src/kernel/scripts/checkpatch.pl \ --root=/home/leonro/src/kernel \ --color=always \ --summary-file /tmp/0001-RDMA-core-Annotate-CMA-unlock-helper-routine.patch
WARNING: Unknown commit id 'e83f195aa45c', maybe rebased or not pulled?
/tmp/0001-RDMA-core-Annotate-CMA-unlock-helper-routine.patch total: 0 errors, 1 warnings, 7 lines checked
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
@@ -966,7 +966,7 @@ sub seed_camelcase_includes { sub git_commit_info { my ($commit, $id, $desc) = @_; - return ($id, $desc) if ((which("git") eq "") || !(-e ".git")); + return ($id, $desc) if ((which("git") eq "") || !(-e "$root/.git")); my $output = `${git_command} log --no-color --format='%H %s' -1 $commit 2>&1`; $output =~ s/^\s*//gm;
--
2.26.2
Joe Perches
maintainerQuoted 4 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The execution of
scripts/checkpatch.plin folder outside of git produces complains about invalid commit ID, despite having valid one.
There is already a slightly different test for this in -next It also uses a environment test for GIT_DIR.
Try that one.
Quoted 8 lines · Joe Perches
Quoted 4 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The execution of
scripts/checkpatch.plin folder outside of git produces complains about invalid commit ID, despite having valid one.There is already a slightly different test for this in -next It also uses a environment test for
GIT_DIR.
If you are referring to this commit
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/scripts/checkpatch.pl?h=next-20200611&id=5bff933936a76a839e3c7f47f193cbf0d9904543
It didn't work for me, because I'm not setting GIT_DIR environment and use "--root" switch from checkpatch.pl.
Quoted 2 lines
Try that one.
It doesn't make too much sense to have two options to configure git directory, one is GIT_DIR and another --root.
Thanks