Skip to contentSkip to conversation

common/dmthin: modify DMTHIN_POOL_NAME

PATCH New Jeffle Xu 1 participant 1 message Jun 12, 2020

lore
Share & tools
lore

Jeffle Xu

author
#0 lore raw

PATCH 1/1 common/dmthin: modify DMTHIN_POOL_NAME

_dmthin_set_queue() gets $cluster_size by 'dmsetup table | grep $DMTHIN_POOL_NAME'. The original name 'thin-pool' is accidently the same as the fourth field of the output of 'dmsetup table'.

For example,
vg-pool-tpool: 0 64864256 thin-pool 252:0 252:1 128 0 0

Thus if there is other thin-pool in the test environment, except for the thin-pool created by _dmthin_init(), the parsed $cluster_size may be a multi-line string, which is unexpected.

This issue caused a failure of generic/347 and generic/500, while the dmesg reports 'Invalid argument count'.

---
 common/dmthin | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/dmthin +1 -1
index 61dd6f89..c58c3948 100644
@@ -15,7 +15,7 @@ DMTHIN_DATA_DEV="/dev/mapper/$DMTHIN_DATA_NAME"
 DMTHIN_META_NAME="thin-meta"
 DMTHIN_META_DEV="/dev/mapper/$DMTHIN_META_NAME"
 # Backing pool dev (combination of above)
-DMTHIN_POOL_NAME="thin-pool"
+DMTHIN_POOL_NAME="thin-provision-pool"
 DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
 # Thin volume
 DMTHIN_VOL_NAME="thin-vol"
Signature · 1 line
2.27.0