drm/msm: Fix memory leak in msm_submitqueue_create()
Quoted 4 lines
In fucntin
msm_submitqueue_create, the queue is a local variable, in return-EINVALbranch, queue didnt add to ctxs list yet, and also didn`t kfree, this maybe bring in potential memleak.
I suggest to improve also this change description. How do you think about a wording variant like the following?
Release the GPU submission queue object after an input parameter validation failed.
Would you like to add the tag “Fixes” to the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183
How do you think about to reorder any statements for this function implementation?
Regards,
Markus
Quoted 11 lines · Markus Elfring
Quoted 4 lines
In fucntin
msm_submitqueue_create, the queue is a local variable, in return-EINVALbranch, queue didnt add to ctxs list yet, and also didn`t kfree, this maybe bring in potential memleak.I suggest to improve also this change description. How do you think about a wording variant like the following?
Release the GPU submission queue object after an input parameter validation failed.
Quoted 8 lines
Would you like to add the tag “Fixes” to the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183How do you think about to reorder any statements for this function implementation?
Regards,
Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them.
thanks,
greg k-h's patch email bot
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel