Skip to contentSkip to conversation

Calculate SDRAM size for Actions OWL SoCs

PATCH Superseded Amit Singh Tomar 3 participants 9 messages May 9, 2020 – Jul 8, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v4 cover Calculate SDRAM size for Actions OWL SoCs

Mani pointed out that changes in previous version were not good enough for S900 and he provide snippet that seems to work on S900.

This series v4 fixes the S900 Support by taking in changes suggested by Mani.

---------------------------------------------------------------------

Realized that sent the wrong version(v2) that has typos and didn't get compile for S900. Just fixed this in v3.

This small series allows us to calculate SDRAM size instead of guessing it.

Patch (1/2) is re-worked to support S900 SoC along with S700.

These changes have been tested on S700 based Cubieboard7-lite board, and it would be great if this can be tested on S900.

Amit Singh Tomar (2):
Actions: OWL: Calculate SDRAM size
arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

 arch/arm/mach-owl/soc.c      | 22 +++++++++++++++++++++-
 include/configs/owl-common.h |  1 -
 2 files changed, 21 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH v4 1/2 Actions: OWL: Calculate SDRAM size

Calculate the SDRAM size from DDR capacity register registers instead of using hard-coded value. This is quite useful to get correct size on differnt boards based on Actions OWL family of SoCs (S700 and S900).

There is no documentation available that talks about DDR registers, and this is very much taken from vendor source.

This commit lets Linux boot on Cubieboard7-lite(based on S700).

---
Changes since v3:
* Fixed S900 support as suggested by Mani.
* Changes the function name to owl_get_ddrcap.
Changes since v2:

	* Fixed the variable name so that it can compile
	  for S900.	

Changes since v1:
* added support for S900
* updated the commit message to reflect common OWL support.

---
 arch/arm/mach-owl/soc.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
arch/arm/mach-owl/soc.c +21 -1
index 409cbd319f20..fcf61d39b63a 100644
@@ -13,14 +13,34 @@
 #include <asm/mach-types.h>
 #include <asm/psci.h>
 
+#define DMM_INTERLEAVE_PER_CH_CFG	0xe0290028
+
 DECLARE_GLOBAL_DATA_PTR;
 
+unsigned int owl_get_ddrcap(void)
+{
+	unsigned int val, cap;
+
+	/* ddr capacity register initialized by ddr driver
+	 * in early bootloader
+	 */
+#if defined(CONFIG_MACH_S700)
+	val = (readl(DMM_INTERLEAVE_PER_CH_CFG) >> 8) & 0x7;
+	cap =  (val + 1) * 256;
+#elif defined(CONFIG_MACH_S900)
+	val = (readl(DMM_INTERLEAVE_PER_CH_CFG) >> 8) & 0xf;
+	cap =  64 * (1 << val);
+#endif
+
+	return cap;
+}
+
 /*
  * dram_init - sets uboots idea of sdram size
  */
 int dram_init(void)
 {
-	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
+	gd->ram_size = owl_get_ddrcap() * 1024 * 1024;
 	return 0;
 }
 
Signature · 1 line
2.7.4
#2 lore raw

PATCH v4 1/2 Actions: OWL: Calculate SDRAM size

Quoted 10 lines · Amit Singh Tomar

Calculate the SDRAM size from DDR capacity register registers instead of using hard-coded value. This is quite useful to get correct size on differnt boards based on Actions OWL family of SoCs (S700 and S900).

There is no documentation available that talks about DDR registers, and this is very much taken from vendor source.

This commit lets Linux boot on Cubieboard7-lite(based on S700).

Thanks,
Mani

Quoted 58 lines

---
Changes since v3:
* Fixed S900 support as suggested by Mani.
* Changes the function name to owl_get_ddrcap.
Changes since v2:

	* Fixed the variable name so that it can compile
	  for S900.	

Changes since v1:
* added support for S900
* updated the commit message to reflect common OWL support.

---
 arch/arm/mach-owl/soc.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
arch/arm/mach-owl/soc.c +21 -1
index 409cbd319f20..fcf61d39b63a 100644
@@ -13,14 +13,34 @@
 #include <asm/mach-types.h>
 #include <asm/psci.h>
 
+#define DMM_INTERLEAVE_PER_CH_CFG	0xe0290028
+
 DECLARE_GLOBAL_DATA_PTR;
 
+unsigned int owl_get_ddrcap(void)
+{
+	unsigned int val, cap;
+
+	/* ddr capacity register initialized by ddr driver
+	 * in early bootloader
+	 */
+#if defined(CONFIG_MACH_S700)
+	val = (readl(DMM_INTERLEAVE_PER_CH_CFG) >> 8) & 0x7;
+	cap =  (val + 1) * 256;
+#elif defined(CONFIG_MACH_S900)
+	val = (readl(DMM_INTERLEAVE_PER_CH_CFG) >> 8) & 0xf;
+	cap =  64 * (1 << val);
+#endif
+
+	return cap;
+}
+
 /*
  * dram_init - sets uboots idea of sdram size
  */
 int dram_init(void)
 {
-	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
+	gd->ram_size = owl_get_ddrcap() * 1024 * 1024;
 	return 0;
 }
 
Signature · 1 line
2.7.4
#3 lore raw

PATCH v4 1/2 Actions: OWL: Calculate SDRAM size

In reply to Amit Singh Tomar
Quoted 11 lines · Amit Singh Tomar

Calculate the SDRAM size from DDR capacity register registers instead of using hard-coded value. This is quite useful to get correct size on differnt boards based on Actions OWL family of SoCs (S700 and S900).

There is no documentation available that talks about DDR registers, and this is very much taken from vendor source.

This commit lets Linux boot on Cubieboard7-lite(based on S700).

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200707/59dfc2c9/attachment.sig>
#4 lore raw

PATCH v4 2/2 arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

In reply to Amit Singh Tomar

Now that, we calculate SDRAM size by reading DDR registers, "CONFIG_SYS_SDRAM_SIZE" is no more needed.

This commit removes "CONFIG_SYS_SDRAM_SIZE" from common configuration file.

---
* No change since previous version.

---
 include/configs/owl-common.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/owl-common.h +0 -1
index f77a5fa4c114..7634578f856d 100644
@@ -12,7 +12,6 @@
 
 /* SDRAM Definitions */
 #define CONFIG_SYS_SDRAM_BASE		0x0
-#define CONFIG_SYS_SDRAM_SIZE		0x80000000
 
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		(24000000)	/* 24MHz */
Signature · 1 line
2.7.4
#5 lore raw

PATCH v4 2/2 arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

Quoted 7 lines · Amit Singh Tomar

Now that, we calculate SDRAM size by reading DDR registers, "CONFIG_SYS_SDRAM_SIZE" is no more needed.

This commit removes "CONFIG_SYS_SDRAM_SIZE" from common configuration file.

Thanks,
Mani

Quoted 21 lines

---
* No change since previous version.

---
 include/configs/owl-common.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/owl-common.h +0 -1
index f77a5fa4c114..7634578f856d 100644
@@ -12,7 +12,6 @@
 
 /* SDRAM Definitions */
 #define CONFIG_SYS_SDRAM_BASE		0x0
-#define CONFIG_SYS_SDRAM_SIZE		0x80000000
 
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		(24000000)	/* 24MHz */
Signature · 1 line
2.7.4
#6 lore raw

PATCH v4 2/2 arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

In reply to Amit Singh Tomar
Quoted 8 lines · Amit Singh Tomar

Now that, we calculate SDRAM size by reading DDR registers, "CONFIG_SYS_SDRAM_SIZE" is no more needed.

This commit removes "CONFIG_SYS_SDRAM_SIZE" from common configuration file.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200707/14cefda9/attachment.sig>
author
#7 lore raw

v4 cover Calculate SDRAM size for Actions OWL SoCs

In reply to Amit Singh Tomar

Hi Tom

Quoted 24 lines · Amit Singh Tomar

Mani pointed out that changes in previous version were not good enough for S900 and he provide snippet that seems to work on S900.

This series v4 fixes the S900 Support by taking in changes suggested by Mani.

---------------------------------------------------------------------

Realized that sent the wrong version(v2) that has typos and didn't get compile for S900. Just fixed this in v3.

This small series allows us to calculate SDRAM size instead of guessing it.

Patch (1/2) is re-worked to support S900 SoC along with S700.

These changes have been tested on S700 based Cubieboard7-lite board, and it would be great if this can be tested on S900.

Amit Singh Tomar (2):
Actions: OWL: Calculate SDRAM size
arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

Quoted 7 lines
 arch/arm/mach-owl/soc.c      | 22 +++++++++++++++++++++-
 include/configs/owl-common.h |  1 -
 2 files changed, 21 insertions(+), 2 deletions(-)

--
2.7.4

Do you have a plan to take these in ?

Thanks
-Amit.

#8 lore raw

v4 cover Calculate SDRAM size for Actions OWL SoCs

Quoted 31 lines · Amit Tomer

Hi Tom

Quoted 28 lines · Amit Singh Tomar

Mani pointed out that changes in previous version were not good enough for S900 and he provide snippet that seems to work on S900.

This series v4 fixes the S900 Support by taking in changes suggested by Mani.

---------------------------------------------------------------------

Realized that sent the wrong version(v2) that has typos and didn't get compile for S900. Just fixed this in v3.

This small series allows us to calculate SDRAM size instead of guessing it.

Patch (1/2) is re-worked to support S900 SoC along with S700.

These changes have been tested on S700 based Cubieboard7-lite board, and it would be great if this can be tested on S900.

Amit Singh Tomar (2):
Actions: OWL: Calculate SDRAM size
arm: actions: remove "CONFIG_SYS_SDRAM_SIZE" for Actions Owl Semi SoCs

 arch/arm/mach-owl/soc.c      | 22 +++++++++++++++++++++-
 include/configs/owl-common.h |  1 -
 2 files changed, 21 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 3 lines

--
2.7.4

Do you have a plan to take these in ?

Of what I call from the thread, it's OK for this to go in for v2020.07 so it's on my TODO list for -next but only part of the queue of hopefully easy to grab and use things, which isn't where I start :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/82143aff/attachment.sig>