Skip to contentSkip to conversation

drm/msm: Fix 0xfffflub in "Refactor address space initialization"

PATCH New John Stultz 1 participant 1 message Jun 13, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm: Fix 0xfffflub in "Refactor address space initialization"

This week I started seeing GPU crashes on my DragonBoard 845c which I narrowed down to being caused by commit ccac7ce373c1 ("drm/msm: Refactor address space initialization").

Looking through the patch, Jordan and I couldn't find anything obviously wrong, so I ended up breaking that change up into a number of smaller logical steps so I could figure out which part was causing the trouble.

Ends up, visually counting 'f's is hard, esp across a number of lines:
0xfffffff != 0xffffffff

This patch corrects the end value we pass in to msm_gem_address_space_create() in adreno_iommu_create_address_space() so that it matches the value used before the problematic patch landed.

With this change, I no longer see the GPU crashes that were affecting me.

Cc Shawn Guo <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc Jordan Crouse <[email protected]>
Fixes ccac7ce373c1 ("drm/msm: Refactor address space initialization")
---
 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +1 -1
index 89673c7ed473..3d4efe684a98 100644
@@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,
 	struct msm_gem_address_space *aspace;
 
 	aspace = msm_gem_address_space_create(mmu, "gpu", SZ_16M,
-		0xfffffff);
+		0xffffffff);
 
 	if (IS_ERR(aspace) && !IS_ERR(mmu))
 		mmu->funcs->destroy(mmu);
Signature · 1 line
2.17.1