drm/vc4: fix ref count leak in vc4_vec_encoder_enable
Subsystems (3)
PATCH 1/1 drm/vc4: fix ref count leak in vc4_vec_encoder_enable
in vc4_vec_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/gpu/drm/vc4/vc4_vec.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/vc4/vc4_vec.c +5 -3
@@ -406,7 +406,7 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder) ret =pm_runtime_get_sync (&vec->pdev->dev);if (ret <0 ) {DRM_ERROR ("Failed to retain power domain: %d\n" , ret); -return ; + goto out; }/*
@@ -419,13 +419,13 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder) ret =clk_set_rate (vec->clock,108000000 );if (ret) {DRM_ERROR ("Failed to set clock rate: %d\n" , ret); -return ; + goto out; } ret =clk_prepare_enable (vec->clock);if (ret) {DRM_ERROR ("Failed to turn on core clock: %d\n" , ret); -return ; + goto out; }/* Reset the different blocks */
@@ -464,6 +464,8 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder)VEC_WRITE (VEC_DAC_MISC ,VEC_DAC_MISC_VID_ACT |VEC_DAC_MISC_DAC_RST_N );VEC_WRITE (VEC_CFG ,VEC_CFG_VEC_EN ); +out: +pm_runtime_put (&vec->pdev->dev); }
Signature · 1 line
2.17.1