Skip to contentSkip to conversation

package/kodi-pvr-vuplus: remove tinyxml dependency

PATCH New Bernd Kuhls 2 participants 2 messages Jun 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kodi-pvr-vuplus: remove tinyxml dependency

Package kodi-platform depends on kodi
https://github.com/xbmc/kodi-platform/blob/master/CMakeLists.txt#L8

which in turn depends on tinyxml
https://github.com/xbmc/xbmc/blob/Leia/CMakeLists.txt#L136

so we do not need to explicitly depend on tinyxml here.

---
 package/kodi-pvr-vuplus/Config.in          | 1 -
 package/kodi-pvr-vuplus/kodi-pvr-vuplus.mk | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
package/kodi-pvr-vuplus/Config.in +0 -1
index b6a03e843f..4989b1c77c 100644
@@ -3,7 +3,6 @@ config BR2_PACKAGE_KODI_PVR_VUPLUS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # json-for-modern-cpp
 	select BR2_PACKAGE_JSON_FOR_MODERN_CPP
 	select BR2_PACKAGE_KODI_PLATFORM
-	select BR2_PACKAGE_TINYXML
 	help
 	  VuPlus PVR client addon for Kodi
 
package/kodi-pvr-vuplus/kodi-pvr-vuplus.mk +1 -1
index bf1de1178d..32b6d939af 100644
@@ -8,6 +8,6 @@ KODI_PVR_VUPLUS_VERSION = 3.28.9-Leia
 KODI_PVR_VUPLUS_SITE = $(call github,kodi-pvr,pvr.vuplus,$(KODI_PVR_VUPLUS_VERSION))
 KODI_PVR_VUPLUS_LICENSE = GPL-2.0+
 KODI_PVR_VUPLUS_LICENSE_FILES = debian/copyright
-KODI_PVR_VUPLUS_DEPENDENCIES = json-for-modern-cpp kodi-platform tinyxml
+KODI_PVR_VUPLUS_DEPENDENCIES = json-for-modern-cpp kodi-platform
 
 $(eval $(cmake-package))
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/kodi-pvr-vuplus: remove tinyxml dependency

Bernd, All,

On 2020-06-14 16:32 +0200, Bernd Kuhls spake thusly:

Quoted 7 lines

Package kodi-platform depends on kodi
https://github.com/xbmc/kodi-platform/blob/master/CMakeLists.txt#L8

which in turn depends on tinyxml
https://github.com/xbmc/xbmc/blob/Leia/CMakeLists.txt#L136

so we do not need to explicitly depend on tinyxml here.

I disagree. If kodi one day stops depending on tinyxml, that would break the build of pvr-vuplus.

Since tinyxml *is* a dependency of pvr-vuplus we do want to keep it here.

Regards,
Yann E. MORIN.

Quoted 37 lines
---
 package/kodi-pvr-vuplus/Config.in          | 1 -
 package/kodi-pvr-vuplus/kodi-pvr-vuplus.mk | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
package/kodi-pvr-vuplus/Config.in +0 -1
index b6a03e843f..4989b1c77c 100644
@@ -3,7 +3,6 @@ config BR2_PACKAGE_KODI_PVR_VUPLUS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # json-for-modern-cpp
 	select BR2_PACKAGE_JSON_FOR_MODERN_CPP
 	select BR2_PACKAGE_KODI_PLATFORM
-	select BR2_PACKAGE_TINYXML
 	help
 	  VuPlus PVR client addon for Kodi
 
package/kodi-pvr-vuplus/kodi-pvr-vuplus.mk +1 -1
index bf1de1178d..32b6d939af 100644
@@ -8,6 +8,6 @@ KODI_PVR_VUPLUS_VERSION = 3.28.9-Leia
 KODI_PVR_VUPLUS_SITE = $(call github,kodi-pvr,pvr.vuplus,$(KODI_PVR_VUPLUS_VERSION))
 KODI_PVR_VUPLUS_LICENSE = GPL-2.0+
 KODI_PVR_VUPLUS_LICENSE_FILES = debian/copyright
-KODI_PVR_VUPLUS_DEPENDENCIES = json-for-modern-cpp kodi-platform tinyxml
+KODI_PVR_VUPLUS_DEPENDENCIES = json-for-modern-cpp kodi-platform
 
 $(eval $(cmake-package))
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'