Documentation/i2c: SMBus start signal is S not A
Subsystems (2)
PATCH 1/1 Documentation/i2c: SMBus start signal is S not A
From: Daniel Schaefer <[email protected]>
Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.
--- Documentation/i2c/smbus-protocol.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/i2c/smbus-protocol.rst +1 -1
@@ -57,7 +57,7 @@ SMBus Quick Command This sends a single bit to the device, at the place of the Rd/Wr bit:: - A Addr Rd/Wr [A] P + S Addr Rd/Wr [A] P Functionality flag: I2C_FUNC_SMBUS_QUICK
Signature · 1 line
2.25.1
Quoted 4 lines · On 6/14/20 8:23 PM, [email protected] wrote:
From: Daniel Schaefer <[email protected]>
Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.
Oops, should be 'not A' here, like in the commit title. Will you fix that up while applying please, or should I send a new patch?
Quoted 21 lines
Cc Wolfram Sang <[email protected]>Signed-off-by Daniel Schaefer <[email protected]>--- Documentation/i2c/smbus-protocol.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/i2c/smbus-protocol.rst +1
-1@@ -57,7 +57,7 @@ SMBus Quick Command This sends a single bit to the device, at the place of the Rd/Wr bit:: - A Addr Rd/Wr [A] P + S Addr Rd/Wr [A] P Functionality flag: I2C_FUNC_SMBUS_QUICK
Quoted 8 lines · Daniel Schäfer
Quoted 4 lines · On 6/14/20 8:23 PM, [email protected] wrote:
From: Daniel Schaefer <[email protected]>
Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.
Oops, should be 'not A' here, like in the commit title. Will you fix that up while applying please, or should I send a new patch?
I will fix it. And congrats for catching this typo which exists longer than the git history!
Wolfram Sang
AppliedQuoted 7 lines · On Sun, Jun 14, 2020 at 08:23:55PM +0200, [email protected] wrote:
From: Daniel Schaefer <[email protected]>
Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.
Cc Wolfram Sang <[email protected]>Signed-off-by Daniel Schaefer <[email protected]>
Applied to for-current, thanks!