Skip to contentSkip to conversation

Documentation/i2c: SMBus start signal is S not A

PATCH Applied [email protected] 3 participants 4 messages Jun 14, 2020 – Jun 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/i2c: SMBus start signal is S not A

From: Daniel Schaefer <[email protected]>

Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.

---
 Documentation/i2c/smbus-protocol.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/i2c/smbus-protocol.rst +1 -1
index c2e29633071e..64689d19dd51 100644
@@ -57,7 +57,7 @@ SMBus Quick Command
 
 This sends a single bit to the device, at the place of the Rd/Wr bit::
 
-  A Addr Rd/Wr [A] P
+  S Addr Rd/Wr [A] P
 
 Functionality flag: I2C_FUNC_SMBUS_QUICK
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 4 lines · On 6/14/20 8:23 PM, [email protected] wrote:

From: Daniel Schaefer <[email protected]>

Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.

Oops, should be 'not A' here, like in the commit title. Will you fix that up while applying please, or should I send a new patch?

Quoted 21 lines
---
 Documentation/i2c/smbus-protocol.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/i2c/smbus-protocol.rst +1 -1
index c2e29633071e..64689d19dd51 100644
@@ -57,7 +57,7 @@ SMBus Quick Command
 
 This sends a single bit to the device, at the place of the Rd/Wr bit::
 
-  A Addr Rd/Wr [A] P
+  S Addr Rd/Wr [A] P
 
 Functionality flag: I2C_FUNC_SMBUS_QUICK
 
#2 lore raw
Quoted 8 lines · Daniel Schäfer
Quoted 4 lines · On 6/14/20 8:23 PM, [email protected] wrote:

From: Daniel Schaefer <[email protected]>

Just like all other I2C/SMBus commands, the start signal for the SMBus Quick Command is S, not P.

Oops, should be 'not A' here, like in the commit title. Will you fix that up while applying please, or should I send a new patch?

I will fix it. And congrats for catching this typo which exists longer than the git history!