Btrfs: remove no longer used trans_list member of struct btrfs_ordered_extent
PATCH 2/2 Btrfs: remove no longer used trans_list member of struct btrfs_ordered_extent
From: Filipe Manana <[email protected]>
The 'trans_list' member of an ordered extent was used to keep track of the ordered extents for which a transaction commit had to wait. These were ordered extents that were started and logged by an fsync. However we don't do that anymore and before we stopped doing it we changed the approach to wait for the ordered extents in commit 161c3549b45aee ("Btrfs: change how we wait for pending ordered extents"), which stopped using that list and therefore the 'trans_list' member is not used anymore since that commit. So just remove it since it's doing nothing and making each ordered extent structure waste memory (2 pointers).
--- fs/btrfs/ordered-data.c | 2 -- fs/btrfs/ordered-data.h | 3 --- 2 files changed, 5 deletions(-)
fs/btrfs/ordered-data.c +0 -2
@@ -197,7 +197,6 @@ static int __btrfs_add_ordered_extent(struct inode *inode, u64 file_offset,INIT_LIST_HEAD (&entry->root_extent_list);INIT_LIST_HEAD (&entry->work_list);init_completion (&entry->completion); -INIT_LIST_HEAD (&entry->trans_list);trace_btrfs_ordered_extent_add (inode, entry);
@@ -428,7 +427,6 @@ void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry)trace_btrfs_ordered_extent_put (entry->inode, entry);if (refcount_dec_and_test (&entry->refs)) { -ASSERT (list_empty (&entry->trans_list));ASSERT (list_empty (&entry->root_extent_list));ASSERT (RB_EMPTY_NODE (&entry->rb_node));if (entry->inode)
fs/btrfs/ordered-data.h +0 -3
@@ -101,9 +101,6 @@ struct btrfs_ordered_extent {/* list of checksums for insertion when the extent io is done */ struct list_head list; -/* If the transaction needs to wait on this ordered extent */ -struct list_head trans_list; -/* used to wait for the BTRFS_ORDERED_COMPLETE bit */ wait_queue_head_t wait;
Signature · 1 line
2.26.2
Looks good,
Quoted 12 lines · On Mon, Jun 15, 2020 at 10:36:58AM +0100, [email protected] wrote:
From: Filipe Manana <[email protected]>
The '
trans_list' member of an ordered extent was used to keep track of the ordered extents for which a transaction commit had to wait. These were ordered extents that were started and logged by an fsync. However we don't do that anymore and before we stopped doing it we changed the approach to wait for the ordered extents in commit161c3549b45aee("Btrfs: change how we wait for pending ordered extents"), which stopped using that list and therefore the 'trans_list' member is not used anymore since that commit. So just remove it since it's doing nothing and making each ordered extent structure waste memory (2 pointers).
Quoted 1 line
Signed-off-by Filipe Manana <[email protected]>
Added to misc-next, thanks.