net: eth-uclass: Fix message if mac is coming from DT or ROM
PATCH 1/1 net: eth-uclass: Fix message if mac is coming from DT or ROM
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM.
---
net/eth-uclass.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/eth-uclass.c +4 -2
@@ -490,6 +490,7 @@ static int eth_post_probe(struct udevice *dev)struct eth_device_priv *priv = dev->uclass_priv;struct eth_pdata *pdata = dev->platdata;unsigned char env_enetaddr[ARP_HLEN ]; +char *source ="DT" ;#if defined(CONFIG_NEEDS_MANUAL_RELOC )struct eth_ops *ops =eth_get_ops (dev);
@@ -522,6 +523,7 @@ static int eth_post_probe(struct udevice *dev)/* Check if the device has a valid MAC address in device tree */ if (!eth_dev_get_mac_address (dev, pdata->enetaddr) || !is_valid_ethaddr (pdata->enetaddr)) { + source ="ROM" ;/* Check if the device has a MAC address in ROM */ if (eth_get_ops (dev)->read_rom_hwaddr)eth_get_ops (dev)->read_rom_hwaddr (dev);
@@ -543,8 +545,8 @@ static int eth_post_probe(struct udevice *dev)memcpy (pdata->enetaddr, env_enetaddr,ARP_HLEN ); }else if (is_valid_ethaddr (pdata->enetaddr)) {eth_env_set_enetaddr_by_index ("eth" , dev->seq, pdata->enetaddr); -printf ("\nWarning: %s using MAC address from ROM\n" , - dev->name); +printf ("\nWarning: %s using MAC address from %s\n" , + dev->name, source); }else if (is_zero_ethaddr (pdata->enetaddr) || !is_valid_ethaddr (pdata->enetaddr)) {#ifdef CONFIG_NET_RANDOM_ETHADDR
Signature · 1 line
2.25.1
PATCH 1/1 net: eth-uclass: Fix message if mac is coming from DT or ROM
Quoted 5 lines · Michal Simek
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM.
Signed-off-by Michal Simek <[email protected]>
In looking over the queue of networking patches, I think I prefer
http://patchwork.ozlabs.org/project/uboot/patch/20200611110321.9574-3-andre.przywara at arm.com/ which just removes the message entirely and is consistent with the
non-DM case.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200612/c9f0cd5c/attachment.sig>
PATCH 1/1 net: eth-uclass: Fix message if mac is coming from DT or ROM
Hi Tom,
Quoted 6 lines · Tom Rini
Quoted 4 lines · Michal Simek
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM.
Quoted 7 lines
Quoted 1 line
Signed-off-by Michal Simek <[email protected]>In looking over the queue of networking patches, I think I prefer
http://patchwork.ozlabs.org/project/uboot/patch/20200611110321.9574-3-andre.przywara at arm.com/ which just removes the message entirely and is consistent with the
non-DM case.
My patch is already in your tree. The patch you pointed me too is just removing one message.
Thanks,
Michal
PATCH 1/1 net: eth-uclass: Fix message if mac is coming from DT or ROM
Quoted 11 lines · Michal Simek
Hi Tom,
Quoted 8 lines · Tom Rini
Quoted 5 lines · Michal Simek
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM.
Signed-off-by Michal Simek <[email protected]>
Quoted 8 lines
Quoted 5 lines
In looking over the queue of networking patches, I think I prefer
http://patchwork.ozlabs.org/project/uboot/patch/20200611110321.9574-3-andre.przywara at arm.com/ which just removes the message entirely and is consistent with the
non-DM case.My patch is already in your tree. The patch you pointed me too is just removing one message.
Sigh, the number of times the patchwork scripts don't match commits to patch ids is frustrating at times.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200615/2dd95e97/attachment.sig>