Skip to contentSkip to conversation

bios-tables-test: Fix "-tpmdev: invalid option"

PATCH New Eric Auger 1 participant 1 message Jun 15, 2020

lore
Share & tools
lore

Eric Auger

author
#0 lore raw

PATCH v2 1/1 bios-tables-test: Fix "-tpmdev: invalid option"

When configure is run with "--disable-tpm", the bios-tables-test q35/tis test fails with "-tpmdev: invalid option".

Skip the test if CONFIG_TPM is unset.

---

v1 -> v2:
- collected R-bs, T-bs and added fix tag (Phil)

---
 tests/qtest/bios-tables-test.c | 4 ++++
 1 file changed, 4 insertions(+)
tests/qtest/bios-tables-test.c +4 -0
index 53f104a9c5..b482f76c03 100644
@@ -882,6 +882,7 @@ uint64_t tpm_tis_base_addr;
 static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
                               uint64_t base)
 {
+#ifdef CONFIG_TPM
     gchar *tmp_dir_name = g_strdup_printf("qemu-test_acpi_%s_tcg_%s.XXXXXX",
                                           machine, tpm_if);
     char *tmp_path = g_dir_make_tmp(tmp_dir_name, NULL);
@@ -924,6 +925,9 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
     g_free(tmp_path);
     g_free(tmp_dir_name);
     free_test_data(&data);
+#else
+    g_test_skip("TPM disabled");
+#endif
 }
 
 static void test_acpi_q35_tcg_tpm_tis(void)
Signature · 1 line
2.20.1