Skip to contentSkip to conversation

HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override

PATCH In review Federico Ricchiuto 3 participants 3 messages Jun 15, 2020 – Jun 16, 2020 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override

The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does not supply descriptors, so it has to be added to the override list.

---
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c +8 -0
index a66f08041a1a..bb3f802935cc 100644
@@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
 		},
 		.driver_data = (void *)&sipodev_desc
 	},
+	{
+		.ident = "Mediacom FlexBook edge 13",
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"),
+		},
+		.driver_data = (void *)&sipodev_desc
+	},
 	{
 		.ident = "Odys Winbook 13",
 		.matches = {
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 4 lines · Federico Ricchiuto

The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does not supply descriptors, so it has to be added to the override list.

It looks like you copied and pasted part of the commit message from another patch (which is fine), but you need to update the Subject (the first line of the commit message) the Subject now still mentions the Trekstor Surfbook E11B rather then the Mediacom FlexBook edge13.

Otherwise this looks good to me.

Regards,

Hans

Quoted 24 lines
---
  drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c +8 -0
index a66f08041a1a..bb3f802935cc 100644
@@ -373,6 +373,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = {
  		},
  		.driver_data = (void *)&sipodev_desc
  	},
+	{
+		.ident = "Mediacom FlexBook edge 13",
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDIACOM"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FlexBook_edge13-M-FBE13"),
+		},
+		.driver_data = (void *)&sipodev_desc
+	},
  	{
  		.ident = "Odys Winbook 13",
  		.matches = {
maintainer
#2 lore raw
Quoted 8 lines · Hans de Goede

Hi,

Quoted 4 lines · Federico Ricchiuto

The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does not supply descriptors, so it has to be added to the override list.

Quoted 7 lines

It looks like you copied and pasted part of the commit message from another patch (which is fine), but you need to update the Subject (the first line of the commit message) the Subject now still mentions the Trekstor Surfbook E11B rather then the Mediacom FlexBook edge13.

Otherwise this looks good to me.

Thanks. I've fixed up the subject and applied.

Signature · 2 lines
Jiri Kosina
SUSE Labs