Skip to contentSkip to conversation

ALSA: usb-audio: Fix potential use-after-free of streams

PATCH New Takashi Iwai 1 participant 1 message Jun 16, 2020 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Fix potential use-after-free of streams

With the recent full-duplex support of implicit feedback streams, an endpoint can be still running after closing the capture stream as long as the playback stream with the sync-endpoint is running. In such a state, the URBs are still be handled and they may call retire_data_urb callback, which tries to transfer the data from the PCM buffer. Since the PCM stream gets closed, this may lead to use-after-free.

This patch adds the proper clearance of the callback at stopping the capture stream for addressing the possible UAF above.

Fixes 10ce77e4817f ("ALSA: usb-audio: Add duplex sound support for USB devices using implicit feedback")
---
 sound/usb/pcm.c | 1 +
 1 file changed, 1 insertion(+)
sound/usb/pcm.c +1 -0
index 84c0ae431936..a777d36c4f5a 100644
@@ -1787,6 +1787,7 @@ static int snd_usb_substream_capture_trigger(struct snd_pcm_substream *substream
 		return 0;
 	case SNDRV_PCM_TRIGGER_STOP:
 		stop_endpoints(subs);
+		subs->data_endpoint->retire_data_urb = NULL;
 		subs->running = 0;
 		return 0;
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
Signature · 1 line
2.25.0