btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()
PATCH 1/1 btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()
In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() was incorrectly paired with kzfree(). According to David Sterba, there isn't any sensitive information in the subvol_info that needs to be cleared before freeing. So kzfree() isn't really needed, use kfree() instead.
Reported-by David Sterba <[email protected]>
Signed-off-by Waiman Long <[email protected]>
--- fs/btrfs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/ioctl.c +1 -1
@@ -2692,7 +2692,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)btrfs_put_root (root); out_free:btrfs_free_path (path); -kzfree (subvol_info); +kfree (subvol_info);return ret; }
Signature · 1 line
2.18.1
Quoted 8 lines · Waiman Long
In
btrfs_ioctl_get_subvol_info(), there is a classic case wherekzalloc()was incorrectly paired withkzfree(). According to David Sterba, there isn't any sensitive information in thesubvol_infothat needs to be cleared before freeing. Sokzfree()isn't really needed, usekfree()instead.Reported-by David Sterba <[email protected]>Signed-off-by Waiman Long <[email protected]>
Added to the devel patch queue, thanks.