rapidio/rio_mport_cdev: Use array_size() helper in copy_{from,to}_user()
PATCH 1/1 rapidio/rio_mport_cdev: Use array_size() helper in copy_{from,to}_user()
Use array_size() helper instead of the open-coded version in copy_{from,to}_user(). These sorts of multiplication factors need to be wrapped in array_size().
This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
--- drivers/rapidio/devices/rio_mport_cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/rapidio/devices/rio_mport_cdev.c +2 -2
@@ -981,7 +981,7 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)if (unlikely (copy_from_user (transfer, (void __user *)(uintptr_t )transaction.block, - transaction.count *sizeof (*transfer)))) { +array_size (sizeof (*transfer), transaction.count)))) { ret = -EFAULT ; goto out_free; }
@@ -994,7 +994,7 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)if (unlikely (copy_to_user ((void __user *)(uintptr_t )transaction.block, transfer, - transaction.count *sizeof (*transfer)))) +array_size (sizeof (*transfer), transaction.count)))) ret = -EFAULT ; out_free:
Signature · 1 line
2.27.0
Quoted 9 lines · Gustavo A. R. Silva
Use
array_size()helper instead of the open-coded version in copy_{from,to}_user(). These sorts of multiplication factors need to be wrapped inarray_size().This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>
Signature · 1 line
Kees Cook
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
Quoted 36 lines · Gustavo A. R. Silva
Use
array_size()helper instead of the open-coded version in copy_{from,to}_user(). These sorts of multiplication factors need to be wrapped inarray_size().This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/rapidio/devices/rio_mport_cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/rapidio/devices/rio_mport_cdev.c +2
-2@@ -981,7 +981,7 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)if (unlikely (copy_from_user (transfer, (void __user *)(uintptr_t )transaction.block, - transaction.count *sizeof (*transfer)))) { +array_size (sizeof (*transfer), transaction.count)))) { ret = -EFAULT ; goto out_free; }@@ -994,7 +994,7 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)if (unlikely (copy_to_user ((void __user *)(uintptr_t )transaction.block, transfer, - transaction.count *sizeof (*transfer)))) +array_size (sizeof (*transfer), transaction.count)))) ret = -EFAULT ; out_free: