nfs4: strengthen error check to avoid unexpected result
Subsystems (2)
PATCH 1/1 nfs4: strengthen error check to avoid unexpected result
The variable error is ssize_t, which is signed and will cast to unsigned when comapre with variable size, so add a check to avoid unexpected result in case of negative value of error.
Signed-off-by Chengguang Xu <[email protected]>
--- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4proc.c +1 -1
@@ -7392,7 +7392,7 @@ nfs4_listxattr_nfs4_label(struct inode *inode, char *list, size_t list_len)if (nfs_server_capable (inode,NFS_CAP_SECURITY_LABEL )) { len =security_inode_listsecurity (inode, list, list_len); -if (list_len && len > list_len) +if (len >=0 && list_len && len > list_len)return -ERANGE ; }return len;
Signature · 1 line
2.20.1