Skip to contentSkip to conversation

kbuild: remove AS variable

PATCH Applied Masahiro Yamada 2 participants 2 messages Jun 17, 2020

Subsystems (2)
Arm (32-bit) Kbuild
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 kbuild: remove AS variable

The assembler files in the barebox are *.S instead of *.s, so they must be preprocessed. Since 'as' of GNU binutils is not able to preprocess, we always use $(CC) as an assembler driver.

Remove AS variable.

Linux also removed AS. See Linux commits:

aa824e0c962b ("kbuild: remove AS variable") 1ca0c2f61211 ("kbuild: remove unused AS assignment")

Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile          | 3 +--
 arch/arm/Makefile | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)
Makefile +1 -2
index d483302fe..efb5fc9ee 100644
@@ -372,7 +372,6 @@ KBUILD_HOSTLDLIBS   := $(HOST_LFS_LIBS) $(HOSTLDLIBS)
 
 # Make variables (CC, etc...)
 
-AS		= $(CROSS_COMPILE)as
 LD		= $(CROSS_COMPILE)ld
 CC		= $(CROSS_COMPILE)gcc
 CPP		= $(CC) -E

@@ -425,7 +424,7 @@ LDFLAGS_barebox	:= -Map barebox.map
 LDFLAGS_barebox += $(call ld-option, --no-dynamic-linker)
 LDFLAGS_pbl += $(call ld-option, --no-dynamic-linker)
 
-export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE AS LD CC
+export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC
 export CPP AR NM STRIP OBJCOPY OBJDUMP MAKE AWK GENKSYMS PERL PYTHON3 UTS_MACHINE
 export LEX YACC
 export HOSTCXX CHECK CHECKFLAGS
arch/arm/Makefile +0 -2
index 6c7373c20..46dfe1f62 100644
@@ -10,11 +10,9 @@ endif
 
 ifeq ($(CONFIG_CPU_BIG_ENDIAN),y)
 KBUILD_CPPFLAGS	+= -mbig-endian
-AS		+= -EB
 LD		+= -EB
 else
 KBUILD_CPPFLAGS	+= -mlittle-endian
-AS		+= -EL
 LD		+= -EL
 endif
Signature · 7 lines
2.25.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 11 lines · Masahiro Yamada

The assembler files in the barebox are *.S instead of *.s, so they must be preprocessed. Since 'as' of GNU binutils is not able to preprocess, we always use $(CC) as an assembler driver.

Remove AS variable.

Linux also removed AS. See Linux commits:

aa824e0c962b ("kbuild: remove AS variable") 1ca0c2f61211 ("kbuild: remove unused AS assignment")

Quoted 6 lines
Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile          | 3 +--
 arch/arm/Makefile | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

Applied, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox